code style

This commit is contained in:
Links
2020-11-21 14:07:14 +01:00
parent 28cd929e7e
commit f20fbbfcd9
3 changed files with 20 additions and 25 deletions

View File

@ -42,7 +42,11 @@
#ifndef NODEBUG_WEBSOCKETS #ifndef NODEBUG_WEBSOCKETS
#ifdef DEBUG_ESP_PORT #ifdef DEBUG_ESP_PORT
#define DEBUG_WEBSOCKETS(...) { DEBUG_ESP_PORT.printf(__VA_ARGS__); DEBUG_ESP_PORT.flush(); } #define DEBUG_WEBSOCKETS(...) \
{ \
DEBUG_ESP_PORT.printf(__VA_ARGS__); \
DEBUG_ESP_PORT.flush(); \
}
#else #else
//#define DEBUG_WEBSOCKETS(...) os_printf( __VA_ARGS__ ) //#define DEBUG_WEBSOCKETS(...) os_printf( __VA_ARGS__ )
#endif #endif

View File

@ -30,22 +30,18 @@
#if WEBSOCKETS_NETWORK_TYPE == NETWORK_ESP8266 && WEBSERVER_HAS_HOOK #if WEBSOCKETS_NETWORK_TYPE == NETWORK_ESP8266 && WEBSERVER_HAS_HOOK
class WebSockets4WebServer: public WebSocketsServerCore { class WebSockets4WebServer : public WebSocketsServerCore {
public: public:
WebSockets4WebServer(const String & origin = "", const String & protocol = "arduino")
WebSockets4WebServer(const String& origin = "", const String& protocol = "arduino"): : WebSocketsServerCore(origin, protocol) {
WebSocketsServerCore(origin, protocol)
{
begin(); begin();
} }
ESP8266WebServer::HookFunction hookForWebserver (const String& wsRootDir, WebSocketServerEvent event) ESP8266WebServer::HookFunction hookForWebserver(const String & wsRootDir, WebSocketServerEvent event) {
{
onEvent(event); onEvent(event);
return [&, wsRootDir](const String & method, const String & url, WiFiClient * tcpClient, ESP8266WebServer::ContentTypeFunction contentType) return [&, wsRootDir](const String & method, const String & url, WiFiClient * tcpClient, ESP8266WebServer::ContentTypeFunction contentType) {
{ if(!(method == "GET" && url.indexOf(wsRootDir) == 0)) {
if (!(method == "GET" && url.indexOf(wsRootDir) == 0)) {
return ESP8266WebServer::CLIENT_REQUEST_CAN_CONTINUE; return ESP8266WebServer::CLIENT_REQUEST_CAN_CONTINUE;
} }
@ -55,8 +51,7 @@ class WebSockets4WebServer: public WebSocketsServerCore {
// Then initialize a new WSclient_t (like in WebSocketsServer::handleNewClient()) // Then initialize a new WSclient_t (like in WebSocketsServer::handleNewClient())
WSclient_t * client = handleNewClient(newTcpClient); WSclient_t * client = handleNewClient(newTcpClient);
if (client) if(client) {
{
// give "GET <url>" // give "GET <url>"
String headerLine; String headerLine;
headerLine.reserve(url.length() + 5); headerLine.reserve(url.length() + 5);

View File

@ -33,8 +33,7 @@
class WebSocketsServerCore : protected WebSockets { class WebSocketsServerCore : protected WebSockets {
public: public:
WebSocketsServerCore(const String & origin = "", const String & protocol = "arduino");
WebSocketsServerCore(const String& origin = "", const String& protocol = "arduino");
virtual ~WebSocketsServerCore(void); virtual ~WebSocketsServerCore(void);
void begin(void); void begin(void);
@ -207,7 +206,7 @@ class WebSocketsServerCore : protected WebSockets {
/** /**
* drop native tcp connection (client->tcp) * drop native tcp connection (client->tcp)
*/ */
void dropNativeClient (WSclient_t * client); void dropNativeClient(WSclient_t * client);
private: private:
/* /*
@ -215,13 +214,11 @@ class WebSocketsServerCore : protected WebSockets {
* @param headerName String ///< the name of the header being checked * @param headerName String ///< the name of the header being checked
*/ */
bool hasMandatoryHeader(String headerName); bool hasMandatoryHeader(String headerName);
}; };
class WebSocketsServer: public WebSocketsServerCore { class WebSocketsServer : public WebSocketsServerCore {
public: public:
WebSocketsServer(uint16_t port, const String & origin = "", const String & protocol = "arduino");
WebSocketsServer(uint16_t port, const String& origin = "", const String& protocol = "arduino");
virtual ~WebSocketsServer(void); virtual ~WebSocketsServer(void);
void begin(void); void begin(void);
@ -235,7 +232,6 @@ class WebSocketsServer: public WebSocketsServerCore {
#endif #endif
protected: protected:
#if(WEBSOCKETS_NETWORK_TYPE != NETWORK_ESP8266_ASYNC) #if(WEBSOCKETS_NETWORK_TYPE != NETWORK_ESP8266_ASYNC)
void handleNewClients(void); void handleNewClients(void);
#endif #endif