From d46dba61489504e5b4226cde891c8c7822dde5f1 Mon Sep 17 00:00:00 2001
From: Matthew Bucci <buccim2@gene.com>
Date: Thu, 17 Oct 2024 01:18:11 -0700
Subject: [PATCH 1/2] numeric rewriting should be case insensitive

---
 pg4wp/rewriters/CreateTableSQLRewriter.php |  2 +-
 tests/rewriteTest.php                      | 27 ++++++++++++++++++++--
 2 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/pg4wp/rewriters/CreateTableSQLRewriter.php b/pg4wp/rewriters/CreateTableSQLRewriter.php
index 0e26ba4..66deb10 100644
--- a/pg4wp/rewriters/CreateTableSQLRewriter.php
+++ b/pg4wp/rewriters/CreateTableSQLRewriter.php
@@ -96,7 +96,7 @@ class CreateTableSQLRewriter extends AbstractSQLRewriter
         $numeric_types_imploded = implode('|', $numeric_types);
 
         // Prepare regex pattern to match 'type(x)'
-        $pattern = "/(" . $numeric_types_imploded . ")\(\d+\)/";
+        $pattern = "/(" . $numeric_types_imploded . ")\(\d+\)/i";
 
         // Execute type find & replace
         $sql = preg_replace_callback($pattern, function ($matches) {
diff --git a/tests/rewriteTest.php b/tests/rewriteTest.php
index 2bbeeaf..4e81d5e 100644
--- a/tests/rewriteTest.php
+++ b/tests/rewriteTest.php
@@ -96,6 +96,29 @@ final class rewriteTest extends TestCase
         $this->assertSame(trim($expected), trim($postgresql));
     }
 
+    public function test_it_handles_numerics_without_auto_incrment_case_insensitively()
+    {
+        $sql = <<<SQL
+            CREATE TABLE IF NOT EXISTS stars_votes (
+                voter_ip VARCHAR(150) NOT NULL,
+                post_id BIGINT(20) UNSIGNED NOT NULL,
+                rating INT(1) UNSIGNED NOT NULL,
+                PRIMARY KEY  (voter_ip, post_id)
+            )
+        SQL;
+
+        $expected = <<<SQL
+            CREATE TABLE IF NOT EXISTS stars_votes (
+                voter_ip VARCHAR(150) NOT NULL,
+                post_id BIGINT  NOT NULL,
+                rating INT  NOT NULL,
+                PRIMARY KEY  (voter_ip, post_id)
+            );
+        SQL;
+
+        $postgresql = pg4wp_rewrite($sql);
+        $this->assertSame(trim($expected), trim($postgresql));
+    }
 
     public function test_it_handles_keys()
     {
@@ -229,8 +252,8 @@ final class rewriteTest extends TestCase
                 platform varchar(255),
                 version varchar(255),
                 location varchar(10),
-                user_id BIGINT(48) NOT NULL,
-                page_id BIGINT(48) NOT NULL,
+                user_id BIGINT NOT NULL,
+                page_id BIGINT NOT NULL,
                 type VARCHAR(100) NOT NULL,
                 PRIMARY KEY  ( "ID" )
             );

From b463ead79fe2b3431c38a80faafee5a4109941b8 Mon Sep 17 00:00:00 2001
From: Matthew Bucci <buccim2@gene.com>
Date: Thu, 17 Oct 2024 01:25:16 -0700
Subject: [PATCH 2/2] convert mediumints to ints

---
 pg4wp/rewriters/CreateTableSQLRewriter.php |  4 +-
 tests/rewriteTest.php                      | 57 ++++++++++++++++++++++
 2 files changed, 59 insertions(+), 2 deletions(-)

diff --git a/pg4wp/rewriters/CreateTableSQLRewriter.php b/pg4wp/rewriters/CreateTableSQLRewriter.php
index 66deb10..3a1dcb8 100644
--- a/pg4wp/rewriters/CreateTableSQLRewriter.php
+++ b/pg4wp/rewriters/CreateTableSQLRewriter.php
@@ -21,8 +21,8 @@ class CreateTableSQLRewriter extends AbstractSQLRewriter
         ' CHARACTER SET utf8' => '',
         ' DEFAULT CHARSET=utf8' => '',
 
-        // For flash-album-gallery plugin
-        ' tinyint'		=> ' smallint'
+        ' tinyint'		=> ' smallint',
+        ' mediumint'    => ' integer'
     ];
 
     public function rewrite(): string
diff --git a/tests/rewriteTest.php b/tests/rewriteTest.php
index 4e81d5e..e755540 100644
--- a/tests/rewriteTest.php
+++ b/tests/rewriteTest.php
@@ -654,6 +654,63 @@ final class rewriteTest extends TestCase
         $this->assertSame(trim($expected), trim($postgresql));
     }
 
+    public function test_it_rewrites_mediumints() 
+    {
+        $sql = <<<SQL
+            CREATE TABLE wp_relevanssi (
+                doc bigint(20) NOT NULL DEFAULT '0',
+                term varchar(50) NOT NULL DEFAULT '0',
+                term_reverse varchar(50) NOT NULL DEFAULT '0',
+                content mediumint(9) NOT NULL DEFAULT '0',
+                title mediumint(9) NOT NULL DEFAULT '0',
+                comment mediumint(9) NOT NULL DEFAULT '0',
+                tag mediumint(9) NOT NULL DEFAULT '0',
+                link mediumint(9) NOT NULL DEFAULT '0',
+                author mediumint(9) NOT NULL DEFAULT '0',
+                category mediumint(9) NOT NULL DEFAULT '0',
+                excerpt mediumint(9) NOT NULL DEFAULT '0',
+                taxonomy mediumint(9) NOT NULL DEFAULT '0',
+                customfield mediumint(9) NOT NULL DEFAULT '0',
+                mysqlcolumn MEDIUMINT(9) NOT NULL DEFAULT '0',
+                taxonomy_detail longtext NOT NULL,
+                customfield_detail longtext NOT NULL DEFAULT '',
+                mysqlcolumn_detail longtext NOT NULL DEFAULT '',
+                type varchar(210) NOT NULL DEFAULT 'post',
+                item bigint(20) NOT NULL DEFAULT '0',
+                PRIMARY KEY doctermitem (doc, term, item)
+                ) DEFAULT CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_520_ci
+        SQL;
+
+        $expected = <<<SQL
+            CREATE TABLE IF NOT EXISTS wp_relevanssi (
+                doc bigint NOT NULL DEFAULT '0',
+                term varchar(50) NOT NULL DEFAULT '0',
+                term_reverse varchar(50) NOT NULL DEFAULT '0',
+                content integer NOT NULL DEFAULT '0',
+                title integer NOT NULL DEFAULT '0',
+                comment integer NOT NULL DEFAULT '0',
+                tag integer NOT NULL DEFAULT '0',
+                link integer NOT NULL DEFAULT '0',
+                author integer NOT NULL DEFAULT '0',
+                category integer NOT NULL DEFAULT '0',
+                excerpt integer NOT NULL DEFAULT '0',
+                taxonomy integer NOT NULL DEFAULT '0',
+                customfield integer NOT NULL DEFAULT '0',
+                mysqlcolumn integer NOT NULL DEFAULT '0',
+                taxonomy_detail text NOT NULL,
+                customfield_detail text NOT NULL DEFAULT '',
+                mysqlcolumn_detail text NOT NULL DEFAULT '',
+                type varchar(210) NOT NULL DEFAULT 'post',
+                item bigint NOT NULL DEFAULT '0',
+                PRIMARY KEY doctermitem (doc, term, item)
+                );
+        SQL;
+
+        $postgresql = pg4wp_rewrite($sql);
+        $this->assertSame(trim($expected), trim($postgresql));
+    }
+
+