TartanLlama/optional
1
0
Fork 1
mirror of https://github.com/TartanLlama/optional.git synced 2025-07-29 17:37:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #53 from Tindarid/master

Browse Source 
Remove `noexcept` specifier for `construct()`
This commit is contained in:
Sy Brand
2023-02-24 09:21:00 +00:00
committed by GitHub
parent ee3326fac7 5d3e7d20d4
commit f34e20b228
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/tl/optional.hpp
View File

@ -409,7 +409,7 @@ template <class T> struct optional_operations_base : optional_storage_base<T> {
this->m_has_value = false; this->m_has_value = false;
} }
template <class... Args> void construct(Args &&... args) noexcept { template <class... Args> void construct(Args &&... args) {
new (std::addressof(this->m_value)) T(std::forward<Args>(args)...); new (std::addressof(this->m_value)) T(std::forward<Args>(args)...);
this->m_has_value = true; this->m_has_value = true;
} }

11
tests/emplace.cpp
View File

@ -11,3 +11,14 @@ TEST_CASE("Emplace", "[emplace]") {
REQUIRE(i->second.first == 3); REQUIRE(i->second.first == 3);
REQUIRE(i->second.second == 4); REQUIRE(i->second.second == 4);
} }
struct A {
A() {
throw std::exception();
}
};
TEST_CASE("Emplace with exception thrown", "[emplace]") {
tl::optional<A> a;
REQUIRE_THROWS(a.emplace());
}