Minor cleanup using inspections + Https

* Use https for maven repositories if possible
* Fix typos
* Merge ProtocolLib listeners into one class
* Upgrade maven plugins and dependencies

core/src/main/java/com/github/games647/fastlogin/core/AuthStorage.java

@@ -15,6 +15,8 @@ import java.util.UUID;
 import java.util.concurrent.ThreadFactory;
 import java.util.logging.Level;
 
+import javax.sql.DataSource;
+
 public class AuthStorage {
 
     private static final String PREMIUM_TABLE = "premium";
@@ -63,7 +65,7 @@ public class AuthStorage {
         this.dataSource = new HikariDataSource(databaseConfig);
     }
 
-    public HikariDataSource getDataSource() {
+    public DataSource getDataSource() {
         return dataSource;
     }
 
@@ -83,7 +85,7 @@ public class AuthStorage {
                     + "LastLogin TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, "
                     //the premium shouldn't steal the cracked account by changing the name
                     + "UNIQUE (Name) "
-                    + ")";
+                    + ')';
 
             if (dataSource.getJdbcUrl().contains("sqlite")) {
                 createDataStmt = createDataStmt.replace("AUTO_INCREMENT", "AUTOINCREMENT");
@@ -142,11 +144,9 @@ public class AuthStorage {
                 boolean premium = resultSet.getBoolean(4);
                 String lastIp = resultSet.getString(5);
                 long lastLogin = resultSet.getTimestamp(6).getTime();
-                PlayerProfile playerProfile = new PlayerProfile(userId, uuid, name, premium, lastIp, lastLogin);
-                return playerProfile;
+                return new PlayerProfile(userId, uuid, name, premium, lastIp, lastLogin);
             } else {
-                PlayerProfile crackedProfile = new PlayerProfile(null, name, false, "");
-                return crackedProfile;
+                return new PlayerProfile(null, name, false, "");
             }
         } catch (SQLException sqlEx) {
             core.getPlugin().getLogger().log(Level.SEVERE, "Failed to query profile", sqlEx);
@@ -176,8 +176,7 @@ public class AuthStorage {
                 boolean premium = resultSet.getBoolean(4);
                 String lastIp = resultSet.getString(5);
                 long lastLogin = resultSet.getTimestamp(6).getTime();
-                PlayerProfile playerProfile = new PlayerProfile(userId, uuid, name, premium, lastIp, lastLogin);
-                return playerProfile;
+                return new PlayerProfile(userId, uuid, name, premium, lastIp, lastLogin);
             }
         } catch (SQLException sqlEx) {
             core.getPlugin().getLogger().log(Level.SEVERE, "Failed to query profile", sqlEx);

core/src/main/java/com/github/games647/fastlogin/core/CompatibleCacheBuilder.java

@@ -54,7 +54,7 @@ public class CompatibleCacheBuilder<K, V> {
      * @param concurrencyLevel New concurrency level
      * @return This for chaining
      *
-     * @throws IllegalArgumentException if {@code concurrencyLevel} is nonpositive
+     * @throws IllegalArgumentException if {@code concurrencyLevel} is non-positive
      * @throws IllegalStateException if a concurrency level was already set
      */
     public CompatibleCacheBuilder<K, V> concurrencyLevel(int concurrencyLevel) {
@@ -76,7 +76,7 @@ public class CompatibleCacheBuilder<K, V> {
      * <p>
      * Expired entries may be counted by {@link com.google.common.cache.Cache#size Cache.size()}, but will never be
      * visible to read or write operations. Expired entries are currently cleaned up during write operations, or during
-     * occasional read operations in the absense of writes; though this behavior may change in the future.
+     * occasional read operations in the absence of writes; though this behavior may change in the future.
      *
      * @param duration the length of time after an entry is last accessed that it should be automatically removed
      * @param unit the unit that {@code duration} is expressed in
@@ -102,7 +102,7 @@ public class CompatibleCacheBuilder<K, V> {
      * <p>
      * Expired entries may be counted by {@link com.google.common.cache.Cache#size Cache.size()}, but will never be
      * visible to read or write operations. Expired entries are currently cleaned up during write operations, or during
-     * occasional read operations in the absense of writes; though this behavior may change in the future.
+     * occasional read operations in the absence of writes; though this behavior may change in the future.
      *
      * @param duration the length of time after an entry is created that it should be automatically removed
      * @param unit the unit that {@code duration} is expressed in
@@ -284,7 +284,7 @@ public class CompatibleCacheBuilder<K, V> {
      */
     @SuppressWarnings("unchecked")
     public <K1 extends K, V1 extends V> ConcurrentMap<K1, V1> build(CacheLoader<? super K1, V1> loader) {
-        Object cache = null;
+        Object cache;
 
         if (BUILD_METHOD == null) {
             try {

core/src/main/java/com/github/games647/fastlogin/core/hooks/PasswordGenerator.java

@@ -1,5 +1,6 @@
 package com.github.games647.fastlogin.core.hooks;
 
+@FunctionalInterface
 public interface PasswordGenerator<P> {
 
     String getRandomPassword(P player);

core/src/main/java/com/github/games647/fastlogin/core/shared/FastLoginCore.java

@@ -21,6 +21,7 @@ import java.nio.file.Path;
 import java.sql.Connection;
 import java.sql.DriverManager;
 import java.sql.SQLException;
+import java.util.Collection;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
@@ -60,10 +61,10 @@ public class FastLoginCore<P extends C, C, T extends PlatformPlugin<C>> {
         }
 
         return UUID.fromString(withoutDashes.substring(0, 8)
-                + "-" + withoutDashes.substring(8, 12)
-                + "-" + withoutDashes.substring(12, 16)
-                + "-" + withoutDashes.substring(16, 20)
-                + "-" + withoutDashes.substring(20, 32));
+                + '-' + withoutDashes.substring(8, 12)
+                + '-' + withoutDashes.substring(12, 16)
+                + '-' + withoutDashes.substring(16, 20)
+                + '-' + withoutDashes.substring(20, 32));
     }
 
     protected final Map<String, String> localeMessages = new ConcurrentHashMap<>();
@@ -198,7 +199,7 @@ public class FastLoginCore<P extends C, C, T extends PlatformPlugin<C>> {
             } else {
                 Class.forName("com.mysql.jdbc.Driver");
 
-                String jdbcUrl = "jdbc:mysql://" + host + "/" + database;
+                String jdbcUrl = "jdbc:mysql://" + host + '/' + database;
                 Connection con = DriverManager.getConnection(jdbcUrl, username, pass);
                 importer.importData(con, storage.getDataSource(), storage);
                 return true;
@@ -228,7 +229,7 @@ public class FastLoginCore<P extends C, C, T extends PlatformPlugin<C>> {
         return pendingLogins;
     }
 
-    public Set<UUID> getPendingConfirms() {
+    public Collection<UUID> getPendingConfirms() {
         return pendingConfirms;
     }
 

core/src/main/java/com/github/games647/fastlogin/core/shared/MojangApiConnector.java

@@ -10,7 +10,7 @@ import java.net.HttpURLConnection;
 import java.net.InetAddress;
 import java.net.URL;
 import java.net.UnknownHostException;
-import java.util.List;
+import java.util.Collection;
 import java.util.Set;
 import java.util.UUID;
 import java.util.concurrent.ConcurrentMap;
@@ -43,7 +43,7 @@ public abstract class MojangApiConnector {
 
     protected final Logger logger;
 
-    public MojangApiConnector(Logger logger, List<String> localAddresses, int rateLimit) {
+    public MojangApiConnector(Logger logger, Collection<String> localAddresses, int rateLimit) {
         this.logger = logger;
         
         if (rateLimit > 600) {
@@ -95,7 +95,7 @@ public abstract class MojangApiConnector {
                 if (connection.getResponseCode() == HttpURLConnection.HTTP_OK) {
                     BufferedReader reader = new BufferedReader(new InputStreamReader(connection.getInputStream()));
                     String line = reader.readLine();
-                    if (!line.equals("null")) {
+                    if (!"null".equals(line)) {
                         return FastLoginCore.parseId(getUUIDFromJson(line));
                     }
                 } else if (connection.getResponseCode() == RATE_LIMIT_CODE) {