From ce59172839ebc7f596ed543f9e353156d291aa27 Mon Sep 17 00:00:00 2001 From: games647 Date: Fri, 24 Jun 2022 16:58:14 +0200 Subject: [PATCH] Log signature verification errors to help administrators diff --git a/bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocollib/ProtocolLibListener.java b/bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocollib/ProtocolLibListener.java index c3e159a..da28f38 100644 --- a/bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocollib/ProtocolLibListener.java +++ b/bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocollib/ProtocolLibListener.java @@ -154,9 +154,11 @@ public class ProtocolLibListener extends PacketAdapter { plugin.getScheduler().runAsync(verifyTask); } else { sender.kickPlayer("Invalid signature"); + plugin.getLog().error("Invalid signature from player {}", sender); } - } catch (NoSuchAlgorithmException | InvalidKeyException | SignatureException e) { + } catch (NoSuchAlgorithmException | InvalidKeyException | SignatureException signatureEx) { sender.kickPlayer("Invalid signature"); + plugin.getLog().error("Invalid signature from player {}", sender, signatureEx); } } } --- .../bukkit/listener/protocollib/ProtocolLibListener.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocollib/ProtocolLibListener.java b/bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocollib/ProtocolLibListener.java index ea50a75f..f8273292 100644 --- a/bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocollib/ProtocolLibListener.java +++ b/bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocollib/ProtocolLibListener.java @@ -154,9 +154,11 @@ public class ProtocolLibListener extends PacketAdapter { plugin.getScheduler().runAsync(verifyTask); } else { sender.kickPlayer("Invalid signature"); + plugin.getLog().error("Invalid signature from player {}", sender); } - } catch (NoSuchAlgorithmException | InvalidKeyException | SignatureException e) { + } catch (NoSuchAlgorithmException | InvalidKeyException | SignatureException signatureEx) { sender.kickPlayer("Invalid signature"); + plugin.getLog().error("Invalid signature from player {}", sender, signatureEx); } } }