resolve review #222

src/Main/utils.cpp

@@ -82,7 +82,7 @@ float utils::getInvalidHumidity(void) { return INVALID_HUMIDITY; }
 
 int utils::getInvalidCO2(void) { return INVALID_CO2; }
 
-int utils::getInvalidPMS(void) { return INVALID_PMS; }
+int utils::getInvalidPmValue(void) { return INVALID_PMS; }
 
 int utils::getInvalidNOx(void) { return INVALID_NOX; }
 

src/Main/utils.h

@@ -21,7 +21,7 @@ public:
   static float getInvalidTemperature(void);
   static float getInvalidHumidity(void);
   static int getInvalidCO2(void);
-  static int getInvalidPMS(void);
+  static int getInvalidPmValue(void);
   static int getInvalidNOx(void);
   static int getInvalidVOC(void);
 };

src/PMS/PMS.cpp

@@ -158,11 +158,7 @@ void PMSBase::updateFailCount(void) {
   }
 }
 
-/**
- * @brief Reset number of fail
- * 
- */
-void PMSBase::resetFailCount(void) {failCount = 0;}
+void PMSBase::resetFailCount(void) { failCount = 0; }
 
 /**
  * @brief Get number of fail
@@ -171,11 +167,6 @@ void PMSBase::resetFailCount(void) {failCount = 0;}
  */
 int PMSBase::getFailCount(void) { return failCount; }
 
-/**
- * @brief Get maximum of fail count max
- * 
- * @return int 
- */
 int PMSBase::getFailCountMax(void) { return failCountMax; }
 
 /**

src/PMS/PMS5003.cpp

@@ -176,18 +176,10 @@ void PMS5003::handle(void) { pms.handle(); }
  */
 bool PMS5003::isFailed(void) { return pms.isFailed(); }
 
-/**
- * @brief Increate number of fail
- * 
- */
 void PMS5003::updateFailCount(void) {
   pms.updateFailCount();
 }
 
-/**
- * @brief Reset fail count
- * 
- */
 void PMS5003::resetFailCount(void) {
   pms.resetFailCount();
 }

src/PMS/PMS5003T.cpp

@@ -216,18 +216,10 @@ void PMS5003T::handle(void) { pms.handle(); }
  */
 bool PMS5003T::isFailed(void) { return pms.isFailed(); }
 
-/**
- * @brief Increate number of fail
- * 
- */
 void PMS5003T::updateFailCount(void) {
   pms.updateFailCount();
 }
 
-/**
- * @brief Reset fail count
- * 
- */
 void PMS5003T::resetFailCount(void) {
   pms.resetFailCount();
 }