From 1839664137502146d0229565fc8b94089fb19dac Mon Sep 17 00:00:00 2001 From: samuelbles07 Date: Sat, 1 Feb 2025 14:20:54 +0700 Subject: [PATCH 1/3] Extend connect to server timeout Default 5s from HTTPClient --- src/AgApiClient.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/AgApiClient.cpp b/src/AgApiClient.cpp index 8de2596..b2dbf1f 100644 --- a/src/AgApiClient.cpp +++ b/src/AgApiClient.cpp @@ -59,6 +59,7 @@ bool AgApiClient::fetchServerConfiguration(void) { #else HTTPClient client; client.setTimeout(timeoutMs); + client.setConnectTimeout(timeoutMs); if (apiRootChanged) { // If apiRoot is changed, assume not using https if (client.begin(uri) == false) { @@ -134,6 +135,7 @@ bool AgApiClient::postToServer(String data) { #else HTTPClient client; client.setTimeout(timeoutMs); + client.setConnectTimeout(timeoutMs); if (apiRootChanged) { // If apiRoot is changed, assume not using https if (client.begin(uri) == false) { From 85ba13de129207ac65616eec5445b826b82e636b Mon Sep 17 00:00:00 2001 From: samuelbles07 Date: Wed, 5 Feb 2025 01:18:46 +0700 Subject: [PATCH 2/3] Set default ag client timeout to 15s --- src/AgApiClient.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/AgApiClient.h b/src/AgApiClient.h index 9f39ceb..8e52e76 100644 --- a/src/AgApiClient.h +++ b/src/AgApiClient.h @@ -31,7 +31,7 @@ private: bool getConfigFailed; bool postToServerFailed; bool notAvailableOnDashboard = false; // Device not setup on Airgradient cloud dashboard. - uint16_t timeoutMs = 10000; // Default set to 10s + uint16_t timeoutMs = 15000; // Default set to 15s public: AgApiClient(Stream &stream, Configuration &config); From 03f1b969c24f7d2ab762f52dbcdbddff4d6d935a Mon Sep 17 00:00:00 2001 From: samuelbles07 Date: Wed, 5 Feb 2025 01:24:59 +0700 Subject: [PATCH 3/3] Add comment describe two timeout functions call --- src/AgApiClient.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/AgApiClient.cpp b/src/AgApiClient.cpp index b2dbf1f..6eedcc9 100644 --- a/src/AgApiClient.cpp +++ b/src/AgApiClient.cpp @@ -58,8 +58,8 @@ bool AgApiClient::fetchServerConfiguration(void) { } #else HTTPClient client; - client.setTimeout(timeoutMs); - client.setConnectTimeout(timeoutMs); + client.setConnectTimeout(timeoutMs); // Set timeout when establishing connection to server + client.setTimeout(timeoutMs); // Timeout when waiting for response from AG server if (apiRootChanged) { // If apiRoot is changed, assume not using https if (client.begin(uri) == false) { @@ -134,8 +134,8 @@ bool AgApiClient::postToServer(String data) { } #else HTTPClient client; - client.setTimeout(timeoutMs); - client.setConnectTimeout(timeoutMs); + client.setConnectTimeout(timeoutMs); // Set timeout when establishing connection to server + client.setTimeout(timeoutMs); // Timeout when waiting for response from AG server if (apiRootChanged) { // If apiRoot is changed, assume not using https if (client.begin(uri) == false) {