Merge pull request #138 from airgradienthq/hotfix/ledbar-flickers

Fix LED bar flickers
This commit is contained in:
Phat Nguyen
2024-05-29 08:01:05 +07:00
committed by GitHub
5 changed files with 41 additions and 12 deletions

View File

@ -372,6 +372,7 @@ bool Configuration::parse(String data, bool isLocal) {
}
}
_ledBarModeChanged = false;
if (JSON.typeof_(root[jprop_ledBarMode]) == "string") {
String mode = root[jprop_ledBarMode];
if (mode == getLedBarModeName(LedBarMode::LedBarModeCO2) ||
@ -380,6 +381,7 @@ bool Configuration::parse(String data, bool isLocal) {
String oldMode = jconfig[jprop_ledBarMode];
if (mode != oldMode) {
jconfig[jprop_ledBarMode] = mode;
_ledBarModeChanged = true;
changed = true;
}
} else {
@ -559,6 +561,7 @@ bool Configuration::parse(String data, bool isLocal) {
}
}
ledBarBrightnessChanged = false;
if (JSON.typeof_(root[jprop_ledBarBrightness]) == "number") {
int value = root[jprop_ledBarBrightness];
int oldValue = jconfig[jprop_ledBarBrightness];
@ -1147,6 +1150,12 @@ void Configuration::setOfflineModeWithoutSave(bool offline) {
_offlineMode = offline;
}
bool Configuration::isLedBarModeChanged(void) {
bool changed = _ledBarModeChanged;
_ledBarModeChanged = false;
return changed;
}
bool Configuration::isDisplayBrightnessChanged(void) {
bool changed = displayBrightnessChanged;
displayBrightnessChanged = false;

View File

@ -18,6 +18,7 @@ private:
bool displayBrightnessChanged = false;
String otaNewFirmwareVersion;
bool _offlineMode = false;
bool _ledBarModeChanged = false;
AirGradient* ag;
@ -80,6 +81,7 @@ public:
bool isOfflineMode(void);
void setOfflineMode(bool offline);
void setOfflineModeWithoutSave(bool offline);
bool isLedBarModeChanged(void);
};
#endif /** _AG_CONFIG_H_ */

View File

@ -64,7 +64,7 @@ void LedBar::setColor(uint8_t red, uint8_t green, uint8_t blue, int ledNum) {
*
* @param brightness Brightness (0 - 100)%
*/
void LedBar::setBrighness(uint8_t brightness) {
void LedBar::setBrightness(uint8_t brightness) {
if (this->isBegin() == false) {
return;
}

View File

@ -19,7 +19,7 @@ public:
void begin(void);
void setColor(uint8_t red, uint8_t green, uint8_t blue, int ledNum);
void setColor(uint8_t red, uint8_t green, uint8_t blue);
void setBrighness(uint8_t brightness);
void setBrightness(uint8_t brightness);
int getNumberOfLeds(void);
void show(void);
void clear(void);