diff --git a/.clang-format b/.clang-format index 25f529f5..ac4c1061 100644 --- a/.clang-format +++ b/.clang-format @@ -5,6 +5,7 @@ Standard: Cpp03 AllowShortFunctionsOnASingleLine: Empty IncludeBlocks: Preserve IndentPPDirectives: AfterHash +DerivePointerAlignment: false # Always break after if to get accurate coverage AllowShortIfStatementsOnASingleLine: false diff --git a/extras/fuzzing/json_fuzzer.cpp b/extras/fuzzing/json_fuzzer.cpp index db9a3d6c..043cd426 100644 --- a/extras/fuzzing/json_fuzzer.cpp +++ b/extras/fuzzing/json_fuzzer.cpp @@ -1,6 +1,6 @@ #include -extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { +extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) { DynamicJsonDocument doc(4096); DeserializationError error = deserializeJson(doc, data, size); if (!error) { diff --git a/extras/fuzzing/msgpack_fuzzer.cpp b/extras/fuzzing/msgpack_fuzzer.cpp index e6235911..b6ab1414 100644 --- a/extras/fuzzing/msgpack_fuzzer.cpp +++ b/extras/fuzzing/msgpack_fuzzer.cpp @@ -1,6 +1,6 @@ #include -extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { +extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) { DynamicJsonDocument doc(4096); DeserializationError error = deserializeMsgPack(doc, data, size); if (!error) { diff --git a/extras/tests/JsonArray/std_string.cpp b/extras/tests/JsonArray/std_string.cpp index b7de0efb..0ad5440d 100644 --- a/extras/tests/JsonArray/std_string.cpp +++ b/extras/tests/JsonArray/std_string.cpp @@ -5,8 +5,8 @@ #include #include -static void eraseString(std::string &str) { - char *p = const_cast(str.c_str()); +static void eraseString(std::string& str) { + char* p = const_cast(str.c_str()); while (*p) *p++ = '*'; } diff --git a/extras/tests/JsonDocument/ElementProxy.cpp b/extras/tests/JsonDocument/ElementProxy.cpp index 0f4292f0..277b62c5 100644 --- a/extras/tests/JsonDocument/ElementProxy.cpp +++ b/extras/tests/JsonDocument/ElementProxy.cpp @@ -10,7 +10,7 @@ using namespace ARDUINOJSON_NAMESPACE; TEST_CASE("ElementProxy::add()") { DynamicJsonDocument doc(4096); doc.add(); - ElementProxy ep = doc[0]; + ElementProxy ep = doc[0]; SECTION("add(int)") { ep.add(42); @@ -36,7 +36,7 @@ TEST_CASE("ElementProxy::add()") { TEST_CASE("ElementProxy::clear()") { DynamicJsonDocument doc(4096); doc.add(); - ElementProxy ep = doc[0]; + ElementProxy ep = doc[0]; SECTION("size goes back to zero") { ep.add(42); @@ -96,7 +96,7 @@ TEST_CASE("ElementProxy::operator==()") { TEST_CASE("ElementProxy::remove()") { DynamicJsonDocument doc(4096); doc.add(); - ElementProxy ep = doc[0]; + ElementProxy ep = doc[0]; SECTION("remove(int)") { ep.add(1); @@ -143,7 +143,7 @@ TEST_CASE("ElementProxy::remove()") { TEST_CASE("ElementProxy::set()") { DynamicJsonDocument doc(4096); - ElementProxy ep = doc[0]; + ElementProxy ep = doc[0]; SECTION("set(int)") { ep.set(42); @@ -169,7 +169,7 @@ TEST_CASE("ElementProxy::set()") { TEST_CASE("ElementProxy::size()") { DynamicJsonDocument doc(4096); doc.add(); - ElementProxy ep = doc[0]; + ElementProxy ep = doc[0]; SECTION("returns 0") { REQUIRE(ep.size() == 0); @@ -191,7 +191,7 @@ TEST_CASE("ElementProxy::size()") { TEST_CASE("ElementProxy::memoryUsage()") { DynamicJsonDocument doc(4096); doc.add(); - ElementProxy ep = doc[0]; + ElementProxy ep = doc[0]; SECTION("returns 0 for null") { REQUIRE(ep.memoryUsage() == 0); @@ -205,7 +205,7 @@ TEST_CASE("ElementProxy::memoryUsage()") { TEST_CASE("ElementProxy::operator[]") { DynamicJsonDocument doc(4096); - ElementProxy ep = doc[1]; + ElementProxy ep = doc[1]; SECTION("set member") { ep["world"] = 42; @@ -224,7 +224,7 @@ TEST_CASE("ElementProxy cast to JsonVariantConst") { DynamicJsonDocument doc(4096); doc[0] = "world"; - const ElementProxy ep = doc[0]; + const ElementProxy ep = doc[0]; JsonVariantConst var = ep; @@ -235,7 +235,7 @@ TEST_CASE("ElementProxy cast to JsonVariant") { DynamicJsonDocument doc(4096); doc[0] = "world"; - ElementProxy ep = doc[0]; + ElementProxy ep = doc[0]; JsonVariant var = ep; diff --git a/extras/tests/JsonDocument/MemberProxy.cpp b/extras/tests/JsonDocument/MemberProxy.cpp index b9e2b749..99ff62d5 100644 --- a/extras/tests/JsonDocument/MemberProxy.cpp +++ b/extras/tests/JsonDocument/MemberProxy.cpp @@ -9,7 +9,7 @@ using namespace ARDUINOJSON_NAMESPACE; TEST_CASE("MemberProxy::add()") { DynamicJsonDocument doc(4096); - MemberProxy mp = doc["hello"]; + MemberProxy mp = doc["hello"]; SECTION("add(int)") { mp.add(42); @@ -26,7 +26,7 @@ TEST_CASE("MemberProxy::add()") { TEST_CASE("MemberProxy::clear()") { DynamicJsonDocument doc(4096); - MemberProxy mp = doc["hello"]; + MemberProxy mp = doc["hello"]; SECTION("size goes back to zero") { mp.add(42); @@ -85,7 +85,7 @@ TEST_CASE("MemberProxy::operator==()") { TEST_CASE("MemberProxy::containsKey()") { DynamicJsonDocument doc(4096); - MemberProxy mp = doc["hello"]; + MemberProxy mp = doc["hello"]; SECTION("containsKey(const char*)") { mp["key"] = "value"; @@ -115,9 +115,9 @@ TEST_CASE("MemberProxy::operator|()") { SECTION("Issue #1411") { doc["sensor"] = "gps"; - const char *test = "test"; // <- the literal must be captured in a variable + const char* test = "test"; // <- the literal must be captured in a variable // to trigger the bug - const char *sensor = doc["sensor"] | test; // "gps" + const char* sensor = doc["sensor"] | test; // "gps" REQUIRE(sensor == std::string("gps")); } @@ -136,7 +136,7 @@ TEST_CASE("MemberProxy::operator|()") { TEST_CASE("MemberProxy::remove()") { DynamicJsonDocument doc(4096); - MemberProxy mp = doc["hello"]; + MemberProxy mp = doc["hello"]; SECTION("remove(int)") { mp.add(1); @@ -183,7 +183,7 @@ TEST_CASE("MemberProxy::remove()") { TEST_CASE("MemberProxy::set()") { DynamicJsonDocument doc(4096); - MemberProxy mp = doc["hello"]; + MemberProxy mp = doc["hello"]; SECTION("set(int)") { mp.set(42); @@ -208,7 +208,7 @@ TEST_CASE("MemberProxy::set()") { TEST_CASE("MemberProxy::size()") { DynamicJsonDocument doc(4096); - MemberProxy mp = doc["hello"]; + MemberProxy mp = doc["hello"]; SECTION("returns 0") { REQUIRE(mp.size() == 0); @@ -231,7 +231,7 @@ TEST_CASE("MemberProxy::size()") { TEST_CASE("MemberProxy::memoryUsage()") { DynamicJsonDocument doc(4096); - MemberProxy mp = doc["hello"]; + MemberProxy mp = doc["hello"]; SECTION("returns 0 when null") { REQUIRE(mp.memoryUsage() == 0); @@ -245,7 +245,7 @@ TEST_CASE("MemberProxy::memoryUsage()") { TEST_CASE("MemberProxy::operator[]") { DynamicJsonDocument doc(4096); - MemberProxy mp = doc["hello"]; + MemberProxy mp = doc["hello"]; SECTION("set member") { mp["world"] = 42; @@ -264,7 +264,7 @@ TEST_CASE("MemberProxy cast to JsonVariantConst") { DynamicJsonDocument doc(4096); doc["hello"] = "world"; - const MemberProxy mp = doc["hello"]; + const MemberProxy mp = doc["hello"]; JsonVariantConst var = mp; @@ -275,7 +275,7 @@ TEST_CASE("MemberProxy cast to JsonVariant") { DynamicJsonDocument doc(4096); doc["hello"] = "world"; - MemberProxy mp = doc["hello"]; + MemberProxy mp = doc["hello"]; JsonVariant var = mp; diff --git a/extras/tests/JsonObject/std_string.cpp b/extras/tests/JsonObject/std_string.cpp index e985421e..44bf1461 100644 --- a/extras/tests/JsonObject/std_string.cpp +++ b/extras/tests/JsonObject/std_string.cpp @@ -5,8 +5,8 @@ #include #include -static void eraseString(std::string &str) { - char *p = const_cast(str.c_str()); +static void eraseString(std::string& str) { + char* p = const_cast(str.c_str()); while (*p) *p++ = '*'; } diff --git a/extras/tests/JsonSerializer/CustomWriter.cpp b/extras/tests/JsonSerializer/CustomWriter.cpp index 05d87040..d4ba459c 100644 --- a/extras/tests/JsonSerializer/CustomWriter.cpp +++ b/extras/tests/JsonSerializer/CustomWriter.cpp @@ -14,18 +14,18 @@ class CustomWriter { return 1; } - size_t write(const uint8_t *s, size_t n) { - _str.append(reinterpret_cast(s), n); + size_t write(const uint8_t* s, size_t n) { + _str.append(reinterpret_cast(s), n); return n; } - const std::string &str() const { + const std::string& str() const { return _str; } private: - CustomWriter(const CustomWriter &); // non-copiable - CustomWriter &operator=(const CustomWriter &); + CustomWriter(const CustomWriter&); // non-copiable + CustomWriter& operator=(const CustomWriter&); std::string _str; }; diff --git a/extras/tests/JsonSerializer/JsonArray.cpp b/extras/tests/JsonSerializer/JsonArray.cpp index e018de73..7cecbf4e 100644 --- a/extras/tests/JsonSerializer/JsonArray.cpp +++ b/extras/tests/JsonSerializer/JsonArray.cpp @@ -23,7 +23,7 @@ TEST_CASE("serializeJson(JsonArray)") { } SECTION("Null") { - array.add(static_cast(0)); + array.add(static_cast(0)); check(array, "[null]"); } diff --git a/extras/tests/JsonSerializer/JsonObject.cpp b/extras/tests/JsonSerializer/JsonObject.cpp index b457c665..20b90f52 100644 --- a/extras/tests/JsonSerializer/JsonObject.cpp +++ b/extras/tests/JsonSerializer/JsonObject.cpp @@ -6,7 +6,7 @@ #include #include -static void checkObject(const JsonObject obj, const std::string &expected) { +static void checkObject(const JsonObject obj, const std::string& expected) { char actual[256]; memset(actual, '!', sizeof(actual)); @@ -84,8 +84,8 @@ TEST_CASE("serializeJson(JsonObject)") { } SECTION("TwoNull") { - obj["a"] = static_cast(0); - obj["b"] = static_cast(0); + obj["a"] = static_cast(0); + obj["b"] = static_cast(0); checkObject(obj, "{\"a\":null,\"b\":null}"); } diff --git a/extras/tests/JsonSerializer/JsonVariant.cpp b/extras/tests/JsonSerializer/JsonVariant.cpp index 18d51f58..3525a1a4 100644 --- a/extras/tests/JsonSerializer/JsonVariant.cpp +++ b/extras/tests/JsonSerializer/JsonVariant.cpp @@ -7,7 +7,7 @@ #include template -void check(T value, const std::string &expected) { +void check(T value, const std::string& expected) { DynamicJsonDocument doc(4096); doc.to().set(value); char buffer[256] = ""; @@ -22,7 +22,7 @@ TEST_CASE("serializeJson(JsonVariant)") { } SECTION("Null string") { - check(static_cast(0), "null"); + check(static_cast(0), "null"); } SECTION("const char*") { diff --git a/extras/tests/JsonVariant/is.cpp b/extras/tests/JsonVariant/is.cpp index 6d04f0af..479e923a 100644 --- a/extras/tests/JsonVariant/is.cpp +++ b/extras/tests/JsonVariant/is.cpp @@ -19,7 +19,7 @@ TEST_CASE("JsonVariant::is()") { CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); - CHECK(variant.is() == false); + CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); @@ -34,7 +34,7 @@ TEST_CASE("JsonVariant::is()") { CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); - CHECK(variant.is() == false); + CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); @@ -50,7 +50,7 @@ TEST_CASE("JsonVariant::is()") { CHECK(variant.is() == true); CHECK(variant.is() == false); CHECK(variant.is() == false); - CHECK(variant.is() == false); + CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); @@ -66,7 +66,7 @@ TEST_CASE("JsonVariant::is()") { CHECK(variant.is() == true); CHECK(variant.is() == false); CHECK(variant.is() == false); - CHECK(variant.is() == false); + CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); @@ -88,7 +88,7 @@ TEST_CASE("JsonVariant::is()") { CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); - CHECK(variant.is() == false); + CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); } @@ -103,7 +103,7 @@ TEST_CASE("JsonVariant::is()") { CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); - CHECK(variant.is() == false); + CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); @@ -113,8 +113,8 @@ TEST_CASE("JsonVariant::is()") { SECTION("const char*") { variant.set("4.2"); - CHECK(variant.is() == true); - CHECK(variant.is() == true); + CHECK(variant.is() == true); + CHECK(variant.is() == true); CHECK(variant.is() == true); CHECK(variant.is() == true); CHECK(variant.is() == true); @@ -140,7 +140,7 @@ TEST_CASE("JsonVariant::is()") { CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); - CHECK(variant.is() == false); + CHECK(variant.is() == false); CHECK(variant.is() == false); } @@ -156,7 +156,7 @@ TEST_CASE("JsonVariant::is()") { CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == false); - CHECK(variant.is() == false); + CHECK(variant.is() == false); CHECK(variant.is() == false); CHECK(variant.is() == true); CHECK(variant.is() == true); @@ -178,7 +178,7 @@ TEST_CASE("JsonVariantConst::is()") { CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); - CHECK(cvariant.is() == false); + CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); @@ -192,7 +192,7 @@ TEST_CASE("JsonVariantConst::is()") { CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); - CHECK(cvariant.is() == false); + CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); @@ -208,7 +208,7 @@ TEST_CASE("JsonVariantConst::is()") { CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); - CHECK(cvariant.is() == false); + CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); @@ -224,7 +224,7 @@ TEST_CASE("JsonVariantConst::is()") { CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); - CHECK(cvariant.is() == false); + CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); @@ -246,7 +246,7 @@ TEST_CASE("JsonVariantConst::is()") { CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); - CHECK(cvariant.is() == false); + CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); } @@ -261,7 +261,7 @@ TEST_CASE("JsonVariantConst::is()") { CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); - CHECK(cvariant.is() == false); + CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); @@ -271,8 +271,8 @@ TEST_CASE("JsonVariantConst::is()") { SECTION("const char*") { variant.set("4.2"); - CHECK(cvariant.is() == true); - CHECK(cvariant.is() == true); + CHECK(cvariant.is() == true); + CHECK(cvariant.is() == true); CHECK(cvariant.is() == true); CHECK(cvariant.is() == true); CHECK(cvariant.is() == false); @@ -297,7 +297,7 @@ TEST_CASE("JsonVariantConst::is()") { CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); - CHECK(cvariant.is() == false); + CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); } @@ -313,7 +313,7 @@ TEST_CASE("JsonVariantConst::is()") { CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); - CHECK(cvariant.is() == false); + CHECK(cvariant.is() == false); CHECK(cvariant.is() == false); } } diff --git a/extras/tests/JsonVariant/set.cpp b/extras/tests/JsonVariant/set.cpp index 899ef6a5..9188c98a 100644 --- a/extras/tests/JsonVariant/set.cpp +++ b/extras/tests/JsonVariant/set.cpp @@ -15,7 +15,7 @@ TEST_CASE("JsonVariant::set() when there is enough memory") { char str[16]; strcpy(str, "hello"); - bool result = variant.set(static_cast(str)); + bool result = variant.set(static_cast(str)); strcpy(str, "world"); REQUIRE(result == true); @@ -23,7 +23,7 @@ TEST_CASE("JsonVariant::set() when there is enough memory") { } SECTION("(const char*)0") { - bool result = variant.set(static_cast(0)); + bool result = variant.set(static_cast(0)); REQUIRE(result == true); REQUIRE(variant.isNull()); @@ -41,7 +41,7 @@ TEST_CASE("JsonVariant::set() when there is enough memory") { } SECTION("(char*)0") { - bool result = variant.set(static_cast(0)); + bool result = variant.set(static_cast(0)); REQUIRE(result == true); REQUIRE(variant.isNull()); @@ -51,7 +51,7 @@ TEST_CASE("JsonVariant::set() when there is enough memory") { char str[16]; strcpy(str, "hello"); - bool result = variant.set(reinterpret_cast(str)); + bool result = variant.set(reinterpret_cast(str)); strcpy(str, "world"); REQUIRE(result == true); @@ -62,7 +62,7 @@ TEST_CASE("JsonVariant::set() when there is enough memory") { char str[16]; strcpy(str, "hello"); - bool result = variant.set(reinterpret_cast(str)); + bool result = variant.set(reinterpret_cast(str)); strcpy(str, "world"); REQUIRE(result == true); diff --git a/extras/tests/JsonVariant/types.cpp b/extras/tests/JsonVariant/types.cpp index 448d41ab..e3794990 100644 --- a/extras/tests/JsonVariant/types.cpp +++ b/extras/tests/JsonVariant/types.cpp @@ -17,9 +17,9 @@ void checkValue(T expected) { } template -void checkReference(T &expected) { +void checkReference(T& expected) { JsonVariant variant = expected; - REQUIRE(expected == variant.as()); + REQUIRE(expected == variant.as()); } template @@ -46,10 +46,10 @@ TEST_CASE("JsonVariant set()/get()") { #endif SECTION("Null") { - checkValue(NULL); + checkValue(NULL); } SECTION("const char*") { - checkValue("hello"); + checkValue("hello"); } SECTION("std::string") { checkValue("hello"); diff --git a/extras/tests/MemoryPool/clear.cpp b/extras/tests/MemoryPool/clear.cpp index f4ab796c..66e7775c 100644 --- a/extras/tests/MemoryPool/clear.cpp +++ b/extras/tests/MemoryPool/clear.cpp @@ -22,7 +22,7 @@ TEST_CASE("MemoryPool::clear()") { } SECTION("Discards allocated strings") { - pool.saveString(adaptString(const_cast("123456789"))); + pool.saveString(adaptString(const_cast("123456789"))); REQUIRE(pool.size() == 10); pool.clear(); diff --git a/extras/tests/MemoryPool/saveString.cpp b/extras/tests/MemoryPool/saveString.cpp index 0c16b677..7e0548cc 100644 --- a/extras/tests/MemoryPool/saveString.cpp +++ b/extras/tests/MemoryPool/saveString.cpp @@ -8,11 +8,11 @@ using namespace ARDUINOJSON_NAMESPACE; -static const char *saveString(MemoryPool &pool, const char *s) { - return pool.saveString(adaptString(const_cast(s))); +static const char* saveString(MemoryPool& pool, const char* s) { + return pool.saveString(adaptString(const_cast(s))); } -static const char *saveString(MemoryPool &pool, const char *s, size_t n) { +static const char* saveString(MemoryPool& pool, const char* s, size_t n) { return pool.saveString(adaptString(s, n)); } @@ -21,36 +21,36 @@ TEST_CASE("MemoryPool::saveString()") { MemoryPool pool(buffer, 32); SECTION("Duplicates different strings") { - const char *a = saveString(pool, "hello"); - const char *b = saveString(pool, "world"); + const char* a = saveString(pool, "hello"); + const char* b = saveString(pool, "world"); REQUIRE(a != b); REQUIRE(pool.size() == 6 + 6); } SECTION("Deduplicates identical strings") { - const char *a = saveString(pool, "hello"); - const char *b = saveString(pool, "hello"); + const char* a = saveString(pool, "hello"); + const char* b = saveString(pool, "hello"); REQUIRE(a == b); REQUIRE(pool.size() == 6); } SECTION("Deduplicates identical strings that contain NUL") { - const char *a = saveString(pool, "hello\0world", 11); - const char *b = saveString(pool, "hello\0world", 11); + const char* a = saveString(pool, "hello\0world", 11); + const char* b = saveString(pool, "hello\0world", 11); REQUIRE(a == b); REQUIRE(pool.size() == 12); } SECTION("Reuse part of a string if it ends with NUL") { - const char *a = saveString(pool, "hello\0world", 11); - const char *b = saveString(pool, "hello"); + const char* a = saveString(pool, "hello\0world", 11); + const char* b = saveString(pool, "hello"); REQUIRE(a == b); REQUIRE(pool.size() == 12); } SECTION("Don't stop on first NUL") { - const char *a = saveString(pool, "hello"); - const char *b = saveString(pool, "hello\0world", 11); + const char* a = saveString(pool, "hello"); + const char* b = saveString(pool, "hello\0world", 11); REQUIRE(a != b); REQUIRE(pool.size() == 18); } @@ -58,16 +58,16 @@ TEST_CASE("MemoryPool::saveString()") { SECTION("Returns NULL when full") { REQUIRE(pool.capacity() == 32); - const void *p1 = saveString(pool, "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"); + const void* p1 = saveString(pool, "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"); REQUIRE(p1 != 0); REQUIRE(pool.size() == 32); - const void *p2 = saveString(pool, "b"); + const void* p2 = saveString(pool, "b"); REQUIRE(p2 == 0); } SECTION("Returns NULL when pool is too small") { - const void *p = saveString(pool, "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"); + const void* p = saveString(pool, "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"); REQUIRE(0 == p); } @@ -82,15 +82,15 @@ TEST_CASE("MemoryPool::saveString()") { } SECTION("Returns same address after clear()") { - const void *a = saveString(pool, "hello"); + const void* a = saveString(pool, "hello"); pool.clear(); - const void *b = saveString(pool, "world"); + const void* b = saveString(pool, "world"); REQUIRE(a == b); } SECTION("Can use full capacity when fresh") { - const void *a = saveString(pool, "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"); + const void* a = saveString(pool, "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"); REQUIRE(a != 0); } @@ -99,7 +99,7 @@ TEST_CASE("MemoryPool::saveString()") { saveString(pool, "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"); pool.clear(); - const void *a = saveString(pool, "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"); + const void* a = saveString(pool, "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"); REQUIRE(a != 0); } diff --git a/extras/tests/MsgPackSerializer/destination_types.cpp b/extras/tests/MsgPackSerializer/destination_types.cpp index ae580636..6a5bc849 100644 --- a/extras/tests/MsgPackSerializer/destination_types.cpp +++ b/extras/tests/MsgPackSerializer/destination_types.cpp @@ -9,7 +9,7 @@ TEST_CASE("serialize MsgPack to various destination types") { DynamicJsonDocument doc(4096); JsonObject object = doc.to(); object["hello"] = "world"; - const char *expected_result = "\x81\xA5hello\xA5world"; + const char* expected_result = "\x81\xA5hello\xA5world"; const size_t expected_length = 13; SECTION("std::string") { diff --git a/extras/tests/MsgPackSerializer/misc.cpp b/extras/tests/MsgPackSerializer/misc.cpp index 52c53a7b..4753dbf4 100644 --- a/extras/tests/MsgPackSerializer/misc.cpp +++ b/extras/tests/MsgPackSerializer/misc.cpp @@ -3,7 +3,7 @@ #include template -void check(T value, const std::string &expected) { +void check(T value, const std::string& expected) { DynamicJsonDocument doc(4096); doc.to().set(value); char buffer[256] = ""; diff --git a/src/ArduinoJson/Array/ArrayFunctions.hpp b/src/ArduinoJson/Array/ArrayFunctions.hpp index 8248e565..81ffa50f 100644 --- a/src/ArduinoJson/Array/ArrayFunctions.hpp +++ b/src/ArduinoJson/Array/ArrayFunctions.hpp @@ -8,7 +8,7 @@ namespace ARDUINOJSON_NAMESPACE { -inline VariantData *arrayAdd(CollectionData *arr, MemoryPool *pool) { +inline VariantData* arrayAdd(CollectionData* arr, MemoryPool* pool) { return arr ? arr->addElement(pool) : 0; } diff --git a/src/ArduinoJson/Array/ArrayIterator.hpp b/src/ArduinoJson/Array/ArrayIterator.hpp index cde9a246..f74d7be2 100644 --- a/src/ArduinoJson/Array/ArrayIterator.hpp +++ b/src/ArduinoJson/Array/ArrayIterator.hpp @@ -11,13 +11,13 @@ namespace ARDUINOJSON_NAMESPACE { class VariantPtr { public: - VariantPtr(MemoryPool *pool, VariantData *data) : _variant(pool, data) {} + VariantPtr(MemoryPool* pool, VariantData* data) : _variant(pool, data) {} - VariantRef *operator->() { + VariantRef* operator->() { return &_variant; } - VariantRef &operator*() { + VariantRef& operator*() { return _variant; } @@ -28,7 +28,7 @@ class VariantPtr { class ArrayIterator { public: ArrayIterator() : _slot(0) {} - explicit ArrayIterator(MemoryPool *pool, VariantSlot *slot) + explicit ArrayIterator(MemoryPool* pool, VariantSlot* slot) : _pool(pool), _slot(slot) {} VariantRef operator*() const { @@ -38,42 +38,42 @@ class ArrayIterator { return VariantPtr(_pool, _slot->data()); } - bool operator==(const ArrayIterator &other) const { + bool operator==(const ArrayIterator& other) const { return _slot == other._slot; } - bool operator!=(const ArrayIterator &other) const { + bool operator!=(const ArrayIterator& other) const { return _slot != other._slot; } - ArrayIterator &operator++() { + ArrayIterator& operator++() { _slot = _slot->next(); return *this; } - ArrayIterator &operator+=(size_t distance) { + ArrayIterator& operator+=(size_t distance) { _slot = _slot->next(distance); return *this; } - VariantSlot *internal() { + VariantSlot* internal() { return _slot; } private: - MemoryPool *_pool; - VariantSlot *_slot; + MemoryPool* _pool; + VariantSlot* _slot; }; class VariantConstPtr { public: - VariantConstPtr(const VariantData *data) : _variant(data) {} + VariantConstPtr(const VariantData* data) : _variant(data) {} - VariantConstRef *operator->() { + VariantConstRef* operator->() { return &_variant; } - VariantConstRef &operator*() { + VariantConstRef& operator*() { return _variant; } @@ -84,7 +84,7 @@ class VariantConstPtr { class ArrayConstRefIterator { public: ArrayConstRefIterator() : _slot(0) {} - explicit ArrayConstRefIterator(const VariantSlot *slot) : _slot(slot) {} + explicit ArrayConstRefIterator(const VariantSlot* slot) : _slot(slot) {} VariantConstRef operator*() const { return VariantConstRef(_slot->data()); @@ -93,29 +93,29 @@ class ArrayConstRefIterator { return VariantConstPtr(_slot->data()); } - bool operator==(const ArrayConstRefIterator &other) const { + bool operator==(const ArrayConstRefIterator& other) const { return _slot == other._slot; } - bool operator!=(const ArrayConstRefIterator &other) const { + bool operator!=(const ArrayConstRefIterator& other) const { return _slot != other._slot; } - ArrayConstRefIterator &operator++() { + ArrayConstRefIterator& operator++() { _slot = _slot->next(); return *this; } - ArrayConstRefIterator &operator+=(size_t distance) { + ArrayConstRefIterator& operator+=(size_t distance) { _slot = _slot->next(distance); return *this; } - const VariantSlot *internal() { + const VariantSlot* internal() { return _slot; } private: - const VariantSlot *_slot; + const VariantSlot* _slot; }; } // namespace ARDUINOJSON_NAMESPACE diff --git a/src/ArduinoJson/Array/ArrayShortcuts.hpp b/src/ArduinoJson/Array/ArrayShortcuts.hpp index bc1898f4..77c8a2d9 100644 --- a/src/ArduinoJson/Array/ArrayShortcuts.hpp +++ b/src/ArduinoJson/Array/ArrayShortcuts.hpp @@ -30,20 +30,20 @@ class ArrayShortcuts { // TValue = bool, long, int, short, float, double, serialized, VariantRef, // std::string, String, ObjectRef template - FORCE_INLINE bool add(const T &value) const { + FORCE_INLINE bool add(const T& value) const { return impl()->add().set(value); } // // bool add(TValue); // TValue = char*, const char*, const __FlashStringHelper* template - FORCE_INLINE bool add(T *value) const { + FORCE_INLINE bool add(T* value) const { return impl()->add().set(value); } private: - const TArray *impl() const { - return static_cast(this); + const TArray* impl() const { + return static_cast(this); } }; } // namespace ARDUINOJSON_NAMESPACE diff --git a/src/ArduinoJson/Collection/CollectionData.hpp b/src/ArduinoJson/Collection/CollectionData.hpp index 1bb02eef..37bb055b 100644 --- a/src/ArduinoJson/Collection/CollectionData.hpp +++ b/src/ArduinoJson/Collection/CollectionData.hpp @@ -16,8 +16,8 @@ class VariantData; class VariantSlot; class CollectionData { - VariantSlot *_head; - VariantSlot *_tail; + VariantSlot* _head; + VariantSlot* _tail; public: // Must be a POD! @@ -28,24 +28,24 @@ class CollectionData { // Array only - VariantData *addElement(MemoryPool *pool); + VariantData* addElement(MemoryPool* pool); - VariantData *getElement(size_t index) const; + VariantData* getElement(size_t index) const; - VariantData *getOrAddElement(size_t index, MemoryPool *pool); + VariantData* getOrAddElement(size_t index, MemoryPool* pool); void removeElement(size_t index); // Object only template - VariantData *addMember(TAdaptedString key, MemoryPool *pool, TStoragePolicy); + VariantData* addMember(TAdaptedString key, MemoryPool* pool, TStoragePolicy); template - VariantData *getMember(TAdaptedString key) const; + VariantData* getMember(TAdaptedString key) const; template - VariantData *getOrAddMember(TAdaptedString key, MemoryPool *pool, + VariantData* getOrAddMember(TAdaptedString key, MemoryPool* pool, TStoragePolicy); template @@ -54,7 +54,7 @@ class CollectionData { } template - bool containsKey(const TAdaptedString &key) const; + bool containsKey(const TAdaptedString& key) const; // Generic @@ -62,34 +62,34 @@ class CollectionData { size_t memoryUsage() const; size_t size() const; - VariantSlot *addSlot(MemoryPool *); - void removeSlot(VariantSlot *slot); + VariantSlot* addSlot(MemoryPool*); + void removeSlot(VariantSlot* slot); - bool copyFrom(const CollectionData &src, MemoryPool *pool); + bool copyFrom(const CollectionData& src, MemoryPool* pool); - VariantSlot *head() const { + VariantSlot* head() const { return _head; } void movePointers(ptrdiff_t stringDistance, ptrdiff_t variantDistance); private: - VariantSlot *getSlot(size_t index) const; + VariantSlot* getSlot(size_t index) const; template - VariantSlot *getSlot(TAdaptedString key) const; + VariantSlot* getSlot(TAdaptedString key) const; - VariantSlot *getPreviousSlot(VariantSlot *) const; + VariantSlot* getPreviousSlot(VariantSlot*) const; }; -inline const VariantData *collectionToVariant( - const CollectionData *collection) { - const void *data = collection; // prevent warning cast-align - return reinterpret_cast(data); +inline const VariantData* collectionToVariant( + const CollectionData* collection) { + const void* data = collection; // prevent warning cast-align + return reinterpret_cast(data); } -inline VariantData *collectionToVariant(CollectionData *collection) { - void *data = collection; // prevent warning cast-align - return reinterpret_cast(data); +inline VariantData* collectionToVariant(CollectionData* collection) { + void* data = collection; // prevent warning cast-align + return reinterpret_cast(data); } } // namespace ARDUINOJSON_NAMESPACE diff --git a/src/ArduinoJson/Deserialization/deserialize.hpp b/src/ArduinoJson/Deserialization/deserialize.hpp index e4d27be3..062b1092 100644 --- a/src/ArduinoJson/Deserialization/deserialize.hpp +++ b/src/ArduinoJson/Deserialization/deserialize.hpp @@ -14,7 +14,7 @@ namespace ARDUINOJSON_NAMESPACE { template