diff --git a/extras/tests/Misc/TypeTraits.cpp b/extras/tests/Misc/TypeTraits.cpp index 8fc5199a..698ac857 100644 --- a/extras/tests/Misc/TypeTraits.cpp +++ b/extras/tests/Misc/TypeTraits.cpp @@ -186,7 +186,7 @@ TEST_CASE("Polyfills/type_traits") { CHECK((is_convertible::value == true)); CHECK((is_convertible, JsonVariantConst>::value == true)); - CHECK((is_convertible::value == true)); + CHECK((is_convertible::value == true)); CHECK((is_convertible::value == true)); CHECK((is_convertible, JsonVariantConst>::value == true)); diff --git a/src/ArduinoJson.hpp b/src/ArduinoJson.hpp index 406ddf80..dd5d1a31 100644 --- a/src/ArduinoJson.hpp +++ b/src/ArduinoJson.hpp @@ -47,8 +47,8 @@ #include "ArduinoJson/compatibility.hpp" namespace ArduinoJson { -typedef ARDUINOJSON_NAMESPACE::ArrayConstRef JsonArrayConst; using ARDUINOJSON_NAMESPACE::JsonArray; +using ARDUINOJSON_NAMESPACE::JsonArrayConst; typedef ARDUINOJSON_NAMESPACE::Float JsonFloat; typedef ARDUINOJSON_NAMESPACE::Integer JsonInteger; typedef ARDUINOJSON_NAMESPACE::ObjectConstRef JsonObjectConst; diff --git a/src/ArduinoJson/Array/ArrayIterator.hpp b/src/ArduinoJson/Array/ArrayIterator.hpp index 3e5326a1..27c84cd4 100644 --- a/src/ArduinoJson/Array/ArrayIterator.hpp +++ b/src/ArduinoJson/Array/ArrayIterator.hpp @@ -79,12 +79,12 @@ class VariantConstPtr { VariantConstRef _variant; }; -class ArrayConstRefIterator { +class JsonArrayConstIterator { friend class JsonArray; public: - ArrayConstRefIterator() : _slot(0) {} - explicit ArrayConstRefIterator(const VariantSlot* slot) : _slot(slot) {} + JsonArrayConstIterator() : _slot(0) {} + explicit JsonArrayConstIterator(const VariantSlot* slot) : _slot(slot) {} VariantConstRef operator*() const { return VariantConstRef(_slot->data()); @@ -93,20 +93,20 @@ class ArrayConstRefIterator { return VariantConstPtr(_slot->data()); } - bool operator==(const ArrayConstRefIterator& other) const { + bool operator==(const JsonArrayConstIterator& other) const { return _slot == other._slot; } - bool operator!=(const ArrayConstRefIterator& other) const { + bool operator!=(const JsonArrayConstIterator& other) const { return _slot != other._slot; } - ArrayConstRefIterator& operator++() { + JsonArrayConstIterator& operator++() { _slot = _slot->next(); return *this; } - ArrayConstRefIterator& operator+=(size_t distance) { + JsonArrayConstIterator& operator+=(size_t distance) { _slot = _slot->next(distance); return *this; } diff --git a/src/ArduinoJson/Array/JsonArray.hpp b/src/ArduinoJson/Array/JsonArray.hpp index dc940fa6..fecfaeb1 100644 --- a/src/ArduinoJson/Array/JsonArray.hpp +++ b/src/ArduinoJson/Array/JsonArray.hpp @@ -4,8 +4,8 @@ #pragma once -#include #include +#include namespace ARDUINOJSON_NAMESPACE { @@ -26,8 +26,8 @@ class JsonArray : public VariantOperators { return VariantRef(_pool, reinterpret_cast(data)); } - operator ArrayConstRef() const { - return ArrayConstRef(_data); + operator JsonArrayConst() const { + return JsonArrayConst(_data); } VariantRef add() const { @@ -57,14 +57,14 @@ class JsonArray : public VariantOperators { } // Copy a JsonArray - FORCE_INLINE bool set(ArrayConstRef src) const { + FORCE_INLINE bool set(JsonArrayConst src) const { if (!_data || !src._data) return false; return _data->copyFrom(*src._data, _pool); } FORCE_INLINE bool operator==(JsonArray rhs) const { - return ArrayConstRef(_data) == ArrayConstRef(rhs._data); + return JsonArrayConst(_data) == JsonArrayConst(rhs._data); } // Removes element at specified position. diff --git a/src/ArduinoJson/Array/ArrayConstRef.hpp b/src/ArduinoJson/Array/JsonArrayConst.hpp similarity index 84% rename from src/ArduinoJson/Array/ArrayConstRef.hpp rename to src/ArduinoJson/Array/JsonArrayConst.hpp index 74bcb7ee..98876984 100644 --- a/src/ArduinoJson/Array/ArrayConstRef.hpp +++ b/src/ArduinoJson/Array/JsonArrayConst.hpp @@ -12,12 +12,12 @@ namespace ARDUINOJSON_NAMESPACE { class ObjectRef; -class ArrayConstRef : public VariantOperators { +class JsonArrayConst : public VariantOperators { friend class JsonArray; friend class VariantAttorney; public: - typedef ArrayConstRefIterator iterator; + typedef JsonArrayConstIterator iterator; FORCE_INLINE iterator begin() const { if (!_data) @@ -29,10 +29,10 @@ class ArrayConstRef : public VariantOperators { return iterator(); } - FORCE_INLINE ArrayConstRef() : _data(0) {} - FORCE_INLINE ArrayConstRef(const CollectionData* data) : _data(data) {} + FORCE_INLINE JsonArrayConst() : _data(0) {} + FORCE_INLINE JsonArrayConst(const CollectionData* data) : _data(data) {} - FORCE_INLINE bool operator==(ArrayConstRef rhs) const { + FORCE_INLINE bool operator==(JsonArrayConst rhs) const { if (_data == rhs._data) return true; if (!_data || !rhs._data) @@ -92,12 +92,12 @@ class ArrayConstRef : public VariantOperators { }; template <> -struct Converter : private VariantAttorney { +struct Converter : private VariantAttorney { static void toJson(VariantConstRef src, VariantRef dst) { variantCopyFrom(getData(dst), getData(src), getPool(dst)); } - static ArrayConstRef fromJson(VariantConstRef src) { + static JsonArrayConst fromJson(VariantConstRef src) { const VariantData* data = getData(src); return data ? data->asArray() : 0; } diff --git a/src/ArduinoJson/Array/Utilities.hpp b/src/ArduinoJson/Array/Utilities.hpp index 9a2d1ea5..cfcebe49 100644 --- a/src/ArduinoJson/Array/Utilities.hpp +++ b/src/ArduinoJson/Array/Utilities.hpp @@ -64,15 +64,15 @@ inline typename enable_if::value, size_t>::type copyArray( // Copy a JsonArray to array template -inline size_t copyArray(ArrayConstRef src, T (&dst)[N]) { +inline size_t copyArray(JsonArrayConst src, T (&dst)[N]) { return copyArray(src, dst, N); } // Copy a JsonArray to ptr+size template -inline size_t copyArray(ArrayConstRef src, T* dst, size_t len) { +inline size_t copyArray(JsonArrayConst src, T* dst, size_t len) { size_t i = 0; - for (ArrayConstRef::iterator it = src.begin(); it != src.end() && i < len; + for (JsonArrayConst::iterator it = src.begin(); it != src.end() && i < len; ++it) copyArray(*it, dst[i++]); return i; @@ -97,7 +97,7 @@ inline typename enable_if::value && is_base_of::value, size_t>::type copyArray(const TSource& src, T& dst) { - return copyArray(src.template as(), dst); + return copyArray(src.template as(), dst); } } // namespace ARDUINOJSON_NAMESPACE diff --git a/src/ArduinoJson/Deserialization/Filter.hpp b/src/ArduinoJson/Deserialization/Filter.hpp index 8a091bb1..af539674 100644 --- a/src/ArduinoJson/Deserialization/Filter.hpp +++ b/src/ArduinoJson/Deserialization/Filter.hpp @@ -17,7 +17,7 @@ class Filter { } bool allowArray() const { - return _variant == true || _variant.is(); + return _variant == true || _variant.is(); } bool allowObject() const { diff --git a/src/ArduinoJson/Document/BasicJsonDocument.hpp b/src/ArduinoJson/Document/BasicJsonDocument.hpp index 687f6462..cc77152e 100644 --- a/src/ArduinoJson/Document/BasicJsonDocument.hpp +++ b/src/ArduinoJson/Document/BasicJsonDocument.hpp @@ -66,7 +66,7 @@ class BasicJsonDocument : AllocatorOwner, public JsonDocument { const T& src, typename enable_if< is_same::value || is_same::value || - is_same::value || is_same::value || + is_same::value || is_same::value || is_same::value || is_same::value>::type* = 0) : JsonDocument(allocPool(src.memoryUsage())) { diff --git a/src/ArduinoJson/Variant/Converter.hpp b/src/ArduinoJson/Variant/Converter.hpp index 72f9dfd4..63604dc9 100644 --- a/src/ArduinoJson/Variant/Converter.hpp +++ b/src/ArduinoJson/Variant/Converter.hpp @@ -4,6 +4,8 @@ #pragma once +#include + namespace ARDUINOJSON_NAMESPACE { template diff --git a/src/ArduinoJson/Variant/VariantCompare.hpp b/src/ArduinoJson/Variant/VariantCompare.hpp index 1197e083..2c5ef80b 100644 --- a/src/ArduinoJson/Variant/VariantCompare.hpp +++ b/src/ArduinoJson/Variant/VariantCompare.hpp @@ -88,7 +88,7 @@ struct ArrayComparer : ComparerBase { explicit ArrayComparer(const CollectionData& rhs) : _rhs(&rhs) {} CompareResult visitArray(const CollectionData& lhs) { - if (ArrayConstRef(&lhs) == ArrayConstRef(_rhs)) + if (JsonArrayConst(&lhs) == JsonArrayConst(_rhs)) return COMPARE_RESULT_EQUAL; else return COMPARE_RESULT_DIFFER; diff --git a/src/ArduinoJson/Variant/VariantConstRef.hpp b/src/ArduinoJson/Variant/VariantConstRef.hpp index 7ecf57af..625bba1b 100644 --- a/src/ArduinoJson/Variant/VariantConstRef.hpp +++ b/src/ArduinoJson/Variant/VariantConstRef.hpp @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include