From d8a1d1a120204403bc62e1b06d5d6b59974bf13b Mon Sep 17 00:00:00 2001
From: Benoit Blanchon <git@benoitblanchon.fr>
Date: Sun, 18 Apr 2021 17:23:51 +0200
Subject: [PATCH] Increased coverage of ConverterImpl.hpp

---
 extras/tests/JsonVariant/undefined.cpp    | 26 +++++++++++++++++++++++
 src/ArduinoJson/Variant/ConverterImpl.hpp |  1 -
 2 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/extras/tests/JsonVariant/undefined.cpp b/extras/tests/JsonVariant/undefined.cpp
index c0c5896d..8c5fdcc2 100644
--- a/extras/tests/JsonVariant/undefined.cpp
+++ b/extras/tests/JsonVariant/undefined.cpp
@@ -67,4 +67,30 @@ TEST_CASE("JsonVariant undefined") {
       REQUIRE(variant.is<JsonObject>() == false);
     }
   }
+
+  SECTION("set<T>()") {
+    SECTION("long") {
+      REQUIRE(variant.set(42L) == false);
+    }
+
+    SECTION("unsigned") {
+      REQUIRE(variant.set(42U) == false);
+    }
+
+    SECTION("const char*") {
+      REQUIRE(variant.set("42") == false);
+    }
+
+    SECTION("Serialized<const char*>") {
+      REQUIRE(variant.set(serialized("42")) == false);
+    }
+
+    SECTION("double") {
+      REQUIRE(variant.set(42.0) == false);
+    }
+
+    SECTION("bool") {
+      REQUIRE(variant.set(true) == false);
+    }
+  }
 }
diff --git a/src/ArduinoJson/Variant/ConverterImpl.hpp b/src/ArduinoJson/Variant/ConverterImpl.hpp
index 38636216..caf7eae0 100644
--- a/src/ArduinoJson/Variant/ConverterImpl.hpp
+++ b/src/ArduinoJson/Variant/ConverterImpl.hpp
@@ -121,7 +121,6 @@ struct Converter<T, typename enable_if<is_floating_point<T>::value>::type> {
 template <>
 struct Converter<const char*> {
   static bool toJson(VariantRef variant, const char* value) {
-    // TODO: don't pass pool
     return variantSetString(getData(variant), adaptString(value),
                             getPool(variant));
   }