boostorg/beast
1
0
Fork 1
mirror of https://github.com/boostorg/beast.git synced 2025-08-01 05:44:38 +02:00
Code Issues Packages Projects Releases Wiki Activity

bad_target replaces bad_path (API Change):

Browse Source 
Actions Required:

* Replace references to http::error::bad_path with http::error::bad_target
This commit is contained in:
Vinnie Falco
2017-06-25 17:18:02 -07:00
parent 8207a53113
commit 43f8bb841a
6 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@@ -8,12 +8,15 @@ API Changes:
* Change BodyReader, BodyWriter requirements * Change BodyReader, BodyWriter requirements
* Remove BodyReader::is_deferred * Remove BodyReader::is_deferred
* http::error::bad_target replaces bad_path
Actions Required: Actions Required:
* Change user defined instances of BodyReader and BodyWriter * Change user defined instances of BodyReader and BodyWriter
to meet the new requirements. to meet the new requirements.
* Replace references to http::error::bad_path with http::error::bad_target
-------------------------------------------------------------------------------- --------------------------------------------------------------------------------
Version 67: Version 67:

2
include/beast/http/error.hpp
View File

@@ -98,7 +98,7 @@ enum class error
bad_method, bad_method,
/// The request-target is invalid. /// The request-target is invalid.
bad_path, bad_target,
/// The HTTP-version is invalid. /// The HTTP-version is invalid.
bad_version, bad_version,

4
include/beast/http/impl/basic_parser.ipp
View File

@@ -318,12 +318,12 @@ parse_header(char const*& p, char const* term,
auto const target = parse_target(p); auto const target = parse_target(p);
if(target.empty()) if(target.empty())
{ {
ec = error::bad_path; ec = error::bad_target;
return; return;
} }
if(*p++ != ' ') if(*p++ != ' ')
{ {
ec = error::bad_path; ec = error::bad_target;
return; return;
} }

2
include/beast/http/impl/error.ipp
View File

@@ -47,7 +47,7 @@ public:
case error::bad_alloc: return "bad alloc"; case error::bad_alloc: return "bad alloc";
case error::bad_line_ending: return "bad line ending"; case error::bad_line_ending: return "bad line ending";
case error::bad_method: return "bad method"; case error::bad_method: return "bad method";
case error::bad_path: return "bad path"; case error::bad_target: return "bad target";
case error::bad_version: return "bad version"; case error::bad_version: return "bad version";
case error::bad_status: return "bad status"; case error::bad_status: return "bad status";
case error::bad_reason: return "bad reason"; case error::bad_reason: return "bad reason";

6
test/http/basic_parser.cpp
View File

@@ -360,9 +360,9 @@ public:
bad<true>("\tGET / HTTP/1.0\r\n" "\r\n", error::bad_method); bad<true>("\tGET / HTTP/1.0\r\n" "\r\n", error::bad_method);
bad<true>("GET\x01 / HTTP/1.0\r\n" "\r\n", error::bad_method); bad<true>("GET\x01 / HTTP/1.0\r\n" "\r\n", error::bad_method);
bad<true>("GET / HTTP/1.0\r\n" "\r\n", error::bad_path); bad<true>("GET / HTTP/1.0\r\n" "\r\n", error::bad_target);
bad<true>("GET \x01 HTTP/1.0\r\n" "\r\n", error::bad_path); bad<true>("GET \x01 HTTP/1.0\r\n" "\r\n", error::bad_target);
bad<true>("GET /\x01 HTTP/1.0\r\n" "\r\n", error::bad_path); bad<true>("GET /\x01 HTTP/1.0\r\n" "\r\n", error::bad_target);
// VFALCO TODO various forms of bad request-target (uri) // VFALCO TODO various forms of bad request-target (uri)
bad<true>("GET / HTTP/1.0\r\n" "\r\n", error::bad_version); bad<true>("GET / HTTP/1.0\r\n" "\r\n", error::bad_version);
bad<true>("GET / _TTP/1.0\r\n" "\r\n", error::bad_version); bad<true>("GET / _TTP/1.0\r\n" "\r\n", error::bad_version);

2
test/http/error.cpp
View File

@@ -46,7 +46,7 @@ public:
check("beast.http", error::bad_line_ending); check("beast.http", error::bad_line_ending);
check("beast.http", error::bad_method); check("beast.http", error::bad_method);
check("beast.http", error::bad_path); check("beast.http", error::bad_target);
check("beast.http", error::bad_version); check("beast.http", error::bad_version);
check("beast.http", error::bad_status); check("beast.http", error::bad_status);
check("beast.http", error::bad_reason); check("beast.http", error::bad_reason);