Tidying

include/boost/beast/http/detail/basic_parser.hpp

@@ -269,8 +269,8 @@ struct basic_parser_base
             if(BOOST_UNLIKELY(! is_print(*p)))
                 if((BOOST_LIKELY(static_cast<
                         unsigned char>(*p) < '\040') &&
-                    BOOST_LIKELY(*p != '\011')) ||
+                    BOOST_LIKELY(*p != 9)) ||
-                    BOOST_UNLIKELY(*p == '\177'))
+                    BOOST_UNLIKELY(*p == 127))
                     goto found_control;
         }
     found_control:

include/boost/beast/http/serializer.hpp

@@ -187,7 +187,7 @@ private:
     int s_ = do_construct;
     bool split_ = false;
     bool header_done_ = false;
-    bool more_;
+    bool more_ = false;
 
 public:
     /// Constructor

include/boost/beast/websocket/detail/impl/prng.ipp

@@ -122,7 +122,7 @@ make_prng_no_tls(bool secure)
         std::minstd_rand r_;
 
     public:
-        fast_prng* next;
+        fast_prng* next = nullptr;
 
         fast_prng()
             : r_([]
@@ -166,7 +166,7 @@ make_prng_no_tls(bool secure)
         beast::detail::chacha<20> r_;
 
     public:
-        secure_prng* next;
+        secure_prng* next = nullptr;
 
         secure_prng()
             : r_(prng_seed(), []

test/beast/core/basic_timeout_stream.cpp

@@ -107,7 +107,7 @@ public:
         std::thread t_;
 
         void
-        fail(error_code ec, string_view what)
+        fail(error_code const& ec, string_view what)
         {
             if(ec != net::error::operation_aborted)
                 log_ << what << ": " << ec.message() << "\n";
@@ -221,19 +221,19 @@ public:
 
         protected:
             void
-            on_read(error_code ec)
+            on_read(error_code const& ec)
             {
                 boost::ignore_unused(ec);
             }
 
             void
-            on_write(error_code, std::size_t)
+            on_write(error_code const& , std::size_t)
             {
             }
         };
 
         void
-        on_accept(error_code ec)
+        on_accept(error_code const& ec)
         {
             if(! acceptor_.is_open())
                 return;
@@ -410,7 +410,7 @@ public:
         }
 
         void
-        operator()(error_code ec, std::size_t n)
+        operator()(error_code const& ec, std::size_t n)
         {
             BEAST_EXPECTS(ec == ec_, ec.message());
             BEAST_EXPECT(n == n_);

test/beast/core/buffers_cat.cpp

@@ -33,7 +33,7 @@ public:
     testDefaultIterators()
     {
         // default ctor is one past the end
-        char c[2];
+        char c[2] = {};
         auto bs = buffers_cat(
             net::const_buffer(&c[0], 1),
             net::const_buffer(&c[1], 1));
@@ -58,7 +58,7 @@ public:
         try
         {
             it = {};
-            *it;
+            (void)*it;
             fail();
         }
         catch(std::logic_error const&)
@@ -114,7 +114,7 @@ public:
         checkException(
             []
             {
-                *(type::const_iterator{});
+                (void)*(type::const_iterator{});
             });
 
         // Incrementing a default-constructed iterator

test/beast/http/span_body.cpp

@@ -47,7 +47,7 @@ struct span_body_test
             BEAST_EXPECT(! buf->second);
         }
         {
-            char buf[5];
+            char buf[5] = {};
             using B = span_body<char>;
             request<B> req;
             req.body() = span<char>{buf, sizeof(buf)};