Ensure basic_stream::close will not throw

refs: #1875

CHANGELOG.md

@@ -4,6 +4,7 @@ Version XXX:
 * Refactor websocket read
 * Correct buffer_bytes documentation
 * Fix examples to dispatch to strand
+* Ensure basic_stream::close will not throw
 
 --------------------------------------------------------------------------------
 

include/boost/beast/core/basic_stream.hpp

@@ -292,7 +292,7 @@ private:
         void on_timer(Executor2 const& ex2);
 
         void reset();           // set timeouts to never
-        void close();       // cancel everything
+        void close() noexcept;  // cancel everything
     };
 
     // We use shared ownership for the state so it can

include/boost/beast/core/impl/basic_stream.hpp

@@ -143,21 +143,19 @@ template<class Protocol, class Executor, class RatePolicy>
 void
 basic_stream<Protocol, Executor, RatePolicy>::
 impl_type::
-close()
+close() noexcept
 {
     {
         error_code ec;
         socket.close(ec);
     }
+    try
+    {
         timer.cancel();
-
+    }
-
+    catch(...)
-    // have to let the read/write ops cancel the timer,
+    {
-    // otherwise we will get error::timeout on close when
+    }
-    // we actually want net::error::operation_aborted.
-    //
-    //read.timer.cancel();
-    //write.timer.cancel();
 }
 
 //------------------------------------------------------------------------------