boostorg/beast
1
0
Fork 1
mirror of https://github.com/boostorg/beast.git synced 2025-08-05 15:54:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

Reduce the number of instantiations of filter_token_list

Browse Source 
Not using lambdas in this case reduced the number of instantiations of
the algorithm by a factor of 4x at no (observable) runtime cost.

Signed-off-by: Damian Jarek <damian.jarek93@gmail.com>
This commit is contained in:
Damian Jarek
2019-06-03 01:09:06 +02:00
parent 6af4c01e56
commit 76842d637f
2 changed files with 21 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGELOG.md
View File

@@ -1,3 +1,9 @@
Version 259:
* Reduce the number of instantiations of filter_token_list
--------------------------------------------------------------------------------
Version 258: Version 258:
* Fix separate compilation in CI * Fix separate compilation in CI

37
include/boost/beast/http/impl/fields.hpp
View File

@@ -824,16 +824,23 @@ keep_alive_impl(
String& s, string_view value, String& s, string_view value,
unsigned version, bool keep_alive) unsigned version, bool keep_alive)
{ {
struct iequals_predicate
{
bool operator()(string_view s)
{
return beast::iequals(s, sv1) || beast::iequals(s, sv2);
}
string_view sv1;
string_view sv2;
};
if(version < 11) if(version < 11)
{ {
if(keep_alive) if(keep_alive)
{ {
// remove close // remove close
filter_token_list(s, value, filter_token_list(s, value, iequals_predicate{"close"});
[](string_view s)
{
return iequals(s, "close");
});
// add keep-alive // add keep-alive
if(s.empty()) if(s.empty())
s.append("keep-alive"); s.append("keep-alive");
@@ -844,12 +851,7 @@ keep_alive_impl(
{ {
// remove close and keep-alive // remove close and keep-alive
filter_token_list(s, value, filter_token_list(s, value,
[](string_view s) iequals_predicate{"close", "keep-alive"});
{
return
iequals(s, "close") ||
iequals(s, "keep-alive");
});
} }
} }
else else
@@ -858,21 +860,12 @@ keep_alive_impl(
{ {
// remove close and keep-alive // remove close and keep-alive
filter_token_list(s, value, filter_token_list(s, value,
[](string_view s) iequals_predicate{"close", "keep-alive"});
{
return
iequals(s, "close") ||
iequals(s, "keep-alive");
});
} }
else else
{ {
// remove keep-alive // remove keep-alive
filter_token_list(s, value, filter_token_list(s, value, iequals_predicate{"keep-alive"});
[](string_view s)
{
return iequals(s, "keep-alive");
});
// add close // add close
if(s.empty()) if(s.empty())
s.append("close"); s.append("close");