From dabb78afe74debb9018a00c036a8339fb62f3218 Mon Sep 17 00:00:00 2001 From: Vinnie Falco Date: Thu, 21 Dec 2017 13:10:17 -0800 Subject: [PATCH] Sanitizer failures are errors --- CHANGELOG.md | 6 ++++++ CMakeLists.txt | 4 ++-- Jamfile | 2 +- .../websocket/client/sync-ssl/websocket_client_sync_ssl.cpp | 2 +- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 975bbc87..508783b0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +Version 151: + +* Sanitizer failures are errors + +-------------------------------------------------------------------------------- + Version 150: * handler_ptr tests diff --git a/CMakeLists.txt b/CMakeLists.txt index d087f1d2..89bc0708 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -150,8 +150,8 @@ elseif ("${VARIANT}" STREQUAL "ubasan") else() set (CMAKE_BUILD_TYPE RELWITHDEBINFO) set (CMAKE_CXX_FLAGS - "${CMAKE_CXX_FLAGS} -DBOOST_BEAST_NO_SLOW_TESTS=1 -msse4.2 -funsigned-char -fno-omit-frame-pointer -fsanitize=address,undefined -fsanitize-blacklist=${PROJECT_SOURCE_DIR}/tools/blacklist.supp") - set (CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fsanitize=address,undefined") + "${CMAKE_CXX_FLAGS} -DBOOST_BEAST_NO_SLOW_TESTS=1 -msse4.2 -funsigned-char -fno-omit-frame-pointer -fsanitize=address,undefined -fno-sanitize-recover=address,undefined -fsanitize-blacklist=${PROJECT_SOURCE_DIR}/tools/blacklist.supp") + set (CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fsanitize=address,undefined -fno-sanitize-recover=address,undefined") endif() elseif ("${VARIANT}" STREQUAL "debug") diff --git a/Jamfile b/Jamfile index 9e08affe..af4af006 100644 --- a/Jamfile +++ b/Jamfile @@ -62,7 +62,7 @@ variant valgrind variant ubasan : release - : "-msse4.2 -funsigned-char -fno-omit-frame-pointer -fsanitize=address,undefined -fsanitize-blacklist=libs/beast/tools/blacklist.supp" + : "-msse4.2 -funsigned-char -fno-omit-frame-pointer -fsanitize=address,undefined -fno-sanitize-recover=address,undefined -fsanitize-blacklist=libs/beast/tools/blacklist.supp" "-fsanitize=address,undefined" BOOST_USE_ASAN=1 ; diff --git a/example/websocket/client/sync-ssl/websocket_client_sync_ssl.cpp b/example/websocket/client/sync-ssl/websocket_client_sync_ssl.cpp index 6281ec7c..d4bbe95d 100644 --- a/example/websocket/client/sync-ssl/websocket_client_sync_ssl.cpp +++ b/example/websocket/client/sync-ssl/websocket_client_sync_ssl.cpp @@ -26,7 +26,7 @@ #include using tcp = boost::asio::ip::tcp; // from -namespace ssl = boost::asio::ssl; // from +namespace ssl = boost::asio::ssl; // from namespace websocket = boost::beast::websocket; // from // Sends a WebSocket message and prints the response