boostorg/beast
1
0
Fork 1
mirror of https://github.com/boostorg/beast.git synced 2025-07-31 13:27:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix costly potential value-init in parser

Browse Source
This commit is contained in:
Vinnie Falco
2017-06-22 23:32:17 -07:00
parent f0e32882e2
commit f2e8af23f4
3 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -3,6 +3,8 @@ Version 66:
* string_param optimizations * string_param optimizations
* Add serializer request/response aliases * Add serializer request/response aliases
* Make consuming_buffers smaller * Make consuming_buffers smaller
* Fix costly potential value-init in parser
* Fix unused parameter warning
-------------------------------------------------------------------------------- --------------------------------------------------------------------------------

1
include/beast/core/detail/static_string.hpp
View File

@ -119,6 +119,7 @@ template<
CharT* CharT*
raw_to_string(CharT* last, std::size_t size, Integer i) raw_to_string(CharT* last, std::size_t size, Integer i)
{ {
boost::ignore_unused(size);
BOOST_ASSERT(size >= max_digits(sizeof(Integer))); BOOST_ASSERT(size >= max_digits(sizeof(Integer)));
return raw_to_string<CharT, Integer, Traits>( return raw_to_string<CharT, Integer, Traits>(
last, i, std::is_signed<Integer>{}); last, i, std::is_signed<Integer>{});

7
include/beast/http/parser.hpp
View File

@ -67,7 +67,12 @@ public:
message<isRequest, Body, basic_fields<Allocator>>; message<isRequest, Body, basic_fields<Allocator>>;
/// Constructor (default) /// Constructor (default)
parser() = default; parser()
{
// avoid `parser()=default` otherwise value-init
// for members can happen (i.e. a big memset on
// static_buffer_n).
}
/// Copy constructor (disallowed) /// Copy constructor (disallowed)
parser(parser const&) = delete; parser(parser const&) = delete;