Use BOOST_OVERRIDE to fix GCC -Wsuggest-override and Clang-tidy modernize-use-override warnings.

This commit is contained in:
Eugene Zelenko
2020-05-08 09:28:49 -07:00
parent f73fb1442a
commit 811dc94bb4
4 changed files with 21 additions and 21 deletions

View File

@@ -109,7 +109,7 @@ class BOOST_CONTAINER_DECL monotonic_buffer_resource
//! <b>Effects</b>: Calls //! <b>Effects</b>: Calls
//! `this->release()`. //! `this->release()`.
virtual ~monotonic_buffer_resource(); ~monotonic_buffer_resource() BOOST_OVERRIDE;
//! <b>Effects</b>: `upstream_resource()->deallocate()` as necessary to release all allocated memory. //! <b>Effects</b>: `upstream_resource()->deallocate()` as necessary to release all allocated memory.
//! [Note: memory is released back to `upstream_resource()` even if some blocks that were allocated //! [Note: memory is released back to `upstream_resource()` even if some blocks that were allocated
@@ -160,18 +160,18 @@ class BOOST_CONTAINER_DECL monotonic_buffer_resource
//! then allocate the return block from the newly-allocated internal `current_buffer`. //! then allocate the return block from the newly-allocated internal `current_buffer`.
//! //!
//! <b>Throws</b>: Nothing unless `upstream_resource()->allocate()` throws. //! <b>Throws</b>: Nothing unless `upstream_resource()->allocate()` throws.
virtual void* do_allocate(std::size_t bytes, std::size_t alignment); void* do_allocate(std::size_t bytes, std::size_t alignment) BOOST_OVERRIDE;
//! <b>Effects</b>: None //! <b>Effects</b>: None
//! //!
//! <b>Throws</b>: Nothing //! <b>Throws</b>: Nothing
//! //!
//! <b>Remarks</b>: Memory used by this resource increases monotonically until its destruction. //! <b>Remarks</b>: Memory used by this resource increases monotonically until its destruction.
virtual void do_deallocate(void* p, std::size_t bytes, std::size_t alignment) BOOST_NOEXCEPT; void do_deallocate(void* p, std::size_t bytes, std::size_t alignment) BOOST_NOEXCEPT BOOST_OVERRIDE;
//! <b>Returns</b>: //! <b>Returns</b>:
//! `this == dynamic_cast<const monotonic_buffer_resource*>(&other)`. //! `this == dynamic_cast<const monotonic_buffer_resource*>(&other)`.
virtual bool do_is_equal(const memory_resource& other) const BOOST_NOEXCEPT; bool do_is_equal(const memory_resource& other) const BOOST_NOEXCEPT BOOST_OVERRIDE;
}; };
} //namespace pmr { } //namespace pmr {

View File

@@ -89,7 +89,7 @@ class BOOST_CONTAINER_DECL synchronized_pool_resource
#endif #endif
//! @copydoc ::boost::container::pmr::unsynchronized_pool_resource::~unsynchronized_pool_resource() //! @copydoc ::boost::container::pmr::unsynchronized_pool_resource::~unsynchronized_pool_resource()
virtual ~synchronized_pool_resource(); ~synchronized_pool_resource() BOOST_OVERRIDE;
//! @copydoc ::boost::container::pmr::unsynchronized_pool_resource::release() //! @copydoc ::boost::container::pmr::unsynchronized_pool_resource::release()
void release(); void release();
@@ -103,13 +103,13 @@ class BOOST_CONTAINER_DECL synchronized_pool_resource
protected: protected:
//! @copydoc ::boost::container::pmr::unsynchronized_pool_resource::do_allocate() //! @copydoc ::boost::container::pmr::unsynchronized_pool_resource::do_allocate()
virtual void* do_allocate(std::size_t bytes, std::size_t alignment); void* do_allocate(std::size_t bytes, std::size_t alignment) BOOST_OVERRIDE;
//! @copydoc ::boost::container::pmr::unsynchronized_pool_resource::do_deallocate(void*,std::size_t,std::size_t) //! @copydoc ::boost::container::pmr::unsynchronized_pool_resource::do_deallocate(void*,std::size_t,std::size_t)
virtual void do_deallocate(void* p, std::size_t bytes, std::size_t alignment); void do_deallocate(void* p, std::size_t bytes, std::size_t alignment) BOOST_OVERRIDE;
//! @copydoc ::boost::container::pmr::unsynchronized_pool_resource::do_is_equal(const memory_resource&)const //! @copydoc ::boost::container::pmr::unsynchronized_pool_resource::do_is_equal(const memory_resource&)const
virtual bool do_is_equal(const memory_resource& other) const BOOST_NOEXCEPT; bool do_is_equal(const memory_resource& other) const BOOST_NOEXCEPT BOOST_OVERRIDE;
//Non-standard observers //Non-standard observers
public: public:

View File

@@ -103,7 +103,7 @@ class BOOST_CONTAINER_DECL unsynchronized_pool_resource
//! <b>Effects</b>: Calls //! <b>Effects</b>: Calls
//! `this->release()`. //! `this->release()`.
virtual ~unsynchronized_pool_resource(); ~unsynchronized_pool_resource() BOOST_OVERRIDE;
//! <b>Effects</b>: Calls Calls `upstream_resource()->deallocate()` as necessary //! <b>Effects</b>: Calls Calls `upstream_resource()->deallocate()` as necessary
//! to release all allocated memory. [ Note: memory is released back to //! to release all allocated memory. [ Note: memory is released back to
@@ -134,18 +134,18 @@ class BOOST_CONTAINER_DECL unsynchronized_pool_resource
//! using `upstream_resource()->allocate()`. //! using `upstream_resource()->allocate()`.
//! //!
//! <b>Throws</b>: Nothing unless `upstream_resource()->allocate()` throws. //! <b>Throws</b>: Nothing unless `upstream_resource()->allocate()` throws.
virtual void* do_allocate(std::size_t bytes, std::size_t alignment); void* do_allocate(std::size_t bytes, std::size_t alignment) BOOST_OVERRIDE;
//! <b>Effects</b>: Return the memory at p to the pool. It is unspecified if or under //! <b>Effects</b>: Return the memory at p to the pool. It is unspecified if or under
//! what circumstances this operation will result in a call to //! what circumstances this operation will result in a call to
//! `upstream_resource()->deallocate()`. //! `upstream_resource()->deallocate()`.
//! //!
//! <b>Throws</b>: Nothing. //! <b>Throws</b>: Nothing.
virtual void do_deallocate(void* p, std::size_t bytes, std::size_t alignment); void do_deallocate(void* p, std::size_t bytes, std::size_t alignment) BOOST_OVERRIDE;
//! <b>Returns</b>: //! <b>Returns</b>:
//! `this == dynamic_cast<const unsynchronized_pool_resource*>(&other)`. //! `this == dynamic_cast<const unsynchronized_pool_resource*>(&other)`.
virtual bool do_is_equal(const memory_resource& other) const BOOST_NOEXCEPT; bool do_is_equal(const memory_resource& other) const BOOST_NOEXCEPT BOOST_OVERRIDE;
//Non-standard observers //Non-standard observers
public: public:

View File

@@ -27,16 +27,16 @@ class new_delete_resource_imp
{ {
public: public:
virtual ~new_delete_resource_imp() ~new_delete_resource_imp() BOOST_OVERRIDE
{} {}
virtual void* do_allocate(std::size_t bytes, std::size_t alignment) void* do_allocate(std::size_t bytes, std::size_t alignment) BOOST_OVERRIDE
{ (void)bytes; (void)alignment; return new char[bytes]; } { (void)bytes; (void)alignment; return new char[bytes]; }
virtual void do_deallocate(void* p, std::size_t bytes, std::size_t alignment) void do_deallocate(void* p, std::size_t bytes, std::size_t alignment) BOOST_OVERRIDE
{ (void)bytes; (void)alignment; delete[]((char*)p); } { (void)bytes; (void)alignment; delete[]((char*)p); }
virtual bool do_is_equal(const memory_resource& other) const BOOST_NOEXCEPT bool do_is_equal(const memory_resource& other) const BOOST_NOEXCEPT BOOST_OVERRIDE
{ return &other == this; } { return &other == this; }
} new_delete_resource_instance; } new_delete_resource_instance;
@@ -45,20 +45,20 @@ struct null_memory_resource_imp
{ {
public: public:
virtual ~null_memory_resource_imp() ~null_memory_resource_imp() BOOST_OVERRIDE
{} {}
virtual void* do_allocate(std::size_t bytes, std::size_t alignment) void* do_allocate(std::size_t bytes, std::size_t alignment) BOOST_OVERRIDE
{ {
(void)bytes; (void)alignment; (void)bytes; (void)alignment;
throw_bad_alloc(); throw_bad_alloc();
return 0; return 0;
} }
virtual void do_deallocate(void* p, std::size_t bytes, std::size_t alignment) void do_deallocate(void* p, std::size_t bytes, std::size_t alignment) BOOST_OVERRIDE
{ (void)p; (void)bytes; (void)alignment; } { (void)p; (void)bytes; (void)alignment; }
virtual bool do_is_equal(const memory_resource& other) const BOOST_NOEXCEPT bool do_is_equal(const memory_resource& other) const BOOST_NOEXCEPT BOOST_OVERRIDE
{ return &other == this; } { return &other == this; }
} null_memory_resource_instance; } null_memory_resource_instance;