boostorg/detail
1
0
Fork 1
mirror of https://github.com/boostorg/detail.git synced 2025-07-31 12:57:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixed inconsistent linkage specification on MSVC. Code cleanup.

Browse Source 
cc32906071 introduced inconsistent
BOOST_UTF8_DECL markup between function declarations and definitions,
which caused MSVC build errors. This commit fixes this.

Also, replaced unneeded BOOST_UTF8_DECL markup with inline for functions
that are only used internally. Made get_cont_octet_out_count static.

Additionally, removed duplicate octet1_modifier_table definitions
and moved it to a function-local static.

Whitespace and formatting cleanup.

Closes https://github.com/boostorg/filesystem/issues/204.
This commit is contained in:
Andrey Semashev
2021-08-18 00:39:45 +03:00
parent db4c8248c0
commit 87489a4346
2 changed files with 108 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
include/boost/detail/utf8_codecvt_facet.hpp
View File

@ -113,24 +113,25 @@ struct BOOST_SYMBOL_VISIBLE utf8_codecvt_facet :
public std::codecvt<wchar_t, char, std::mbstate_t> public std::codecvt<wchar_t, char, std::mbstate_t>
{ {
public: public:
explicit utf8_codecvt_facet(std::size_t no_locale_manage=0); BOOST_UTF8_DECL explicit utf8_codecvt_facet(std::size_t no_locale_manage = 0);
virtual ~utf8_codecvt_facet(); BOOST_UTF8_DECL virtual ~utf8_codecvt_facet();
protected: protected:
virtual std::codecvt_base::result do_in( BOOST_UTF8_DECL virtual std::codecvt_base::result do_in(
std::mbstate_t& state, std::mbstate_t& state,
const char * from, const char * from,
const char * from_end, const char * from_end,
const char * & from_next, const char * & from_next,
wchar_t * to, wchar_t * to,
wchar_t * to_end, wchar_t * to_end,
wchar_t*& to_next wchar_t * & to_next
) const; ) const;
virtual std::codecvt_base::result do_out( BOOST_UTF8_DECL virtual std::codecvt_base::result do_out(
std::mbstate_t & state, std::mbstate_t & state,
const wchar_t * from, const wchar_t * from,
const wchar_t * from_end, const wchar_t * from_end,
const wchar_t* & from_next, const wchar_t * & from_next,
char * to, char * to,
char * to_end, char * to_end,
char * & to_next char * & to_next
@ -140,7 +141,7 @@ protected:
return (octet_1 < 0x80|| 0xbf< octet_1); return (octet_1 < 0x80|| 0xbf< octet_1);
} }
bool invalid_leading_octet(unsigned char octet_1) const { bool invalid_leading_octet(unsigned char octet_1) const {
return (0x7f < octet_1 && octet_1 < 0xc0) || return (0x7f < octet_1 && octet_1 < 0xc0) ||
(octet_1 > 0xfd); (octet_1 > 0xfd);
} }
@ -150,11 +151,11 @@ protected:
return get_octet_count(lead_octet) - 1; return get_octet_count(lead_octet) - 1;
} }
static unsigned int get_octet_count(unsigned char lead_octet); BOOST_UTF8_DECL static unsigned int get_octet_count(unsigned char lead_octet);
// How many "continuing octets" will be needed for this word // How many "continuing octets" will be needed for this word
// == total octets - 1. // == total octets - 1.
int get_cont_octet_out_count(wchar_t word) const ; BOOST_UTF8_DECL static int get_cont_octet_out_count(wchar_t word);
virtual bool do_always_noconv() const BOOST_NOEXCEPT_OR_NOTHROW { virtual bool do_always_noconv() const BOOST_NOEXCEPT_OR_NOTHROW {
return false; return false;
@ -162,7 +163,7 @@ protected:
// UTF-8 isn't really stateful since we rewind on partial conversions // UTF-8 isn't really stateful since we rewind on partial conversions
virtual std::codecvt_base::result do_unshift( virtual std::codecvt_base::result do_unshift(
std::mbstate_t&, std::mbstate_t &,
char * from, char * from,
char * /*to*/, char * /*to*/,
char * & next char * & next
@ -178,7 +179,7 @@ protected:
// How many char objects can I process to get <= max_limit // How many char objects can I process to get <= max_limit
// wchar_t objects? // wchar_t objects?
virtual int do_length( BOOST_UTF8_DECL virtual int do_length(
std::mbstate_t &, std::mbstate_t &,
const char * from, const char * from,
const char * from_end, const char * from_end,

117
include/boost/detail/utf8_codecvt_facet.ipp
View File

@ -30,6 +30,19 @@ BOOST_UTF8_BEGIN_NAMESPACE
/////////1/////////2/////////3/////////4/////////5/////////6/////////7/////////8 /////////1/////////2/////////3/////////4/////////5/////////6/////////7/////////8
// implementation for wchar_t // implementation for wchar_t
namespace detail {
inline const wchar_t * get_octet1_modifier_table() BOOST_NOEXCEPT
{
static const wchar_t octet1_modifier_table[] = {
0x00, 0xc0, 0xe0, 0xf0, 0xf8, 0xfc
};
return octet1_modifier_table;
}
} // namespace detail
BOOST_UTF8_DECL utf8_codecvt_facet::utf8_codecvt_facet( BOOST_UTF8_DECL utf8_codecvt_facet::utf8_codecvt_facet(
std::size_t no_locale_manage std::size_t no_locale_manage
) : ) :
@ -49,46 +62,44 @@ BOOST_UTF8_DECL std::codecvt_base::result utf8_codecvt_facet::do_in(
wchar_t * to_end, wchar_t * to_end,
wchar_t * & to_next wchar_t * & to_next
) const { ) const {
// Basic algorithm: The first octet determines how many // Basic algorithm: The first octet determines how many
// octets total make up the UCS-4 character. The remaining // octets total make up the UCS-4 character. The remaining
// "continuing octets" all begin with "10". To convert, subtract // "continuing octets" all begin with "10". To convert, subtract
// the amount that specifies the number of octets from the first // the amount that specifies the number of octets from the first
// octet. Subtract 0x80 (1000 0000) from each continuing octet, // octet. Subtract 0x80 (1000 0000) from each continuing octet,
// then mash the whole lot together. Note that each continuing // then mash the whole lot together. Note that each continuing
// octet only uses 6 bits as unique values, so only shift by // octet only uses 6 bits as unique values, so only shift by
// multiples of 6 to combine. // multiples of 6 to combine.
const wchar_t * const octet1_modifier_table = detail::get_octet1_modifier_table();
while (from != from_end && to != to_end) { while (from != from_end && to != to_end) {
// Error checking on the first octet // Error checking on the first octet
if (invalid_leading_octet(*from)){ if (invalid_leading_octet(*from)) {
from_next = from; from_next = from;
to_next = to; to_next = to;
return std::codecvt_base::error; return std::codecvt_base::error;
} }
// The first octet is adjusted by a value dependent upon // The first octet is adjusted by a value dependent upon
// the number of "continuing octets" encoding the character // the number of "continuing octets" encoding the character
const int cont_octet_count = get_cont_octet_count(*from); const int cont_octet_count = get_cont_octet_count(*from);
const wchar_t octet1_modifier_table[] = {
0x00, 0xc0, 0xe0, 0xf0, 0xf8, 0xfc
};
// The unsigned char conversion is necessary in case char is // The unsigned char conversion is necessary in case char is
// signed (I learned this the hard way) // signed (I learned this the hard way)
wchar_t ucs_result = wchar_t ucs_result =
(unsigned char)(*from++) - octet1_modifier_table[cont_octet_count]; (unsigned char)(*from++) - octet1_modifier_table[cont_octet_count];
// Invariants : // Invariants:
// 1) At the start of the loop, 'i' continuing characters have been // 1) At the start of the loop, 'i' continuing characters have been
// processed // processed
// 2) *from points to the next continuing character to be processed. // 2) *from points to the next continuing character to be processed.
int i = 0; int i = 0;
while(i != cont_octet_count && from != from_end) { while (i != cont_octet_count && from != from_end) {
// Error checking on continuing characters // Error checking on continuing characters
if (invalid_continuing_octet(*from)) { if (invalid_continuing_octet(*from)) {
from_next = from; from_next = from;
to_next = to; to_next = to;
return std::codecvt_base::error; return std::codecvt_base::error;
} }
@ -100,26 +111,28 @@ BOOST_UTF8_DECL std::codecvt_base::result utf8_codecvt_facet::do_in(
++i; ++i;
} }
// If the buffer ends with an incomplete unicode character... // If the buffer ends with an incomplete unicode character...
if (from == from_end && i != cont_octet_count) { if (from == from_end && i != cont_octet_count) {
// rewind "from" to before the current character translation // rewind "from" to before the current character translation
from_next = from - (i+1); from_next = from - (i + 1);
to_next = to; to_next = to;
return std::codecvt_base::partial; return std::codecvt_base::partial;
} }
*to++ = ucs_result; *to++ = ucs_result;
} }
from_next = from; from_next = from;
to_next = to; to_next = to;
// Were we done converting or did we run out of destination space? // Were we done converting or did we run out of destination space?
if(from == from_end) return std::codecvt_base::ok; if (from == from_end)
else return std::codecvt_base::partial; return std::codecvt_base::ok;
else
return std::codecvt_base::partial;
} }
BOOST_UTF8_DECL std::codecvt_base::result utf8_codecvt_facet::do_out( BOOST_UTF8_DECL std::codecvt_base::result utf8_codecvt_facet::do_out(
std::mbstate_t& /*state*/, std::mbstate_t& /*state*/,
const wchar_t * from, const wchar_t * from,
const wchar_t * from_end, const wchar_t * from_end,
const wchar_t * & from_next, const wchar_t * & from_next,
char * to, char * to,
@ -127,11 +140,7 @@ BOOST_UTF8_DECL std::codecvt_base::result utf8_codecvt_facet::do_out(
char * & to_next char * & to_next
) const ) const
{ {
// RG - consider merging this table with the other one const wchar_t * const octet1_modifier_table = detail::get_octet1_modifier_table();
const wchar_t octet1_modifier_table[] = {
0x00, 0xc0, 0xe0, 0xf0, 0xf8, 0xfc
};
wchar_t max_wchar = (std::numeric_limits<wchar_t>::max)(); wchar_t max_wchar = (std::numeric_limits<wchar_t>::max)();
while (from != from_end && to != to_end) { while (from != from_end && to != to_end) {
@ -144,37 +153,40 @@ BOOST_UTF8_DECL std::codecvt_base::result utf8_codecvt_facet::do_out(
int cont_octet_count = get_cont_octet_out_count(*from); int cont_octet_count = get_cont_octet_out_count(*from);
// RG - comment this formula better // RG - comment this formula better
int shift_exponent = (cont_octet_count) * 6; int shift_exponent = cont_octet_count * 6;
// Process the first character // Process the first character
*to++ = static_cast<char>(octet1_modifier_table[cont_octet_count] + *to++ = static_cast<char>(octet1_modifier_table[cont_octet_count] +
(unsigned char)(*from / (1 << shift_exponent))); (unsigned char)(*from / (1 << shift_exponent)));
// Process the continuation characters // Process the continuation characters
// Invariants: At the start of the loop: // Invariants: At the start of the loop:
// 1) 'i' continuing octets have been generated // 1) 'i' continuing octets have been generated
// 2) '*to' points to the next location to place an octet // 2) '*to' points to the next location to place an octet
// 3) shift_exponent is 6 more than needed for the next octet // 3) shift_exponent is 6 more than needed for the next octet
int i = 0; int i = 0;
while (i != cont_octet_count && to != to_end) { while (i != cont_octet_count && to != to_end) {
shift_exponent -= 6; shift_exponent -= 6;
*to++ = static_cast<char>(0x80 + ((*from / (1 << shift_exponent)) % (1 << 6))); *to++ = static_cast<char>(0x80 + ((*from / (1 << shift_exponent)) % (1 << 6)));
++i; ++i;
} }
// If we filled up the out buffer before encoding the character // If we filled up the out buffer before encoding the character
if(to == to_end && i != cont_octet_count) { if (to == to_end && i != cont_octet_count) {
from_next = from; from_next = from;
to_next = to - (i+1); to_next = to - (i + 1);
return std::codecvt_base::partial; return std::codecvt_base::partial;
} }
++from; ++from;
} }
from_next = from; from_next = from;
to_next = to; to_next = to;
// Were we done or did we run out of destination space // Were we done or did we run out of destination space
if(from == from_end) return std::codecvt_base::ok; if (from == from_end)
else return std::codecvt_base::partial; return std::codecvt_base::ok;
else
return std::codecvt_base::partial;
} }
// How many char objects can I process to get <= max_limit // How many char objects can I process to get <= max_limit
@ -203,7 +215,7 @@ BOOST_UTF8_DECL int utf8_codecvt_facet::do_length(
BOOST_UTF8_DECL unsigned int utf8_codecvt_facet::get_octet_count( BOOST_UTF8_DECL unsigned int utf8_codecvt_facet::get_octet_count(
unsigned char lead_octet unsigned char lead_octet
){ ) {
// if the 0-bit (MSB) is 0, then 1 character // if the 0-bit (MSB) is 0, then 1 character
if (lead_octet <= 0x7f) return 1; if (lead_octet <= 0x7f) return 1;
@ -220,7 +232,7 @@ BOOST_UTF8_DECL unsigned int utf8_codecvt_facet::get_octet_count(
namespace detail { namespace detail {
template<std::size_t s> template<std::size_t s>
BOOST_UTF8_DECL int get_cont_octet_out_count_impl(wchar_t word){ inline int get_cont_octet_out_count_impl(wchar_t word) {
if (word < 0x80) { if (word < 0x80) {
return 0; return 0;
} }
@ -231,7 +243,7 @@ BOOST_UTF8_DECL int get_cont_octet_out_count_impl(wchar_t word){
} }
template<> template<>
BOOST_UTF8_DECL int get_cont_octet_out_count_impl<4>(wchar_t word){ inline int get_cont_octet_out_count_impl<4>(wchar_t word) {
if (word < 0x80) { if (word < 0x80) {
return 0; return 0;
} }
@ -243,7 +255,7 @@ BOOST_UTF8_DECL int get_cont_octet_out_count_impl<4>(wchar_t word){
// where wchar_t is defined as UCS2. The warnings are superfluous as the // where wchar_t is defined as UCS2. The warnings are superfluous as the
// specialization is never instantitiated with such compilers, but this // specialization is never instantitiated with such compilers, but this
// can cause problems if warnings are being treated as errors, so we guard // can cause problems if warnings are being treated as errors, so we guard
// against that. Including <boost/detail/utf8_codecvt_facet.hpp> as we do // against that. Including <boost/detail/utf8_codecvt_facet.hpp> as we do
// should be enough to get WCHAR_MAX defined. // should be enough to get WCHAR_MAX defined.
#if !defined(WCHAR_MAX) #if !defined(WCHAR_MAX)
# error WCHAR_MAX not defined! # error WCHAR_MAX not defined!
@ -253,7 +265,7 @@ BOOST_UTF8_DECL int get_cont_octet_out_count_impl<4>(wchar_t word){
return 2; return 2;
#elif WCHAR_MAX > 0x10000 #elif WCHAR_MAX > 0x10000
if (word < 0x10000) { if (word < 0x10000) {
return 2; return 2;
} }
if (word < 0x200000) { if (word < 0x200000) {
@ -275,9 +287,10 @@ BOOST_UTF8_DECL int get_cont_octet_out_count_impl<4>(wchar_t word){
// == total octets - 1. // == total octets - 1.
BOOST_UTF8_DECL int utf8_codecvt_facet::get_cont_octet_out_count( BOOST_UTF8_DECL int utf8_codecvt_facet::get_cont_octet_out_count(
wchar_t word wchar_t word
) const { ) {
return detail::get_cont_octet_out_count_impl<sizeof(wchar_t)>(word); return detail::get_cont_octet_out_count_impl<sizeof(wchar_t)>(word);
} }
BOOST_UTF8_END_NAMESPACE BOOST_UTF8_END_NAMESPACE
#endif #endif