From db16b51b41af2b3cafc51491f8998fbe4fcec52c Mon Sep 17 00:00:00 2001 From: Beman Date: Fri, 5 Dec 2014 09:05:05 -0500 Subject: [PATCH] Tweak comments. --- example/endian_example.cpp | 4 ++-- include/boost/endian/buffers.hpp | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/example/endian_example.cpp b/example/endian_example.cpp index 9373bbf..7a3435d 100644 --- a/example/endian_example.cpp +++ b/example/endian_example.cpp @@ -23,8 +23,8 @@ using namespace boost::endian; namespace { - // This is an extract from a very widely used GIS file format. Who knows - // why a designer would mix big and little endians in the same file? But + // This is an extract from a very widely used GIS file format. Why the designer + // decided to mix big and little endians in the same file is not known. But // this is a real-world format and users wishing to write low level code // manipulating these files have to deal with the mixed endianness. diff --git a/include/boost/endian/buffers.hpp b/include/boost/endian/buffers.hpp index c89e307..67c9efc 100644 --- a/include/boost/endian/buffers.hpp +++ b/include/boost/endian/buffers.hpp @@ -324,6 +324,11 @@ namespace endian // the size and signedness of the desired integer and get the appropriate // corresponding integer type for the interface. + // Q: Should endian_buffer supply "value_type operator value_type() const noexcept"? + // A: No. The rationale for endian_buffers is to prevent high-cost hidden + // conversions. If an implicit conversion operator is supplied, hidden conversions + // can occur. + // unaligned big endian_buffer specialization template class endian_buffer< order::big, T, n_bits, align::no >