mirror of
https://github.com/boostorg/functional.git
synced 2025-08-02 14:04:27 +02:00
Merge hash, opt-in to breaking change rather than opt-out.
[SVN r64031]
This commit is contained in:
@@ -108,10 +108,15 @@
|
||||
|
||||
[h2 Boost 1.44.0]
|
||||
|
||||
* Prevent implicit conversions when calling `hash_value`. If you find
|
||||
that the new version breaks your code, you can enable the old
|
||||
behaviour by defining `BOOST_HASH_ALLOW_IMPLICIT_CASTS` - although
|
||||
I would recommend that you update your code to work with the new
|
||||
version.
|
||||
* Add option to prevent implicit conversions when calling `hash_value` by
|
||||
defining `BOOST_HASH_NO_IMPLICIT_CASTS`. When using `boost::hash`
|
||||
for a type that does not have `hash_value` declared but does have
|
||||
an implicit conversion to a type that does, it would use that
|
||||
implicit conversion to hash it. Which can sometimes go very wrong,
|
||||
e.g. using a conversion to bool and only hashing to 2 possible
|
||||
values. Since fixing this is a breaking change and was only
|
||||
approached quite late in the release cycle with little discussion
|
||||
it's opt-in for now. This, or something like it, will become the
|
||||
default in a future version.
|
||||
|
||||
[endsect]
|
||||
|
@@ -7,6 +7,7 @@ import testing ;
|
||||
|
||||
project hash-tests
|
||||
: requirements
|
||||
<define>BOOST_HASH_NO_IMPLICIT_CASTS
|
||||
<warnings>all
|
||||
<toolset>intel:<warnings>on
|
||||
<toolset>intel:<cxxflags>-strict-ansi
|
||||
|
@@ -15,7 +15,10 @@
|
||||
#include <boost/functional/hash/detail/hash_float.hpp>
|
||||
#include <string>
|
||||
#include <boost/limits.hpp>
|
||||
|
||||
#if defined(BOOST_HASH_NO_IMPLICIT_CASTS)
|
||||
#include <boost/static_assert.hpp>
|
||||
#endif
|
||||
|
||||
#if defined(BOOST_NO_TEMPLATE_PARTIAL_SPECIALIZATION)
|
||||
#include <boost/type_traits/is_pointer.hpp>
|
||||
@@ -30,7 +33,7 @@
|
||||
|
||||
namespace boost
|
||||
{
|
||||
#if !defined(BOOST_HASH_ALLOW_IMPLICIT_CASTS)
|
||||
#if defined(BOOST_HASH_NO_IMPLICIT_CASTS)
|
||||
|
||||
// If you get a static assertion here, it's because hash_value
|
||||
// isn't declared for your type.
|
||||
|
Reference in New Issue
Block a user