boostorg/functional
1
0
Fork 1
mirror of https://github.com/boostorg/functional.git synced 2025-07-31 04:57:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix cast issue in poor_quality_tests

Browse Source 
The comparison in the if statement and the test didn't match, which I
think is why this test was sometimes failling. But should still try to
write something that will work for floats.
This commit is contained in:
Daniel James
2016-11-18 14:57:16 +00:00
parent f230731aa5
commit e5575ba805
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
hash/test/hash_number_test.cpp
View File

@ -127,9 +127,13 @@ void poor_quality_tests(T*)
BOOST_TEST(x1(T(1)) != x2(T(-1))); BOOST_TEST(x1(T(1)) != x2(T(-1)));
if(T(1) != T(2)) if(T(1) != T(2))
BOOST_TEST(x1(T(1)) != x2(T(2))); BOOST_TEST(x1(T(1)) != x2(T(2)));
if((limits::max)() != (limits::max)() - 1)
BOOST_TEST(x1(static_cast<T>((limits::max)())) // TODO: This test is useless for floating point numbers.
!= x2(static_cast<T>((limits::max)() - 1))); T max_number = static_cast<T>((limits::max)());
T max_minus_one = static_cast<T>(max_number - 1);
if (max_number != max_minus_one) {
BOOST_TEST(x1(max_number) != x1(max_minus_one));
}
} }
void bool_test() void bool_test()