#includes revision and housekeeping

Summary: related to T13767

Reviewers: ivica

Reviewed By: ivica

Subscribers: iljazovic, miljen

Differential Revision: https://repo.mireo.local/D31700

test/include/test_common/message_exchange.hpp

@@ -8,12 +8,16 @@
 #ifndef ASYNC_MQTT5_TEST_MESSAGE_EXCHANGE_HPP
 #define ASYNC_MQTT5_TEST_MESSAGE_EXCHANGE_HPP
 
+#include <algorithm>
 #include <chrono>
+#include <cstdint>
 #include <deque>
 #include <optional>
 #include <string>
+#include <type_traits>
 #include <vector>
 
+#include <boost/system/error_code.hpp>
 #include <boost/type_traits/remove_cv_ref.hpp>
 
 #include "test_common/delayed_op.hpp"

test/include/test_common/packet_util.hpp

@@ -9,19 +9,20 @@
 #define ASYNC_MQTT5_TEST_PACKET_UTIL_HPP
 
 #include <bitset>
+#include <cstdint>
 #include <sstream>
 #include <string>
+#include <type_traits>
+#include <vector>
 
 #include <boost/algorithm/string/join.hpp>
-
 #include <boost/asio/buffer.hpp>
-
 #include <boost/range/algorithm/transform.hpp>
 
 #include <async_mqtt5/detail/control_packet.hpp>
-
 #include <async_mqtt5/impl/codecs/message_decoders.hpp>
 #include <async_mqtt5/impl/codecs/message_encoders.hpp>
+#include <async_mqtt5/impl/codecs/traits.hpp>
 
 namespace async_mqtt5::test {
 

test/include/test_common/test_authenticators.hpp

@@ -8,13 +8,16 @@
 #ifndef ASYNC_MQTT5_TEST_TEST_AUTHENTICATORS_HPP
 #define ASYNC_MQTT5_TEST_TEST_AUTHENTICATORS_HPP
 
+#include <string>
+#include <string_view>
+
+#include <boost/asio/async_result.hpp>
 #include <boost/asio/dispatch.hpp>
 #include <boost/asio/prepend.hpp>
+#include <boost/system/error_code.hpp>
 
 #include <async_mqtt5/types.hpp>
 
-#include <iostream>
-
 namespace async_mqtt5::test {
 
 namespace asio = boost::asio;

test/include/test_common/test_service.hpp

@@ -8,10 +8,14 @@
 #ifndef ASYNC_MQTT5_TEST_TEST_SERVICE_HPP
 #define ASYNC_MQTT5_TEST_TEST_SERVICE_HPP
 
+#include <cstdint>
+#include <variant>
+
 #include <boost/asio/any_io_executor.hpp>
-#include <boost/asio/associated_executor.hpp>
+#include <boost/asio/async_result.hpp>
 #include <boost/asio/post.hpp>
 #include <boost/asio/prepend.hpp>
+#include <boost/system/error_code.hpp>
 
 #include <async_mqtt5/types.hpp>
 
@@ -32,11 +36,11 @@ class test_service : public async_mqtt5::detail::client_service<StreamType, TlsC
 	asio::any_io_executor _ex;
 	connack_props _test_props;
 public:
-	explicit test_service(const asio::any_io_executor ex)
+	explicit test_service(const asio::any_io_executor& ex)
 		: base(ex), _ex(ex)
 	{}
 
-	test_service(const asio::any_io_executor ex, connack_props props)
+	test_service(const asio::any_io_executor& ex, connack_props props)
 		: base(ex), _ex(ex), _test_props(std::move(props))
 	{}
 
@@ -51,9 +55,9 @@ public:
 			);
 		};
 
-		return asio::async_initiate<
-			CompletionToken, void (error_code)
-		> (std::move(initiation), token);
+		return asio::async_initiate<CompletionToken, void (error_code)>(
+			std::move(initiation), token
+		);
 	}
 
 	template <typename Prop>

test/include/test_common/test_stream.hpp

@@ -8,14 +8,19 @@
 #ifndef ASYNC_MQTT5_TEST_TEST_STREAM_HPP
 #define ASYNC_MQTT5_TEST_TEST_STREAM_HPP
 
+#include <chrono>
+#include <memory>
+
 #include <boost/asio/associated_executor.hpp>
+#include <boost/asio/async_result.hpp>
 #include <boost/asio/dispatch.hpp>
 #include <boost/asio/execution_context.hpp>
 #include <boost/asio/post.hpp>
 #include <boost/asio/prepend.hpp>
+#include <boost/asio/steady_timer.hpp>
 #include <boost/asio/recycling_allocator.hpp>
-
 #include <boost/asio/ip/tcp.hpp>
+#include <boost/system/error_code.hpp>
 
 #include <async_mqtt5/detail/cancellable_handler.hpp>
 

test/integration/async_sender.cpp

@@ -5,12 +5,19 @@
 // (See accompanying file LICENSE or copy at http://www.boost.org/LICENSE_1_0.txt)
 //
 
+#include <chrono>
+#include <cstdint>
+#include <optional>
+#include <string>
+#include <vector>
+
 #include <boost/test/unit_test.hpp>
 
 #include <boost/asio/io_context.hpp>
 #include <boost/asio/steady_timer.hpp>
 
 #include <async_mqtt5/mqtt_client.hpp>
+#include <async_mqtt5/types.hpp>
 
 #include "test_common/message_exchange.hpp"
 #include "test_common/test_service.hpp"
@@ -55,7 +62,7 @@ struct shared_test_data {
 };
 
 using test::after;
-using namespace std::chrono;
+using namespace std::chrono_literals;
 
 BOOST_FIXTURE_TEST_CASE(publish_ordering_after_reconnect, shared_test_data) {
 	constexpr int expected_handlers_called = 2;

test/integration/cancellation.cpp

@@ -5,6 +5,8 @@
 // (See accompanying file LICENSE or copy at http://www.boost.org/LICENSE_1_0.txt)
 //
 
+#include <type_traits>
+
 #include <boost/test/unit_test.hpp>
 
 #include <boost/asio/as_tuple.hpp>
@@ -15,6 +17,7 @@
 #include <boost/asio/io_context.hpp>
 #include <boost/asio/steady_timer.hpp>
 #include <boost/asio/use_awaitable.hpp>
+#include <boost/asio/ip/tcp.hpp>
 
 #include <async_mqtt5.hpp>
 
@@ -272,7 +275,7 @@ struct shared_test_data {
 };
 
 using test::after;
-using namespace std::chrono;
+using namespace std::chrono_literals;
 
 #ifdef BOOST_ASIO_HAS_CO_AWAIT
 

test/integration/client.cpp

@@ -10,6 +10,8 @@
 #include <boost/asio/use_awaitable.hpp>
 #ifdef BOOST_ASIO_HAS_CO_AWAIT
 
+#include <chrono>
+
 #include <boost/asio/as_tuple.hpp>
 #include <boost/asio/co_spawn.hpp>
 #include <boost/asio/detached.hpp>
@@ -19,6 +21,8 @@
 
 #include <boost/beast/websocket.hpp>
 
+#include <boost/system/error_code.hpp>
+
 #include <async_mqtt5.hpp>
 
 namespace boost::beast::websocket {

test/integration/client_functions.cpp

@@ -8,15 +8,21 @@
 #include <boost/test/unit_test.hpp>
 
 #include <chrono>
+#include <cstdint>
 #include <optional>
+#include <string>
 
 #include <boost/asio/io_context.hpp>
+#include <boost/asio/detached.hpp>
 #include <boost/asio/steady_timer.hpp>
 
 #include <boost/asio/ip/tcp.hpp>
 #include <boost/asio/ssl/stream.hpp>
 
+#include <boost/type_traits/remove_cv_ref.hpp>
+
 #include <async_mqtt5/mqtt_client.hpp>
+#include <async_mqtt5/types.hpp>
 
 #include "test_common/message_exchange.hpp"
 #include "test_common/packet_util.hpp"
@@ -78,7 +84,7 @@ BOOST_AUTO_TEST_CASE(create_client_with_execution_context) {
 	BOOST_CHECK(c.get_executor() == ioc.get_executor());
 }
 
-BOOST_AUTO_TEST_CASE(assign_tls_context) {
+void assign_tls_context() {
 	// Tests if the tls_context function compiles
 
 	asio::io_context ioc;
@@ -113,7 +119,7 @@ BOOST_FIXTURE_TEST_CASE(assign_credentials, shared_test_data) {
 	);
 }
 
-BOOST_FIXTURE_TEST_CASE(assign_credentials_tls_client, shared_test_data) {
+void assign_credentials_tls_client() {
 	// Tests if the assign credentials function compiles
 
 	std::string client_id = "client_id";
@@ -155,7 +161,7 @@ BOOST_FIXTURE_TEST_CASE(assign_will, shared_test_data) {
 	);
 }
 
-BOOST_AUTO_TEST_CASE(assign_authenticator) {
+void assign_authenticator() {
 	// Tests if the authenticator function compiles
 
 	asio::io_context ioc;
@@ -163,7 +169,7 @@ BOOST_AUTO_TEST_CASE(assign_authenticator) {
 	c.authenticator(test::test_authenticator());
 }
 
-BOOST_AUTO_TEST_CASE(assign_authenticator_tls_client) {
+void assign_authenticator_tls_client() {
 	// Tests if the authenticator function compiles
 
 	asio::io_context ioc;
@@ -435,7 +441,7 @@ BOOST_FIXTURE_TEST_CASE(connack_property, shared_connack_prop_test_data) {
 	);
 }
 
-BOOST_FIXTURE_TEST_CASE(connack_property_with_tls_client, shared_connack_prop_test_data) {
+void connack_property_with_tls_client() {
 	// Tests if the connack_properties & connack_property functions compile
 
 	asio::io_context ioc;

test/integration/disconnect.cpp

@@ -7,11 +7,15 @@
 
 #include <boost/test/unit_test.hpp>
 
+#include <chrono>
+#include <string>
+
 #include <boost/asio/detached.hpp>
 #include <boost/asio/io_context.hpp>
 #include <boost/asio/steady_timer.hpp>
 
 #include <async_mqtt5/mqtt_client.hpp>
+#include <async_mqtt5/types.hpp>
 
 #include "test_common/message_exchange.hpp"
 #include "test_common/test_broker.hpp"

test/integration/executors.cpp

@@ -7,11 +7,15 @@
 
 #include <boost/test/unit_test.hpp>
 
+#include <cstdint>
 #include <chrono>
+#include <string>
+#include <vector>
 
-#include <boost/asio/io_context.hpp>
 #include <boost/asio/bind_executor.hpp>
 #include <boost/asio/bind_immediate_executor.hpp>
+#include <boost/asio/detached.hpp>
+#include <boost/asio/io_context.hpp>
 #include <boost/asio/strand.hpp>
 #include <boost/asio/steady_timer.hpp>
 
@@ -30,7 +34,7 @@ BOOST_AUTO_TEST_SUITE(executors)
 
 BOOST_AUTO_TEST_CASE(bind_executor) {
 	using test::after;
-	using namespace std::chrono;
+	using namespace std::chrono_literals;
 
 	constexpr int expected_handlers_called = 8;
 	int handlers_called = 0;

test/integration/mqtt_features.cpp

@@ -10,12 +10,15 @@
 #include <boost/asio/use_awaitable.hpp>
 #ifdef BOOST_ASIO_HAS_CO_AWAIT
 
+#include <cstdint>
+#include <chrono>
+#include <string>
+
 #include <boost/asio/as_tuple.hpp>
 #include <boost/asio/co_spawn.hpp>
 #include <boost/asio/detached.hpp>
 #include <boost/asio/io_context.hpp>
 #include <boost/asio/steady_timer.hpp>
-
 #include <boost/asio/ip/tcp.hpp>
 
 #include <boost/asio/experimental/awaitable_operators.hpp>

test/integration/ping.cpp

@@ -5,13 +5,19 @@
 // (See accompanying file LICENSE or copy at http://www.boost.org/LICENSE_1_0.txt)
 //
 
-#include <algorithm>
-
 #include <boost/test/unit_test.hpp>
 
+#include <algorithm>
+#include <chrono>
+#include <cstdint>
+#include <limits>
+#include <string>
+
+#include <boost/asio/detached.hpp>
 #include <boost/asio/io_context.hpp>
 
 #include <async_mqtt5/mqtt_client.hpp>
+#include <async_mqtt5/types.hpp>
 
 #include "test_common/message_exchange.hpp"
 #include "test_common/test_service.hpp"
@@ -34,7 +40,7 @@ struct shared_test_data {
 };
 
 using test::after;
-using namespace std::chrono;
+using namespace std::chrono_literals;
 
 std::string connect_with_keep_alive(uint16_t keep_alive) {
 	return encoders::encode_connect(

test/integration/re_authentication.cpp

@@ -7,10 +7,18 @@
 
 #include <boost/test/unit_test.hpp>
 
+#include <chrono>
+#include <cstdint>
+#include <string>
+#include <variant>
+#include <vector>
+
+#include <boost/asio/detached.hpp>
 #include <boost/asio/io_context.hpp>
 #include <boost/asio/steady_timer.hpp>
 
 #include <async_mqtt5/mqtt_client.hpp>
+#include <async_mqtt5/types.hpp>
 
 #include "test_common/message_exchange.hpp"
 #include "test_common/packet_util.hpp"
@@ -59,7 +67,7 @@ struct shared_test_data {
 };
 
 using test::after;
-using namespace std::chrono;
+using namespace std::chrono_literals;
 
 template <typename Authenticator = std::monostate>
 void run_test(

test/integration/read_message.cpp

@@ -7,9 +7,17 @@
 
 #include <boost/test/unit_test.hpp>
 
+#include <cstdint>
+#include <chrono>
+#include <string>
+
 #include <boost/asio/any_completion_handler.hpp>
+#include <boost/asio/detached.hpp>
+#include <boost/asio/io_context.hpp>
+#include <boost/asio/steady_timer.hpp>
 
 #include <async_mqtt5/mqtt_client.hpp>
+#include <async_mqtt5/types.hpp>
 
 #include "test_common/message_exchange.hpp"
 #include "test_common/test_service.hpp"
@@ -20,7 +28,7 @@ using namespace async_mqtt5;
 BOOST_AUTO_TEST_SUITE(read_message/*, *boost::unit_test::disabled()*/)
 
 using test::after;
-using namespace std::chrono;
+using namespace std::chrono_literals;
 
 void test_receive_malformed_packet(
 	std::string malformed_packet, std::string reason_string

test/integration/receive_publish.cpp

@@ -7,11 +7,18 @@
 
 #include <boost/test/unit_test.hpp>
 
+#include <cstdint>
+#include <string>
+#include <vector>
+
 #include <boost/asio/detached.hpp>
 #include <boost/asio/io_context.hpp>
 #include <boost/asio/steady_timer.hpp>
 
+#include <boost/algorithm/string/join.hpp>
+
 #include <async_mqtt5/mqtt_client.hpp>
+#include <async_mqtt5/types.hpp>
 
 #include "test_common/message_exchange.hpp"
 #include "test_common/packet_util.hpp"
@@ -55,7 +62,7 @@ struct shared_test_data {
 };
 
 using test::after;
-using namespace std::chrono;
+using namespace std::chrono_literals;
 
 void run_test(
 	test::msg_exchange broker_side, connect_props cprops = {}

test/integration/send_publish.cpp

@@ -7,9 +7,18 @@
 
 #include <boost/test/unit_test.hpp>
 
+#include <chrono>
+#include <cstdint>
+#include <string>
+
+#include <boost/asio/any_completion_handler.hpp>
+#include <boost/asio/bind_cancellation_slot.hpp>
+#include <boost/asio/cancellation_signal.hpp>
+#include <boost/asio/detached.hpp>
 #include <boost/asio/io_context.hpp>
 
 #include <async_mqtt5/mqtt_client.hpp>
+#include <async_mqtt5/types.hpp>
 
 #include "test_common/message_exchange.hpp"
 #include "test_common/packet_util.hpp"
@@ -52,7 +61,7 @@ struct shared_test_data {
 };
 
 using test::after;
-using namespace std::chrono;
+using namespace std::chrono_literals;
 
 template <qos_e qos>
 void run_test(

test/integration/sub_unsub.cpp

@@ -7,12 +7,19 @@
 
 #include <boost/test/unit_test.hpp>
 
+#include <chrono>
+#include <cstdint>
+#include <string>
+#include <vector>
+
 #include <boost/asio/any_completion_handler.hpp>
 #include <boost/asio/bind_cancellation_slot.hpp>
 #include <boost/asio/cancellation_signal.hpp>
+#include <boost/asio/detached.hpp>
 #include <boost/asio/io_context.hpp>
 
 #include <async_mqtt5/mqtt_client.hpp>
+#include <async_mqtt5/types.hpp>
 
 #include "test_common/message_exchange.hpp"
 #include "test_common/packet_util.hpp"
@@ -61,7 +68,7 @@ struct shared_test_data {
 };
 
 using test::after;
-using namespace std::chrono;
+using namespace std::chrono_literals;
 
 template <test::operation_type op_type>
 void run_test(test::msg_exchange broker_side) {

test/unit/async_mutex.cpp

@@ -7,11 +7,17 @@
 
 #include <boost/test/unit_test.hpp>
 
+#include <cstdint>
+#include <chrono>
+#include <string>
+
 #include <boost/asio/bind_executor.hpp>
+#include <boost/asio/error.hpp>
 #include <boost/asio/io_context.hpp>
 #include <boost/asio/strand.hpp>
 #include <boost/asio/thread_pool.hpp>
 
+#include <async_mqtt5/types.hpp>
 #include <async_mqtt5/detail/async_mutex.hpp>
 
 using namespace async_mqtt5;

test/unit/connect_op.cpp

@@ -7,16 +7,18 @@
 
 #include <boost/test/unit_test.hpp>
 
+#include <cstdint>
+#include <chrono>
+#include <string>
+#include <vector>
+
 #include <boost/asio/io_context.hpp>
 #include <boost/asio/steady_timer.hpp>
-
 #include <boost/asio/ip/tcp.hpp>
 
-#include <async_mqtt5/detail/internal_types.hpp>
-
-#include <async_mqtt5/impl/connect_op.hpp>
-
 #include <async_mqtt5/types.hpp>
+#include <async_mqtt5/detail/internal_types.hpp>
+#include <async_mqtt5/impl/connect_op.hpp>
 
 #include "test_common/test_authenticators.hpp"
 #include "test_common/test_stream.hpp"
@@ -38,7 +40,7 @@ struct shared_test_data {
 };
 
 using test::after;
-using namespace std::chrono;
+using namespace std::chrono_literals;
 
 void run_unit_test(
 	detail::mqtt_ctx mqtt_ctx, test::msg_exchange broker_side,

test/unit/default_completion_tokens.cpp

@@ -10,14 +10,15 @@
 
 #ifdef BOOST_ASIO_HAS_CO_AWAIT
 
+#include <cstdint>
 #include <string>
 #include <variant> // std::monostate
 #include <vector>
 
 #include <boost/asio/io_context.hpp>
-
 #include <boost/asio/ssl.hpp>
 #include <boost/asio/ip/tcp.hpp>
+
 #include <boost/beast/websocket/stream.hpp>
 #include <boost/beast/websocket/ssl.hpp> // async_teardown for asio::ssl::socket
 

test/unit/disconnect_op.cpp

@@ -7,8 +7,15 @@
 
 #include <boost/test/unit_test.hpp>
 
-#include <boost/asio/io_context.hpp>
+#include <cstdint>
+#include <chrono>
+#include <memory>
+#include <string>
 
+#include <boost/asio/io_context.hpp>
+#include <boost/asio/ip/tcp.hpp>
+
+#include <async_mqtt5/types.hpp>
 #include <async_mqtt5/impl/disconnect_op.hpp>
 
 #include "test_common/test_service.hpp"

test/unit/error.cpp

@@ -7,7 +7,8 @@
 
 #include <boost/test/unit_test.hpp>
 
-#include <sstream>
+#include <iosfwd>
+#include <string>
 #include <vector>
 
 #include <async_mqtt5/error.hpp>

test/unit/publish_send_op.cpp

@@ -7,10 +7,19 @@
 
 #include <boost/test/unit_test.hpp>
 
+#include <cstdint>
+#include <chrono>
+#include <memory>
+#include <string>
+#include <vector>
+
 #include <boost/asio/bind_cancellation_slot.hpp>
 #include <boost/asio/cancellation_signal.hpp>
 #include <boost/asio/io_context.hpp>
 #include <boost/asio/steady_timer.hpp>
+#include <boost/asio/ip/tcp.hpp>
+
+#include <async_mqtt5/types.hpp>
 
 #include <async_mqtt5/impl/client_service.hpp>
 #include <async_mqtt5/impl/publish_send_op.hpp>

test/unit/reconnect_op.cpp

@@ -7,7 +7,8 @@
 
 #include <boost/test/unit_test.hpp>
 
-#include <boost/asio/io_context.hpp>
+#include <chrono>
+
 #include <boost/asio/steady_timer.hpp>
 
 #include <async_mqtt5/impl/reconnect_op.hpp>

test/unit/serialization.cpp

@@ -7,6 +7,12 @@
 
 #include <boost/test/unit_test.hpp>
 
+#include <cstdint>
+#include <optional>
+#include <string>
+#include <string_view>
+#include <vector>
+
 #include <async_mqtt5/reason_codes.hpp>
 #include <async_mqtt5/types.hpp>
 

test/unit/session.cpp

@@ -7,6 +7,14 @@
 
 #include <boost/test/unit_test.hpp>
 
+#include <cstdint>
+#include <chrono>
+#include <string>
+
+#include <boost/asio/io_context.hpp>
+#include <boost/asio/steady_timer.hpp>
+#include <boost/asio/ip/tcp.hpp>
+
 #include <async_mqtt5.hpp>
 #include <test_common/test_service.hpp>
 

test/unit/subscribe_op.cpp

@@ -7,8 +7,16 @@
 
 #include <boost/test/unit_test.hpp>
 
-#include <boost/asio/io_context.hpp>
+#include <cstdint>
+#include <chrono>
+#include <memory>
+#include <string>
+#include <vector>
 
+#include <boost/asio/io_context.hpp>
+#include <boost/asio/ip/tcp.hpp>
+
+#include <async_mqtt5/types.hpp>
 #include <async_mqtt5/impl/subscribe_op.hpp>
 
 #include "test_common/test_service.hpp"

test/unit/unsubscribe_op.cpp

@@ -7,8 +7,16 @@
 
 #include <boost/test/unit_test.hpp>
 
-#include <boost/asio/io_context.hpp>
+#include <cstdint>
+#include <chrono>
+#include <memory>
+#include <string>
+#include <vector>
 
+#include <boost/asio/io_context.hpp>
+#include <boost/asio/ip/tcp.hpp>
+
+#include <async_mqtt5/types.hpp>
 #include <async_mqtt5/impl/unsubscribe_op.hpp>
 
 #include "test_common/test_service.hpp"