boostorg/optional
1
0
Fork 1
mirror of https://github.com/boostorg/optional.git synced 2025-07-25 01:57:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address unreachable code warning

Browse Source 
In MSVC optional<T&>::value() emits a warning C4702: unreachable code because throw_exception is marked BOOST_RETURN.
Otherwise the ternary code might have been preferable.
This change addresses the warning while preserving the functionality. It replicates optional<T>::value() for consistency.
This commit is contained in:
gieseanw
2020-12-18 11:13:47 -06:00
committed by Andrzej Krzemienski
parent a7f49cbec8
commit ead529af54
45 changed files with 79 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
include/boost/optional/detail/optional_reference_spec.hpp
View File

@ -151,7 +151,14 @@ public:
T* get_ptr() const BOOST_NOEXCEPT { return ptr_; }
T* operator->() const { BOOST_ASSERT(ptr_); return ptr_; }
T& operator*() const { BOOST_ASSERT(ptr_); return *ptr_; }
T& value() const { return ptr_ ? *ptr_ : (throw_exception(bad_optional_access()), *ptr_); }
T& value() const
{
if (this->is_initialized())
return this->get();
else
throw_exception(bad_optional_access());
}
bool operator!() const BOOST_NOEXCEPT { return ptr_ == 0; }
BOOST_EXPLICIT_OPERATOR_BOOL_NOEXCEPT()