boostorg/optional
1
0
Fork 1
mirror of https://github.com/boostorg/optional.git synced 2025-07-16 05:42:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

Work around msvc bug when explicitly destroying a class with a virtual base. Fixes #5940.

Browse Source 
[SVN r82915]
This commit is contained in:
Steven Watanabe
2013-02-15 19:22:34 +00:00
parent e40c2654d9
commit ff48f2b3a0
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/boost/optional/optional.hpp
View File

@ -476,7 +476,7 @@ class optional_base : public optional_tag
#if BOOST_WORKAROUND(__BORLANDC__, BOOST_TESTED_AT(0x581)) #if BOOST_WORKAROUND(__BORLANDC__, BOOST_TESTED_AT(0x581))
void destroy_impl ( is_not_reference_tag ) { get_ptr_impl()->internal_type::~internal_type() ; m_initialized = false ; } void destroy_impl ( is_not_reference_tag ) { get_ptr_impl()->internal_type::~internal_type() ; m_initialized = false ; }
#else #else
void destroy_impl ( is_not_reference_tag ) { get_ptr_impl()->T::~T() ; m_initialized = false ; } void destroy_impl ( is_not_reference_tag ) { get_ptr_impl()->~T() ; m_initialized = false ; }
#endif #endif
void destroy_impl ( is_reference_tag ) { m_initialized = false ; } void destroy_impl ( is_reference_tag ) { m_initialized = false ; }

8
test/optional_test.cpp
View File

@ -840,11 +840,19 @@ void test_with_builtin_types()
test_none( ARG(double) ) ; test_none( ARG(double) ) ;
} }
// MSVC < 11.0 doesn't destroy X when we call ptr->VBase::VBase.
// Make sure that we work around this bug.
struct VBase : virtual X
{
VBase(int v) : X(v) {}
};
void test_with_class_type() void test_with_class_type()
{ {
TRACE( std::endl << BOOST_CURRENT_FUNCTION ); TRACE( std::endl << BOOST_CURRENT_FUNCTION );
test_basics( ARG(X) ); test_basics( ARG(X) );
test_basics( ARG(VBase) );
test_conditional_ctor_and_get_valur_or( ARG(X) ); test_conditional_ctor_and_get_valur_or( ARG(X) );
test_direct_value_manip( ARG(X) ); test_direct_value_manip( ARG(X) );
test_uninitialized_access( ARG(X) ); test_uninitialized_access( ARG(X) );