Compare commits

..

1 Commits

Author SHA1 Message Date
da8f2d028e v2, v3, integration branch
[SVN r62649]
2010-06-09 11:34:33 +00:00
7 changed files with 153 additions and 219 deletions

View File

@ -24,7 +24,7 @@ boostbook standalone
optional optional
: :
<xsl:param>boost.root=../../../.. <xsl:param>boost.root=../../../..
<xsl:param>html.stylesheet=boostbook.css <xsl:param>boost.libraries=../../../libraries.htm
<xsl:param>toc.max.depth=2 <xsl:param>toc.max.depth=2
<xsl:param>toc.section.depth=2 <xsl:param>toc.section.depth=2
<xsl:param>chunk.section.depth=1 <xsl:param>chunk.section.depth=1

View File

@ -4,7 +4,7 @@
// License, Version 1.0. (See accompanying file LICENSE_1_0.txt or copy at // License, Version 1.0. (See accompanying file LICENSE_1_0.txt or copy at
// http://www.boost.org/LICENSE_1_0.txt) // http://www.boost.org/LICENSE_1_0.txt)
// //
// See http://www.boost.org/libs/optional for documentation. // See http://www.boost.org/lib/optional for documentation.
// //
// You are welcome to contact the author at: // You are welcome to contact the author at:
// fernando_cacciola@hotmail.com // fernando_cacciola@hotmail.com

View File

@ -4,39 +4,37 @@
// License, Version 1.0. (See accompanying file LICENSE_1_0.txt or copy at // License, Version 1.0. (See accompanying file LICENSE_1_0.txt or copy at
// http://www.boost.org/LICENSE_1_0.txt) // http://www.boost.org/LICENSE_1_0.txt)
// //
// See http://www.boost.org/libs/optional for documentation. // See http://www.boost.org/lib/optional for documentation.
// //
// You are welcome to contact the author at: // You are welcome to contact the author at:
// fernando_cacciola@hotmail.com // fernando_cacciola@hotmail.com
// //
// Revisions: // Revisions:
// 27 Apr 2008 (improved swap) Fernando Cacciola, Niels Dekker, Thorsten Ottosen // 27 Apr 2008 (improved swap) Fernando Cacciola, Niels Dekker, Thorsten Ottosen
// //
#ifndef BOOST_OPTIONAL_OPTIONAL_FLC_19NOV2002_HPP #ifndef BOOST_OPTIONAL_OPTIONAL_FLC_19NOV2002_HPP
#define BOOST_OPTIONAL_OPTIONAL_FLC_19NOV2002_HPP #define BOOST_OPTIONAL_OPTIONAL_FLC_19NOV2002_HPP
#include <new> #include<new>
#include <algorithm> #include<algorithm>
#include <boost/config.hpp> #include "boost/config.hpp"
#include <boost/assert.hpp> #include "boost/assert.hpp"
#include <boost/type.hpp> #include "boost/type.hpp"
#include <boost/type_traits/alignment_of.hpp> #include "boost/type_traits/alignment_of.hpp"
#include <boost/type_traits/has_nothrow_constructor.hpp> #include "boost/type_traits/has_nothrow_constructor.hpp"
#include <boost/type_traits/type_with_alignment.hpp> #include "boost/type_traits/type_with_alignment.hpp"
#include <boost/type_traits/remove_reference.hpp> #include "boost/type_traits/remove_reference.hpp"
#include <boost/type_traits/is_reference.hpp> #include "boost/type_traits/is_reference.hpp"
#include <boost/mpl/if.hpp> #include "boost/mpl/if.hpp"
#include <boost/mpl/bool.hpp> #include "boost/mpl/bool.hpp"
#include <boost/mpl/not.hpp> #include "boost/mpl/not.hpp"
#include <boost/detail/reference_content.hpp> #include "boost/detail/reference_content.hpp"
#include <boost/none.hpp> #include "boost/none.hpp"
#include <boost/utility/swap.hpp> #include "boost/utility/compare_pointees.hpp"
#include <boost/utility/addressof.hpp> #include "boost/utility/in_place_factory.hpp"
#include <boost/utility/compare_pointees.hpp>
#include <boost/utility/in_place_factory.hpp>
#include <boost/optional/optional_fwd.hpp> #include "boost/optional/optional_fwd.hpp"
#if BOOST_WORKAROUND(BOOST_MSVC, == 1200) #if BOOST_WORKAROUND(BOOST_MSVC, == 1200)
// VC6.0 has the following bug: // VC6.0 has the following bug:
@ -83,15 +81,6 @@
#define BOOST_OPTIONAL_WEAK_OVERLOAD_RESOLUTION #define BOOST_OPTIONAL_WEAK_OVERLOAD_RESOLUTION
#endif #endif
#if defined(__GNUC__) && (__GNUC__ * 100 + __GNUC_MINOR__) > 302 \
&& !defined(__INTEL_COMPILER)
// GCC since 3.3 has may_alias attribute that helps to alleviate optimizer issues with
// regard to violation of the strict aliasing rules. The optional< T > storage type is marked
// with this attribute in order to let the compiler know that it will alias objects of type T
// and silence compilation warnings.
#define BOOST_OPTIONAL_DETAIL_USE_ATTRIBUTE_MAY_ALIAS
#endif
// Daniel Wallin discovered that bind/apply.hpp badly interacts with the apply<> // Daniel Wallin discovered that bind/apply.hpp badly interacts with the apply<>
// member template of a factory as used in the optional<> implementation. // member template of a factory as used in the optional<> implementation.
// He proposed this simple fix which is to move the call to apply<> outside // He proposed this simple fix which is to move the call to apply<> outside
@ -99,7 +88,7 @@
namespace boost_optional_detail namespace boost_optional_detail
{ {
template <class T, class Factory> template <class T, class Factory>
inline void construct(Factory const& factory, void* address) void construct(Factory const& factory, void* address)
{ {
factory.BOOST_NESTED_TEMPLATE apply<T>(address); factory.BOOST_NESTED_TEMPLATE apply<T>(address);
} }
@ -111,9 +100,6 @@ namespace boost {
class in_place_factory_base ; class in_place_factory_base ;
class typed_in_place_factory_base ; class typed_in_place_factory_base ;
// This forward is needed to refer to namespace scope swap from the member swap
template<class T> void swap ( optional<T>& x, optional<T>& y );
namespace optional_detail { namespace optional_detail {
// This local class is used instead of that in "aligned_storage.hpp" // This local class is used instead of that in "aligned_storage.hpp"
@ -124,12 +110,7 @@ template <class T>
class aligned_storage class aligned_storage
{ {
// Borland ICEs if unnamed unions are used for this! // Borland ICEs if unnamed unions are used for this!
union union dummy_u
// This works around GCC warnings about breaking strict aliasing rules when casting storage address to T*
#if defined(BOOST_OPTIONAL_DETAIL_USE_ATTRIBUTE_MAY_ALIAS)
__attribute__((may_alias))
#endif
dummy_u
{ {
char data[ sizeof(T) ]; char data[ sizeof(T) ];
BOOST_DEDUCED_TYPENAME type_with_alignment< BOOST_DEDUCED_TYPENAME type_with_alignment<
@ -138,13 +119,8 @@ class aligned_storage
public: public:
#if defined(BOOST_OPTIONAL_DETAIL_USE_ATTRIBUTE_MAY_ALIAS) void const* address() const { return &dummy_.data[0]; }
void const* address() const { return &dummy_; } void * address() { return &dummy_.data[0]; }
void * address() { return &dummy_; }
#else
void const* address() const { return dummy_.data; }
void * address() { return dummy_.data; }
#endif
} ; } ;
template<class T> template<class T>
@ -178,7 +154,7 @@ class optional_base : public optional_tag
typedef typedef
#if !BOOST_WORKAROUND(__BORLANDC__, BOOST_TESTED_AT(0x564)) #if !BOOST_WORKAROUND(__BORLANDC__, BOOST_TESTED_AT(0x564))
BOOST_DEDUCED_TYPENAME BOOST_DEDUCED_TYPENAME
#endif #endif
::boost::detail::make_reference_content<T>::type internal_type ; ::boost::detail::make_reference_content<T>::type internal_type ;
typedef aligned_storage<internal_type> storage_type ; typedef aligned_storage<internal_type> storage_type ;
@ -229,7 +205,7 @@ class optional_base : public optional_tag
{ {
construct(val); construct(val);
} }
// Creates an optional<T> initialized with 'val' IFF cond is true, otherwise creates an uninitialzed optional<T>. // Creates an optional<T> initialized with 'val' IFF cond is true, otherwise creates an uninitialzed optional<T>.
// Can throw if T::T(T const&) does // Can throw if T::T(T const&) does
optional_base ( bool cond, argument_type val ) optional_base ( bool cond, argument_type val )
@ -450,22 +426,8 @@ class optional_base : public optional_tag
private : private :
// internal_type can be either T or reference_content<T> // internal_type can be either T or reference_content<T>
#if defined(BOOST_OPTIONAL_DETAIL_USE_ATTRIBUTE_MAY_ALIAS)
// This workaround is supposed to silence GCC warnings about broken strict aliasing rules
internal_type const* get_object() const
{
union { void const* ap_pvoid; internal_type const* as_ptype; } caster = { m_storage.address() };
return caster.as_ptype;
}
internal_type * get_object()
{
union { void* ap_pvoid; internal_type* as_ptype; } caster = { m_storage.address() };
return caster.as_ptype;
}
#else
internal_type const* get_object() const { return static_cast<internal_type const*>(m_storage.address()); } internal_type const* get_object() const { return static_cast<internal_type const*>(m_storage.address()); }
internal_type * get_object() { return static_cast<internal_type *> (m_storage.address()); } internal_type * get_object() { return static_cast<internal_type *> (m_storage.address()); }
#endif
// reference_content<T> lacks an implicit conversion to T&, so the following is needed to obtain a proper reference. // reference_content<T> lacks an implicit conversion to T&, so the following is needed to obtain a proper reference.
reference_const_type dereference( internal_type const* p, is_not_reference_tag ) const { return *p ; } reference_const_type dereference( internal_type const* p, is_not_reference_tag ) const { return *p ; }
@ -556,7 +518,7 @@ class optional : public optional_detail::optional_base<T>
// Depending on the above some T ctor is called. // Depending on the above some T ctor is called.
// Can throw is the resolved T ctor throws. // Can throw is the resolved T ctor throws.
template<class Expr> template<class Expr>
explicit optional ( Expr const& expr ) : base(expr,boost::addressof(expr)) {} explicit optional ( Expr const& expr ) : base(expr,&expr) {}
#endif #endif
// Creates a deep copy of another optional<T> // Creates a deep copy of another optional<T>
@ -570,9 +532,9 @@ class optional : public optional_detail::optional_base<T>
// Assigns from an expression. See corresponding constructor. // Assigns from an expression. See corresponding constructor.
// Basic Guarantee: If the resolved T ctor throws, this is left UNINITIALIZED // Basic Guarantee: If the resolved T ctor throws, this is left UNINITIALIZED
template<class Expr> template<class Expr>
optional& operator= ( Expr const& expr ) optional& operator= ( Expr expr )
{ {
this->assign_expr(expr,boost::addressof(expr)); this->assign_expr(expr,&expr);
return *this ; return *this ;
} }
#endif #endif
@ -619,7 +581,7 @@ class optional : public optional_detail::optional_base<T>
void swap( optional & arg ) void swap( optional & arg )
{ {
// allow for Koenig lookup // allow for Koenig lookup
using boost::swap; using boost::swap ;
swap(*this, arg); swap(*this, arg);
} }
@ -633,7 +595,7 @@ class optional : public optional_detail::optional_base<T>
// Returns a copy of the value if this is initialized, 'v' otherwise // Returns a copy of the value if this is initialized, 'v' otherwise
reference_const_type get_value_or ( reference_const_type v ) const { return this->is_initialized() ? get() : v ; } reference_const_type get_value_or ( reference_const_type v ) const { return this->is_initialized() ? get() : v ; }
reference_type get_value_or ( reference_type v ) { return this->is_initialized() ? get() : v ; } reference_type get_value_or ( reference_type v ) { return this->is_initialized() ? get() : v ; }
// Returns a pointer to the value if this is initialized, otherwise, // Returns a pointer to the value if this is initialized, otherwise,
// the behaviour is UNDEFINED // the behaviour is UNDEFINED
// No-throw // No-throw
@ -650,22 +612,22 @@ class optional : public optional_detail::optional_base<T>
// No-throw // No-throw
operator unspecified_bool_type() const { return this->safe_bool() ; } operator unspecified_bool_type() const { return this->safe_bool() ; }
// This is provided for those compilers which don't like the conversion to bool // This is provided for those compilers which don't like the conversion to bool
// on some contexts. // on some contexts.
bool operator!() const { return !this->is_initialized() ; } bool operator!() const { return !this->is_initialized() ; }
} ; } ;
// Returns optional<T>(v) // Returns optional<T>(v)
template<class T> template<class T>
inline inline
optional<T> make_optional ( T const& v ) optional<T> make_optional ( T const& v )
{ {
return optional<T>(v); return optional<T>(v);
} }
// Returns optional<T>(cond,v) // Returns optional<T>(cond,v)
template<class T> template<class T>
inline inline
optional<T> make_optional ( bool cond, T const& v ) optional<T> make_optional ( bool cond, T const& v )
{ {
return optional<T>(cond,v); return optional<T>(cond,v);
@ -918,63 +880,79 @@ inline
bool operator >= ( none_t x, optional<T> const& y ) bool operator >= ( none_t x, optional<T> const& y )
{ return !( x < y ) ; } { return !( x < y ) ; }
//
// The following swap implementation follows the GCC workaround as found in
// "boost/detail/compressed_pair.hpp"
//
namespace optional_detail { namespace optional_detail {
template<bool use_default_constructor> struct swap_selector; // GCC < 3.2 gets the using declaration at namespace scope (FLC, DWA)
#if BOOST_WORKAROUND(__GNUC__, < 3) \
|| BOOST_WORKAROUND(__GNUC__, == 3) && __GNUC_MINOR__ <= 2
using std::swap;
#define BOOST_OPTIONAL_STD_SWAP_INTRODUCED_AT_NS_SCOPE
#endif
template<> template<bool use_default_constructor> struct swap_selector;
struct swap_selector<true>
{ template<>
struct swap_selector<true>
{
template<class T> template<class T>
static void optional_swap ( optional<T>& x, optional<T>& y ) static void optional_swap ( optional<T>& x, optional<T>& y )
{ {
const bool hasX = !!x; bool hasX = x;
const bool hasY = !!y; bool hasY = y;
if ( !hasX && !hasY ) if ( !hasX && !hasY )
return; return;
if( !hasX ) if( !hasX )
x = boost::in_place(); x = boost::in_place();
else if ( !hasY ) else if ( !hasY )
y = boost::in_place(); y = boost::in_place();
// Boost.Utility.Swap will take care of ADL and workarounds for broken compilers // GCC > 3.2 and all other compilers have the using declaration at function scope (FLC)
boost::swap(x.get(),y.get()); #ifndef BOOST_OPTIONAL_STD_SWAP_INTRODUCED_AT_NS_SCOPE
// allow for Koenig lookup
using std::swap ;
#endif
swap(*x,*y);
if( !hasX ) if( !hasX )
y = boost::none ; y = boost::none ;
else if( !hasY ) else if( !hasY )
x = boost::none ; x = boost::none ;
} }
}; };
template<> template<>
struct swap_selector<false> struct swap_selector<false>
{ {
template<class T> template<class T>
static void optional_swap ( optional<T>& x, optional<T>& y ) static void optional_swap ( optional<T>& x, optional<T>& y )
{ {
const bool hasX = !!x; if ( !x && !!y )
const bool hasY = !!y; {
x = *y;
if ( !hasX && hasY ) y = boost::none ;
{ }
x = y.get(); else if ( !!x && !y )
y = boost::none ; {
} y = *x ;
else if ( hasX && !hasY ) x = boost::none ;
{ }
y = x.get(); else if ( !!x && !!y )
x = boost::none ; {
} // GCC > 3.2 and all other compilers have the using declaration at function scope (FLC)
else if ( hasX && hasY ) #ifndef BOOST_OPTIONAL_STD_SWAP_INTRODUCED_AT_NS_SCOPE
{ // allow for Koenig lookup
// Boost.Utility.Swap will take care of ADL and workarounds for broken compilers using std::swap ;
boost::swap(x.get(),y.get()); #endif
} swap(*x,*y);
}
} }
}; };
} // namespace optional_detail } // namespace optional_detail
@ -983,9 +961,10 @@ struct optional_swap_should_use_default_constructor : has_nothrow_default_constr
template<class T> inline void swap ( optional<T>& x, optional<T>& y ) template<class T> inline void swap ( optional<T>& x, optional<T>& y )
{ {
optional_detail::swap_selector<optional_swap_should_use_default_constructor<T>::value>::optional_swap(x, y); optional_detail::swap_selector<optional_swap_should_use_default_constructor<T>::value>::optional_swap(x, y);
} }
} // namespace boost } // namespace boost
#endif #endif

View File

@ -4,7 +4,7 @@
// License, Version 1.0. (See accompanying file LICENSE_1_0.txt or copy at // License, Version 1.0. (See accompanying file LICENSE_1_0.txt or copy at
// http://www.boost.org/LICENSE_1_0.txt) // http://www.boost.org/LICENSE_1_0.txt)
// //
// See http://www.boost.org/libs/optional for documentation. // See http://www.boost.org/lib/optional for documentation.
// //
// You are welcome to contact the author at: // You are welcome to contact the author at:
// fernando_cacciola@hotmail.com // fernando_cacciola@hotmail.com

View File

@ -4,7 +4,7 @@
// License, Version 1.0. (See accompanying file LICENSE_1_0.txt or copy at // License, Version 1.0. (See accompanying file LICENSE_1_0.txt or copy at
// http://www.boost.org/LICENSE_1_0.txt) // http://www.boost.org/LICENSE_1_0.txt)
// //
// See http://www.boost.org/libs/optional for documentation. // See http://www.boost.org/lib/optional for documentation.
// //
// You are welcome to contact the author at: // You are welcome to contact the author at:
// fernando_cacciola@hotmail.com // fernando_cacciola@hotmail.com
@ -13,20 +13,19 @@
#define BOOST_OPTIONAL_OPTIONAL_IO_FLC_19NOV2002_HPP #define BOOST_OPTIONAL_OPTIONAL_IO_FLC_19NOV2002_HPP
#if defined __GNUC__ #if defined __GNUC__
# if (__GNUC__ == 2 && __GNUC_MINOR__ <= 97) # if (__GNUC__ == 2 && __GNUC_MINOR__ <= 97)
# define BOOST_OPTIONAL_NO_TEMPLATED_STREAMS # define BOOST_OPTIONAL_NO_TEMPLATED_STREAMS
# endif # endif
#endif // __GNUC__ #endif // __GNUC__
#if defined BOOST_OPTIONAL_NO_TEMPLATED_STREAMS #if defined BOOST_OPTIONAL_NO_TEMPLATED_STREAMS
# include <iostream> # include <iostream>
#else #else
# include <istream> # include <istream>
# include <ostream> # include <ostream>
#endif #endif
#include <boost/none.hpp>
#include <boost/assert.hpp>
#include "boost/optional/optional.hpp" #include "boost/optional/optional.hpp"
#include "boost/utility/value_init.hpp" #include "boost/utility/value_init.hpp"
@ -63,30 +62,17 @@ std::basic_istream<CharType, CharTrait>&
operator>>(std::basic_istream<CharType, CharTrait>& in, optional<T>& v) operator>>(std::basic_istream<CharType, CharTrait>& in, optional<T>& v)
#endif #endif
{ {
if (in.good()) if ( in.good() )
{ {
int d = in.get(); int d = in.get();
if (d == ' ') if ( d == ' ' )
{ {
T x; T x ;
in >> x; in >> x;
v = x; v = x ;
} }
else else
{ v = optional<T>() ;
if (d == '-')
{
d = in.get();
if (d == '-')
{
v = none;
return in;
}
}
in.setstate( std::ios::failbit );
}
} }
return in; return in;

View File

@ -158,27 +158,27 @@ void test_basics( T const* )
ob.reset(); ob.reset();
check_is_pending_dtor( ARG(T) ) ; check_is_pending_dtor( ARG(T) ) ;
check_uninitialized(ob); check_uninitialized(ob);
} }
template<class T> template<class T>
void test_conditional_ctor_and_get_valur_or ( T const* ) void test_conditional_ctor_and_get_valur_or ( T const* )
{ {
TRACE( std::endl << BOOST_CURRENT_FUNCTION ); TRACE( std::endl << BOOST_CURRENT_FUNCTION );
T a(321); T a(321);
T z(123); T z(123);
optional<T> const cdef0(false,a); optional<T> const cdef0(false,a);
optional<T> def0(false,a); optional<T> def0(false,a);
optional<T> def1 = boost::make_optional(false,a); // T is not within boost so ADL won't find make_optional unqualified optional<T> def1 = boost::make_optional(false,a); // T is not within boost so ADL won't find make_optional unqualified
check_uninitialized(def0); check_uninitialized(def0);
check_uninitialized(def1); check_uninitialized(def1);
optional<T> const co0(true,a); optional<T> const co0(true,a);
optional<T> o0(true,a); optional<T> o0(true,a);
optional<T> o1 = boost::make_optional(true,a); // T is not within boost so ADL won't find make_optional unqualified optional<T> o1 = boost::make_optional(true,a); // T is not within boost so ADL won't find make_optional unqualified
@ -186,65 +186,65 @@ void test_conditional_ctor_and_get_valur_or ( T const* )
check_initialized(o1); check_initialized(o1);
check_value(o0,a,z); check_value(o0,a,z);
check_value(o1,a,z); check_value(o1,a,z);
T b = def0.get_value_or(z); T b = def0.get_value_or(z);
BOOST_CHECK( b == z ) ; BOOST_CHECK( b == z ) ;
b = get_optional_value_or(def0,z); b = get_optional_value_or(def0,z);
BOOST_CHECK( b == z ) ; BOOST_CHECK( b == z ) ;
b = o0.get_value_or(z); b = o0.get_value_or(z);
BOOST_CHECK( b == a ) ; BOOST_CHECK( b == a ) ;
b = get_optional_value_or(o0,z); b = get_optional_value_or(o0,z);
BOOST_CHECK( b == a ) ; BOOST_CHECK( b == a ) ;
T const& crz = z ; T const& crz = z ;
T& rz = z ; T& rz = z ;
T const& crzz = def0.get_value_or(crz); T const& crzz = def0.get_value_or(crz);
BOOST_CHECK( crzz == crz ) ; BOOST_CHECK( crzz == crz ) ;
T& rzz = def0.get_value_or(rz); T& rzz = def0.get_value_or(rz);
BOOST_CHECK( rzz == rz ) ; BOOST_CHECK( rzz == rz ) ;
T const& crzzz = get_optional_value_or(cdef0,crz); T const& crzzz = get_optional_value_or(cdef0,crz);
BOOST_CHECK( crzzz == crz ) ; BOOST_CHECK( crzzz == crz ) ;
T& rzzz = get_optional_value_or(def0,rz); T& rzzz = get_optional_value_or(def0,rz);
BOOST_CHECK( rzzz == rz ) ; BOOST_CHECK( rzzz == rz ) ;
T const& crb = o0.get_value_or(crz); T const& crb = o0.get_value_or(crz);
BOOST_CHECK( crb == a ) ; BOOST_CHECK( crb == a ) ;
T& rb = o0.get_value_or(rz); T& rb = o0.get_value_or(rz);
BOOST_CHECK( rb == b ) ; BOOST_CHECK( rb == b ) ;
T const& crbb = get_optional_value_or(co0,crz); T const& crbb = get_optional_value_or(co0,crz);
BOOST_CHECK( crbb == b ) ; BOOST_CHECK( crbb == b ) ;
T const& crbbb = get_optional_value_or(o0,crz); T const& crbbb = get_optional_value_or(o0,crz);
BOOST_CHECK( crbbb == b ) ; BOOST_CHECK( crbbb == b ) ;
T& rbb = get_optional_value_or(o0,rz); T& rbb = get_optional_value_or(o0,rz);
BOOST_CHECK( rbb == b ) ; BOOST_CHECK( rbb == b ) ;
T& ra = a ; T& ra = a ;
optional<T&> defref(false,ra); optional<T&> defref(false,ra);
BOOST_CHECK(!defref); BOOST_CHECK(!defref);
optional<T&> ref(true,ra); optional<T&> ref(true,ra);
BOOST_CHECK(!!ref); BOOST_CHECK(!!ref);
a = T(432); a = T(432);
BOOST_CHECK( *ref == a ) ; BOOST_CHECK( *ref == a ) ;
T& r1 = defref.get_value_or(z); T& r1 = defref.get_value_or(z);
BOOST_CHECK( r1 == z ) ; BOOST_CHECK( r1 == z ) ;
T& r2 = ref.get_value_or(z); T& r2 = ref.get_value_or(z);
BOOST_CHECK( r2 == a ) ; BOOST_CHECK( r2 == a ) ;
} }
@ -718,7 +718,7 @@ void test_relops( T const* )
optional<T> opt0(v0); optional<T> opt0(v0);
optional<T> opt1(v1); optional<T> opt1(v1);
optional<T> opt2(v2); optional<T> opt2(v2);
// Check identity // Check identity
BOOST_CHECK ( def0 == def0 ) ; BOOST_CHECK ( def0 == def0 ) ;
BOOST_CHECK ( opt0 == opt0 ) ; BOOST_CHECK ( opt0 == opt0 ) ;
@ -756,7 +756,7 @@ void test_relops( T const* )
BOOST_CHECK ( opt1 > opt0 ) ; BOOST_CHECK ( opt1 > opt0 ) ;
BOOST_CHECK ( opt1 <= opt2 ) ; BOOST_CHECK ( opt1 <= opt2 ) ;
BOOST_CHECK ( opt1 >= opt0 ) ; BOOST_CHECK ( opt1 >= opt0 ) ;
// Compare against a value directly // Compare against a value directly
BOOST_CHECK ( opt0 == v0 ) ; BOOST_CHECK ( opt0 == v0 ) ;
BOOST_CHECK ( opt0 != v1 ) ; BOOST_CHECK ( opt0 != v1 ) ;
@ -799,7 +799,7 @@ void test_none( T const* )
BOOST_CHECK ( def0 == none ) ; BOOST_CHECK ( def0 == none ) ;
BOOST_CHECK ( non_def != none ) ; BOOST_CHECK ( non_def != none ) ;
BOOST_CHECK ( !def1 ) ; BOOST_CHECK ( !def1 ) ;
BOOST_CHECK ( !(non_def < none) ) ; BOOST_CHECK ( !(non_def < none) ) ;
BOOST_CHECK ( non_def > none ) ; BOOST_CHECK ( non_def > none ) ;
BOOST_CHECK ( !(non_def <= none) ) ; BOOST_CHECK ( !(non_def <= none) ) ;
BOOST_CHECK ( non_def >= none ) ; BOOST_CHECK ( non_def >= none ) ;
@ -819,11 +819,11 @@ void test_arrow( T const* )
optional<T> oa(a) ; optional<T> oa(a) ;
optional<T> const coa(a) ; optional<T> const coa(a) ;
BOOST_CHECK ( coa->V() == 1234 ) ; BOOST_CHECK ( coa->V() == 1234 ) ;
oa->V() = 4321 ; oa->V() = 4321 ;
BOOST_CHECK ( a.V() = 1234 ) ; BOOST_CHECK ( a.V() = 1234 ) ;
BOOST_CHECK ( (*oa).V() = 4321 ) ; BOOST_CHECK ( (*oa).V() = 4321 ) ;
} }
@ -1086,7 +1086,7 @@ namespace optional_swap_test
x = boost::in_place('\0'); x = boost::in_place('\0');
else if ( !hasY ) else if ( !hasY )
y = boost::in_place('\0'); y = boost::in_place('\0');
optional_swap_test::swap(*x,*y); optional_swap_test::swap(*x,*y);
if( !hasX ) if( !hasX )
@ -1118,7 +1118,7 @@ template <class T> struct optional_swap_should_use_default_constructor<
// //
// Specialization of boost::swap: // Specialization of boost::swap:
// //
template <> template <>
void swap(optional<optional_swap_test::class_whose_explicit_ctor_should_be_used> & x, optional<optional_swap_test::class_whose_explicit_ctor_should_be_used> & y) void swap(optional<optional_swap_test::class_whose_explicit_ctor_should_be_used> & x, optional<optional_swap_test::class_whose_explicit_ctor_should_be_used> & y)
{ {
optional_swap_test::swap(x, y); optional_swap_test::swap(x, y);
@ -1133,25 +1133,25 @@ namespace std {
// Specializations of std::swap: // Specializations of std::swap:
// //
template <> template <>
void swap(optional_swap_test::class_whose_default_ctor_should_be_used & x, optional_swap_test::class_whose_default_ctor_should_be_used & y) void swap(optional_swap_test::class_whose_default_ctor_should_be_used & x, optional_swap_test::class_whose_default_ctor_should_be_used & y)
{ {
optional_swap_test::swap(x, y); optional_swap_test::swap(x, y);
} }
template <> template <>
void swap(optional_swap_test::class_whose_default_ctor_should_not_be_used & x, optional_swap_test::class_whose_default_ctor_should_not_be_used & y) void swap(optional_swap_test::class_whose_default_ctor_should_not_be_used & x, optional_swap_test::class_whose_default_ctor_should_not_be_used & y)
{ {
optional_swap_test::swap(x, y); optional_swap_test::swap(x, y);
} }
template <> template <>
void swap(optional_swap_test::class_without_default_ctor & x, optional_swap_test::class_without_default_ctor & y) void swap(optional_swap_test::class_without_default_ctor & x, optional_swap_test::class_without_default_ctor & y)
{ {
optional_swap_test::swap(x, y); optional_swap_test::swap(x, y);
} }
template <> template <>
void swap(optional_swap_test::class_whose_explicit_ctor_should_be_used & x, optional_swap_test::class_whose_explicit_ctor_should_be_used & y) void swap(optional_swap_test::class_whose_explicit_ctor_should_be_used & x, optional_swap_test::class_whose_explicit_ctor_should_be_used & y)
{ {
optional_swap_test::swap(x, y); optional_swap_test::swap(x, y);
@ -1204,7 +1204,7 @@ bool test_swap_function( T const* )
// //
// Tests whether the optional<T>::swap member function works properly. // Tests whether the optional<T>::swap member function works properly.
// Assumes that T has one data member, of type char. // Assumes that T has one data member, of type char.
// Returns true iff the test is passed. // Returns true iff the test is passed.
// //
template <class T> template <class T>
@ -1263,33 +1263,6 @@ void test_swap_tweaking()
BOOST_CHECK( test_swap_member_function( ARG(optional_swap_test::template_whose_default_ctor_should_be_used<char>) ) ); BOOST_CHECK( test_swap_member_function( ARG(optional_swap_test::template_whose_default_ctor_should_be_used<char>) ) );
} }
// Test for support for classes with overridden operator&
class CustomAddressOfClass
{
int n;
public:
CustomAddressOfClass() : n(0) {}
CustomAddressOfClass(CustomAddressOfClass const& that) : n(that.n) {}
explicit CustomAddressOfClass(int m) : n(m) {}
int* operator& () { return &n; }
bool operator== (CustomAddressOfClass const& that) const { return n == that.n; }
};
void test_custom_addressof_operator()
{
boost::optional< CustomAddressOfClass > o1(CustomAddressOfClass(10));
BOOST_CHECK(!!o1);
BOOST_CHECK(o1.get() == CustomAddressOfClass(10));
o1 = CustomAddressOfClass(20);
BOOST_CHECK(!!o1);
BOOST_CHECK(o1.get() == CustomAddressOfClass(20));
o1 = boost::none;
BOOST_CHECK(!o1);
}
int test_main( int, char* [] ) int test_main( int, char* [] )
{ {
try try
@ -1300,7 +1273,6 @@ int test_main( int, char* [] )
test_conversions1(); test_conversions1();
test_conversions2(); test_conversions2();
test_swap_tweaking(); test_swap_tweaking();
test_custom_addressof_operator();
} }
catch ( ... ) catch ( ... )
{ {

View File

@ -55,14 +55,10 @@ void test2( Opt o, Opt buff )
{ {
stringstream s ; stringstream s ;
const int markv = 123 ; s << o ;
int mark = 0 ; s >> buff ;
s << o << " " << markv ;
s >> buff >> mark ;
BOOST_ASSERT( buff == o ) ; BOOST_ASSERT( buff == o ) ;
BOOST_ASSERT( mark == markv ) ;
} }
@ -81,6 +77,7 @@ int test_main( int, char* [] )
{ {
test(1,2); test(1,2);
test(string("hello"),string("buffer")); test(string("hello"),string("buffer"));
test(string(""),string("buffer"));
} }
catch ( ... ) catch ( ... )
{ {