boostorg/system
1
0
Fork 1
mirror of https://github.com/boostorg/system.git synced 2025-07-31 04:57:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Mark error_condition::failed, error_condition::message as deprecated; revert op bool"

Browse Source 
This reverts commit 329e72fb92.
This commit is contained in:
Peter Dimov
2021-06-13 04:56:18 +03:00
parent 88f7c2bf53
commit 610d5f3f78
2 changed files with 17 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
include/boost/system/detail/error_condition.hpp
View File

@ -45,6 +45,7 @@ class error_condition
private: private:
int val_; int val_;
bool failed_;
error_category const * cat_; error_category const * cat_;
public: public:
@ -52,12 +53,12 @@ public:
// constructors: // constructors:
BOOST_SYSTEM_CONSTEXPR error_condition() BOOST_NOEXCEPT: BOOST_SYSTEM_CONSTEXPR error_condition() BOOST_NOEXCEPT:
val_( 0 ), cat_( 0 ) val_( 0 ), failed_( false ), cat_( 0 )
{ {
} }
BOOST_SYSTEM_CONSTEXPR error_condition( int val, const error_category & cat ) BOOST_NOEXCEPT: BOOST_SYSTEM_CONSTEXPR error_condition( int val, const error_category & cat ) BOOST_NOEXCEPT:
val_( val ), cat_( &cat ) val_( val ), failed_( detail::failed_impl( val, cat ) ), cat_( &cat )
{ {
} }
@ -85,6 +86,7 @@ public:
BOOST_SYSTEM_CONSTEXPR void assign( int val, const error_category & cat ) BOOST_NOEXCEPT BOOST_SYSTEM_CONSTEXPR void assign( int val, const error_category & cat ) BOOST_NOEXCEPT
{ {
val_ = val; val_ = val;
failed_ = detail::failed_impl( val, cat );
cat_ = &cat; cat_ = &cat;
} }
@ -99,6 +101,7 @@ public:
BOOST_SYSTEM_CONSTEXPR void clear() BOOST_NOEXCEPT BOOST_SYSTEM_CONSTEXPR void clear() BOOST_NOEXCEPT
{ {
val_ = 0; val_ = 0;
failed_ = false;
cat_ = 0; cat_ = 0;
} }
@ -140,21 +143,14 @@ public:
BOOST_SYSTEM_CONSTEXPR bool failed() const BOOST_NOEXCEPT BOOST_SYSTEM_CONSTEXPR bool failed() const BOOST_NOEXCEPT
{ {
if( cat_ ) return failed_;
{
return detail::failed_impl( val_, *cat_ );
}
else
{
return val_ != 0;
}
} }
#if !defined(BOOST_NO_CXX11_EXPLICIT_CONVERSION_OPERATORS) #if !defined(BOOST_NO_CXX11_EXPLICIT_CONVERSION_OPERATORS)
BOOST_SYSTEM_CONSTEXPR explicit operator bool() const BOOST_NOEXCEPT // true if error BOOST_SYSTEM_CONSTEXPR explicit operator bool() const BOOST_NOEXCEPT // true if error
{ {
return failed(); return failed_;
} }
#else #else
@ -164,12 +160,12 @@ public:
BOOST_SYSTEM_CONSTEXPR operator unspecified_bool_type() const BOOST_NOEXCEPT // true if error BOOST_SYSTEM_CONSTEXPR operator unspecified_bool_type() const BOOST_NOEXCEPT // true if error
{ {
return failed()? unspecified_bool_true: 0; return failed_? unspecified_bool_true: 0;
} }
BOOST_SYSTEM_CONSTEXPR bool operator!() const BOOST_NOEXCEPT // true if no error BOOST_SYSTEM_CONSTEXPR bool operator!() const BOOST_NOEXCEPT // true if no error
{ {
return !failed(); return !failed_;
} }
#endif #endif

30
test/failed_test.cpp
View File

@ -120,30 +120,18 @@ template<class Ec> void test()
ec.assign( 0, generic_category() ); ec.assign( 0, generic_category() );
TEST_NOT_FAILED( ec ); TEST_NOT_FAILED( ec );
} }
}
template<class Ec> void test2() {
{ Ec ec( 0, http_category() );
Ec ec( 0, http_category() ); TEST_FAILED( ec );
TEST_FAILED( ec );
ec.assign( 200, http_category() ); ec.assign( 200, http_category() );
TEST_NOT_FAILED( ec ); TEST_NOT_FAILED( ec );
ec = Ec( 404, http_category() ); ec = Ec( 404, http_category() );
TEST_FAILED( ec ); TEST_FAILED( ec );
} }
template<class Ec> void test3()
{
Ec ec( 0, http_category() );
BOOST_TEST( ec.failed() );
ec.assign( 200, http_category() );
BOOST_TEST( !ec.failed() );
ec = Ec( 404, http_category() );
BOOST_TEST( ec.failed() );
} }
int main() int main()
@ -159,9 +147,7 @@ int main()
BOOST_TEST( http_category().failed( 404 ) ); BOOST_TEST( http_category().failed( 404 ) );
test<error_code>(); test<error_code>();
test2<error_code>();
test<error_condition>(); test<error_condition>();
test3<error_condition>();
{ {
error_condition ec( errc::success ); error_condition ec( errc::success );