Merge pull request #28 from Flamefire/patch-1

Fix node 20 issue on GHA CI
Install xz
2025-07-28 11:47:21 +02:00 · 2024-12-09 21:35:46 +08:00 · 2024-12-08 20:57:33 +01:00 · 2024-12-08 20:42:48 +01:00 · 2024-12-08 14:43:38 +01:00 · 2024-12-08 13:11:28 +01:00
1 changed files with 15 additions and 20 deletions
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@ -67,8 +67,7 @@ jobs:
            address-model: 32,64
          - toolset: gcc-13
            cxxstd: "03,11,14,17,20,2b"
-            os: ubuntu-latest
-            container: ubuntu:23.04
+            os: ubuntu-24.04
            install: g++-13-multilib
            address-model: 32,64
          - toolset: gcc-14
@ -145,14 +144,12 @@ jobs:
          - toolset: clang
            compiler: clang++-16
            cxxstd: "03,11,14,17,20,2b"
-            container: ubuntu:23.04
-            os: ubuntu-latest
+            os: ubuntu-24.04
            install: clang-16
          - toolset: clang
            compiler: clang++-17
            cxxstd: "03,11,14,17,20,2b"
-            container: ubuntu:23.10
-            os: ubuntu-latest
+            os: ubuntu-24.04
            install: clang-17
          - toolset: clang
            compiler: clang++-18
@ -160,9 +157,6 @@ jobs:
            container: ubuntu:24.04
            os: ubuntu-latest
            install: clang-18
-          - toolset: clang
-            cxxstd: "03,11,14,17,20,2b"
-            os: macos-12
          - toolset: clang
            cxxstd: "03,11,14,17,20,2b"
            os: macos-13
@ -171,24 +165,28 @@ jobs:
            os: macos-14

    runs-on: ${{matrix.os}}
-    container: ${{matrix.container}}
+    container:
+      image: ${{matrix.container}}
+      volumes:
+        - /node20217:/node20217:rw,rshared
+        - ${{ startsWith(matrix.container, 'ubuntu:1') && '/node20217:/__e/node20:ro,rshared' || ' ' }}

    defaults:
      run:
        shell: bash

    steps:
-      - name: Enable Node 16
-        run: |
-          echo "ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true" >> $GITHUB_ENV
-
-      - uses: actions/checkout@v3
-
      - name: Setup container environment
        if: matrix.container
        run: |
          apt-get update
-          apt-get -y install sudo python3 git g++
+          apt-get -y install sudo python3 git g++ curl xz-utils
+          if [[ "${{matrix.container}}" == "ubuntu:1"* ]]; then
+            # Node 20 doesn't work with Ubuntu 16/18  glibc: https://github.com/actions/checkout/issues/1590
+            curl -sL https://archives.boost.io/misc/node/node-v20.9.0-linux-x64-glibc-217.tar.xz | tar -xJ --strip-components 1 -C /node20217
+          fi
+
+      - uses: actions/checkout@v4

      - name: Install packages
        if: matrix.install
@ -295,7 +293,6 @@ jobs:
        include:
          - os: ubuntu-20.04
          - os: ubuntu-22.04
-          - os: macos-12
          - os: macos-13
          - os: macos-14

@ -343,7 +340,6 @@ jobs:
        include:
          - os: ubuntu-20.04
          - os: ubuntu-22.04
-          - os: macos-12
          - os: macos-13
          - os: macos-14

@ -401,7 +397,6 @@ jobs:
        include:
          - os: ubuntu-20.04
          - os: ubuntu-22.04
-          - os: macos-12
          - os: macos-13
          - os: macos-14
Author	SHA1	Message	Date
Joel de Guzman	f8bc34da9a	Merge pull request #28 from Flamefire/patch-1 Fix node 20 issue on GHA CI	2024-12-09 21:35:46 +08:00
Alexander Grund	0b71c6e21d	Install xz	2024-12-08 20:57:33 +01:00
Alexander Grund	8d24ab76bf	Remove macos-12 from GHA	2024-12-08 20:42:48 +01:00
Alexander Grund	fb0b1df64e	Update containers	2024-12-08 14:43:38 +01:00
Alexander Grund	b45bfadd63	Use hosted node	2024-12-08 13:11:28 +01:00
Alexander Grund	df21131b10	Fix node 20 issue on GHA CI	2024-12-07 19:42:53 +01:00