From 1c31fee575376dee0c3622c5e57e5891ae7067ff Mon Sep 17 00:00:00 2001 From: Andrey Semashev Date: Sat, 18 Feb 2023 18:55:54 +0300 Subject: [PATCH 1/3] Extracted C++11 implementation of is_nothrow_swappable to a separate header. Also modified the implementation to avoid referencing any potential swap overloads in namespace boost, unless these overloads are found by ADL. Added tests to verify is_nothrow_swappable works with ADL. --- .../detail/is_swappable_cxx_11.hpp | 37 +++++++++ .../type_traits/is_nothrow_swappable.hpp | 25 +----- test/is_nothrow_swappable_test.cpp | 78 +++++++++++++++++-- 3 files changed, 111 insertions(+), 29 deletions(-) create mode 100644 include/boost/type_traits/detail/is_swappable_cxx_11.hpp diff --git a/include/boost/type_traits/detail/is_swappable_cxx_11.hpp b/include/boost/type_traits/detail/is_swappable_cxx_11.hpp new file mode 100644 index 0000000..be22d1c --- /dev/null +++ b/include/boost/type_traits/detail/is_swappable_cxx_11.hpp @@ -0,0 +1,37 @@ +#ifndef BOOST_TYPE_TRAITS_DETAIL_IS_SWAPPABLE_CXX_11_HPP_INCLUDED +#define BOOST_TYPE_TRAITS_DETAIL_IS_SWAPPABLE_CXX_11_HPP_INCLUDED + +// Copyright 2017 Peter Dimov +// +// Distributed under the Boost Software License, Version 1.0. +// See accompanying file LICENSE_1_0.txt or copy at +// http://www.boost.org/LICENSE_1_0.txt + +#include +#include +#include +#if __cplusplus >= 201103L || defined(BOOST_DINKUMWARE_STDLIB) +#include // for std::swap (C++11) +#else +#include // for std::swap (C++98) +#endif + +// Intentionally not within boost namespace to avoid implicitly pulling in boost::swap overloads other than through ADL +namespace boost_type_traits_swappable_detail +{ + +using std::swap; + +template(), boost::declval()))> boost::integral_constant is_nothrow_swappable_with_impl( int ); +template boost::false_type is_nothrow_swappable_with_impl( ... ); +template +struct is_nothrow_swappable_with_helper { typedef decltype( boost_type_traits_swappable_detail::is_nothrow_swappable_with_impl(0) ) type; }; + +template(), boost::declval()))> boost::integral_constant is_nothrow_swappable_impl( int ); +template boost::false_type is_nothrow_swappable_impl( ... ); +template +struct is_nothrow_swappable_helper { typedef decltype( boost_type_traits_swappable_detail::is_nothrow_swappable_impl(0) ) type; }; + +} // namespace boost_type_traits_swappable_detail + +#endif // #ifndef BOOST_TYPE_TRAITS_DETAIL_IS_SWAPPABLE_CXX_11_HPP_INCLUDED diff --git a/include/boost/type_traits/is_nothrow_swappable.hpp b/include/boost/type_traits/is_nothrow_swappable.hpp index 10ad923..fc319f7 100644 --- a/include/boost/type_traits/is_nothrow_swappable.hpp +++ b/include/boost/type_traits/is_nothrow_swappable.hpp @@ -28,35 +28,16 @@ template struct is_nothrow_swappable_with : is_nothrow_swappable #else -#include -#include -#include +#include namespace boost { -namespace type_traits_swappable_detail -{ - -using std::swap; - -template(), declval()))> integral_constant is_nothrow_swappable_with_impl( int ); -template false_type is_nothrow_swappable_with_impl( ... ); -template -struct is_nothrow_swappable_with_helper { typedef decltype( type_traits_swappable_detail::is_nothrow_swappable_with_impl(0) ) type; }; - -template(), declval()))> integral_constant is_nothrow_swappable_impl( int ); -template false_type is_nothrow_swappable_impl( ... ); -template -struct is_nothrow_swappable_helper { typedef decltype( type_traits_swappable_detail::is_nothrow_swappable_impl(0) ) type; }; - -} // namespace type_traits_swappable_detail - -template struct is_nothrow_swappable_with: type_traits_swappable_detail::is_nothrow_swappable_with_helper::type +template struct is_nothrow_swappable_with: boost_type_traits_swappable_detail::is_nothrow_swappable_with_helper::type { }; -template struct is_nothrow_swappable: type_traits_swappable_detail::is_nothrow_swappable_helper::type +template struct is_nothrow_swappable: boost_type_traits_swappable_detail::is_nothrow_swappable_helper::type { }; diff --git a/test/is_nothrow_swappable_test.cpp b/test/is_nothrow_swappable_test.cpp index a230896..fafa526 100644 --- a/test/is_nothrow_swappable_test.cpp +++ b/test/is_nothrow_swappable_test.cpp @@ -1,4 +1,3 @@ - // Copyright 2017 Peter Dimov // // Distributed under the Boost Software License, Version 1.0. @@ -17,6 +16,13 @@ #include "check_integral_constant.hpp" #include +// These conditions should be similar to those in is_nothrow_swappable.hpp +#if defined(BOOST_NO_SFINAE_EXPR) || defined(BOOST_NO_CXX11_NOEXCEPT) || defined(BOOST_NO_CXX11_DECLTYPE) || defined(BOOST_NO_CXX11_FUNCTION_TEMPLATE_DEFAULT_ARGS) \ + || BOOST_WORKAROUND(BOOST_GCC, < 40700) \ + || (defined(__GLIBCXX__) && __GLIBCXX__ <= 20120301) // built-in clang++ -std=c++11 on Travis, w/ libstdc++ 4.6 +#define BOOST_TYPE_TRAITS_IS_NOTHROW_SWAPPABLE_EMULATED +#endif + struct X { }; @@ -45,6 +51,44 @@ struct U void swap(U&, U&) {} +#if !defined(BOOST_TYPE_TRAITS_IS_NOTHROW_SWAPPABLE_EMULATED) && !defined(BOOST_NO_CXX11_DELETED_FUNCTIONS) + +namespace test_ns { + +// Not swappable using std::swap, but swappable using test_ns::swap +struct only_adl_swappable +{ + only_adl_swappable(only_adl_swappable const&) = delete; + only_adl_swappable& operator= (only_adl_swappable const&) = delete; +}; + +inline void swap(only_adl_swappable&, only_adl_swappable&) BOOST_NOEXCEPT {} + +} // namespace test_ns + +namespace boost { +namespace type_traits_is_nothrow_swappable_test { + +// Some type that is defined within boost namespace and that has a specialized swap overload +struct swappable +{ + swappable(swappable const&) = delete; + swappable& operator= (swappable const&) = delete; +}; + +// This overload should be selected by is_nothrow_swappable +inline void swap(swappable&, swappable&) BOOST_NOEXCEPT {} + +} // namespace type_traits_is_nothrow_swappable_test + +// Some generic swap implementation, such as the one from Boost.Swap. This overload should *not* be selected by is_nothrow_swappable. +template< typename T1, typename T2 > +inline void swap(T1&, T2&) {} + +} // namespace boost + +#endif + TT_TEST_BEGIN(is_nothrow_swappable) BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, true); @@ -52,9 +96,7 @@ BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, fals BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, true); BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); -#if defined(BOOST_NO_SFINAE_EXPR) || defined(BOOST_NO_CXX11_NOEXCEPT) || defined(BOOST_NO_CXX11_DECLTYPE) || defined(BOOST_NO_CXX11_FUNCTION_TEMPLATE_DEFAULT_ARGS) \ - || BOOST_WORKAROUND(BOOST_GCC, < 40700)\ - || (defined(__GLIBCXX__) && __GLIBCXX__ <= 20120301) // built-in clang++ -std=c++11 on Travis, w/ libstdc++ 4.6 +#if defined(BOOST_TYPE_TRAITS_IS_NOTHROW_SWAPPABLE_EMULATED) BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); @@ -71,9 +113,7 @@ BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, fal BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); -#if defined(BOOST_NO_SFINAE_EXPR) || defined(BOOST_NO_CXX11_NOEXCEPT) || defined(BOOST_NO_CXX11_DECLTYPE) || defined(BOOST_NO_CXX11_FUNCTION_TEMPLATE_DEFAULT_ARGS) \ - || BOOST_WORKAROUND(BOOST_GCC, < 40700)\ - || (defined(__GLIBCXX__) && __GLIBCXX__ <= 20120301) // built-in clang++ -std=c++11 on Travis, w/ libstdc++ 4.6 +#if defined(BOOST_TYPE_TRAITS_IS_NOTHROW_SWAPPABLE_EMULATED) BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); @@ -157,6 +197,30 @@ BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_nothrow_swappable cons BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_nothrow_swappable volatile>::value), false); BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_nothrow_swappable const volatile>::value), false); +#if !defined(BOOST_NO_CXX11_DELETED_FUNCTIONS) + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_nothrow_swappable::value, false); + +#endif // !defined(BOOST_NO_CXX11_DELETED_FUNCTIONS) + #endif TT_TEST_END From fc61f298bf443ba5a782ad188ed8369ba0abb233 Mon Sep 17 00:00:00 2001 From: Andrey Semashev Date: Sat, 18 Feb 2023 19:56:56 +0300 Subject: [PATCH 2/3] Added is_swappable(_with) traits. --- doc/history.qbk | 6 +- doc/is_swappable.qbk | 26 ++ doc/type_traits.qbk | 2 + include/boost/type_traits.hpp | 1 + .../detail/is_swappable_cxx_11.hpp | 16 ++ include/boost/type_traits/is_swappable.hpp | 92 +++++++ test/Jamfile.v2 | 16 +- test/is_swappable_test.cpp | 231 ++++++++++++++++++ 8 files changed, 381 insertions(+), 9 deletions(-) create mode 100644 doc/is_swappable.qbk create mode 100644 include/boost/type_traits/is_swappable.hpp create mode 100644 test/is_swappable_test.cpp diff --git a/doc/history.qbk b/doc/history.qbk index 6d0def8..d2b277f 100644 --- a/doc/history.qbk +++ b/doc/history.qbk @@ -1,4 +1,4 @@ -[/ +[/ Copyright 2009 John Maddock. Distributed under the Boost Software License, Version 1.0. (See accompanying file LICENSE_1_0.txt or copy at @@ -7,6 +7,10 @@ [section:history History] +[h4 Boost-1.82.0] + +* Added __is_swappable trait. + [h4 Boost-1.70.0] * Added new traits __is_bounded_array, __is_unbounded_array, __copy_reference, __copy_cv_ref. diff --git a/doc/is_swappable.qbk b/doc/is_swappable.qbk new file mode 100644 index 0000000..3002b76 --- /dev/null +++ b/doc/is_swappable.qbk @@ -0,0 +1,26 @@ +[/ + Copyright 2023 Andrey Semashev + + Distributed under the Boost Software License, Version 1.0. + + (See accompanying file LICENSE_1_0.txt or copy at + http://www.boost.org/LICENSE_1_0.txt). +] + +[section:is_swappable is_swappable] + + template + struct is_swappable : public __tof {}; + +__inherit If the expression `swap(declval(), declval())` (in a context +where `std::swap` is visible) is valid, inherits from __true_type, otherwise from __false_type. + +__compat This trait requires C++11 for full support. On C++03 compilers it will inherit from __true_type +for scalar types (including integral, floating point, enumeration, pointer and pointer-to-member types) +and from __false_type for anything else. If MSVC standard library is used, C++17 +is required for full support. In this case, in C++11 and C++14 modes the trait will inherit from __true_type +for types that support move construction and move assignment and from __false_type for other types. + +__header ` #include ` or ` #include ` + +[endsect] diff --git a/doc/type_traits.qbk b/doc/type_traits.qbk index cdb181c..990503f 100644 --- a/doc/type_traits.qbk +++ b/doc/type_traits.qbk @@ -108,6 +108,7 @@ [def __is_nothrow_move_constructible [link boost_typetraits.reference.is_nothrow_move_constructible is_nothrow_move_constructible]] [def __has_nothrow_assign [link boost_typetraits.reference.has_nothrow_assign has_nothrow_assign]] [def __is_nothrow_move_assignable [link boost_typetraits.reference.is_nothrow_move_assignable is_nothrow_move_assignable]] +[def __is_swappable [link boost_typetraits.reference.is_swappable is_swappable]] [def __is_nothrow_swappable [link boost_typetraits.reference.is_nothrow_swappable is_nothrow_swappable]] [def __is_base_of [link boost_typetraits.reference.is_base_of is_base_of]] @@ -440,6 +441,7 @@ See __has_trivial_constructor. [include is_scoped_enum.qbk] [include is_signed.qbk] [include is_stateless.qbk] +[include is_swappable.qbk] [include is_trivially_copyable.qbk] [include is_unbounded_array.qbk] [include is_union.qbk] diff --git a/include/boost/type_traits.hpp b/include/boost/type_traits.hpp index a1c882e..f661baa 100644 --- a/include/boost/type_traits.hpp +++ b/include/boost/type_traits.hpp @@ -131,6 +131,7 @@ #include #include #include +#include #include #include #include diff --git a/include/boost/type_traits/detail/is_swappable_cxx_11.hpp b/include/boost/type_traits/detail/is_swappable_cxx_11.hpp index be22d1c..293210a 100644 --- a/include/boost/type_traits/detail/is_swappable_cxx_11.hpp +++ b/include/boost/type_traits/detail/is_swappable_cxx_11.hpp @@ -2,12 +2,14 @@ #define BOOST_TYPE_TRAITS_DETAIL_IS_SWAPPABLE_CXX_11_HPP_INCLUDED // Copyright 2017 Peter Dimov +// Copyright 2023 Andrey Semashev // // Distributed under the Boost Software License, Version 1.0. // See accompanying file LICENSE_1_0.txt or copy at // http://www.boost.org/LICENSE_1_0.txt #include +#include #include #include #if __cplusplus >= 201103L || defined(BOOST_DINKUMWARE_STDLIB) @@ -22,6 +24,18 @@ namespace boost_type_traits_swappable_detail using std::swap; +template(), boost::declval()))> boost::true_type is_swappable_with_impl( int ); +template boost::false_type is_swappable_with_impl( ... ); +template +struct is_swappable_with_helper { typedef decltype( boost_type_traits_swappable_detail::is_swappable_with_impl(0) ) type; }; + +template(), boost::declval()))> boost::true_type is_swappable_impl( int ); +template boost::false_type is_swappable_impl( ... ); +template +struct is_swappable_helper { typedef decltype( boost_type_traits_swappable_detail::is_swappable_impl(0) ) type; }; + +#if !defined(BOOST_NO_CXX11_NOEXCEPT) && !BOOST_WORKAROUND(BOOST_GCC, < 40700) + template(), boost::declval()))> boost::integral_constant is_nothrow_swappable_with_impl( int ); template boost::false_type is_nothrow_swappable_with_impl( ... ); template @@ -32,6 +46,8 @@ template boost::false_type is_nothrow_swappable_impl( ... ); template struct is_nothrow_swappable_helper { typedef decltype( boost_type_traits_swappable_detail::is_nothrow_swappable_impl(0) ) type; }; +#endif // !defined(BOOST_NO_CXX11_NOEXCEPT) && !BOOST_WORKAROUND(BOOST_GCC, < 40700) + } // namespace boost_type_traits_swappable_detail #endif // #ifndef BOOST_TYPE_TRAITS_DETAIL_IS_SWAPPABLE_CXX_11_HPP_INCLUDED diff --git a/include/boost/type_traits/is_swappable.hpp b/include/boost/type_traits/is_swappable.hpp new file mode 100644 index 0000000..ca0442f --- /dev/null +++ b/include/boost/type_traits/is_swappable.hpp @@ -0,0 +1,92 @@ +#ifndef BOOST_TYPE_TRAITS_IS_SWAPPABLE_HPP_INCLUDED +#define BOOST_TYPE_TRAITS_IS_SWAPPABLE_HPP_INCLUDED + +// Copyright 2023 Andrey Semashev +// +// Distributed under the Boost Software License, Version 1.0. +// See accompanying file LICENSE_1_0.txt or copy at +// http://www.boost.org/LICENSE_1_0.txt + +#include +#include + +#if !defined(BOOST_NO_SFINAE_EXPR) && !defined(BOOST_NO_CXX11_DECLTYPE) && !defined(BOOST_NO_CXX11_FUNCTION_TEMPLATE_DEFAULT_ARGS) && \ + !(defined(BOOST_DINKUMWARE_STDLIB) && (BOOST_CXX_VERSION < 201703L)) + +#include + +namespace boost +{ + +template struct is_swappable_with : boost_type_traits_swappable_detail::is_swappable_with_helper::type +{ +}; + +template struct is_swappable : boost_type_traits_swappable_detail::is_swappable_helper::type +{ +}; + +} // namespace boost + +#elif defined(BOOST_DINKUMWARE_STDLIB) && (BOOST_CXX_VERSION < 201703L) && \ + !defined(BOOST_NO_SFINAE_EXPR) && !defined(BOOST_NO_CXX11_DECLTYPE) && !defined(BOOST_NO_CXX11_FUNCTION_TEMPLATE_DEFAULT_ARGS) && !defined(BOOST_NO_CXX11_RVALUE_REFERENCES) && \ + !defined(BOOST_NO_CXX11_VARIADIC_TEMPLATES) && !BOOST_WORKAROUND(BOOST_MSVC, < 1800) // these are required for is_constructible and is_assignable + +// MSVC standard library has SFINAE-unfriendly std::swap in C++ modes prior to C++17, +// so we have to reproduce the restrictions on std::swap that are in effect in C++17 mode. + +#include +#include +#include +#include +#include +#include +#include +#include + +namespace boost +{ + +template struct is_swappable + : boost::conjunction< + boost::negation< boost::is_const >, + boost::is_constructible, + boost::is_assignable + >::type {}; + +template<> struct is_swappable : false_type {}; +template<> struct is_swappable : false_type {}; +template<> struct is_swappable : false_type {}; +template<> struct is_swappable : false_type {}; +template struct is_swappable : false_type {}; +template struct is_swappable : false_type {}; +template struct is_swappable : is_swappable {}; +template struct is_swappable : is_swappable {}; + +template struct is_swappable_with : boost_type_traits_swappable_detail::is_swappable_with_helper::type +{ +}; + +template struct is_swappable_with : is_swappable {}; + +} // namespace boost + +#else + +#include +#include + +namespace boost +{ + +template struct is_swappable : boost::is_scalar {}; +template struct is_swappable : false_type {}; + +template struct is_swappable_with : false_type {}; +template struct is_swappable_with : is_swappable {}; + +} // namespace boost + +#endif + +#endif // #ifndef BOOST_TYPE_TRAITS_IS_SWAPPABLE_HPP_INCLUDED diff --git a/test/Jamfile.v2 b/test/Jamfile.v2 index 727d66a..6fe0408 100644 --- a/test/Jamfile.v2 +++ b/test/Jamfile.v2 @@ -1,21 +1,21 @@ # copyright John Maddock 2004 -# Use, modification and distribution are subject to the -# Boost Software License, Version 1.0. (See accompanying file +# Use, modification and distribution are subject to the +# Boost Software License, Version 1.0. (See accompanying file # LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt) # bring in the rules for testing import testing ; import os ; -if [ os.environ CI ] +if [ os.environ CI ] { -CI_DEFINES = CI_SUPPRESS_KNOWN_ISSUES=1 ; + CI_DEFINES = CI_SUPPRESS_KNOWN_ISSUES=1 ; } # type_traits in V1 seem to have two modes: standalone, triggered # by a command line option, and a regular. For now, just imitate -# regular +# regular project : requirements # default to all warnings on: @@ -32,7 +32,7 @@ project : requirements msvc:on libs/tt2/light/include $(CI_DEFINES) -; +; rule all-tests { local result ; @@ -51,9 +51,9 @@ rule all-tests { { result += [ run $(source).cpp : : : BOOST_TT_DISABLE_INTRINSICS : $(source)_no_intrinsics ] ; } - return $(result) ; + return $(result) ; } - + test-suite type_traits : [ all-tests ] ; diff --git a/test/is_swappable_test.cpp b/test/is_swappable_test.cpp new file mode 100644 index 0000000..0a9f0cd --- /dev/null +++ b/test/is_swappable_test.cpp @@ -0,0 +1,231 @@ +// Copyright 2023 Andrey Semashev +// +// Distributed under the Boost Software License, Version 1.0. +// See accompanying file LICENSE_1_0.txt or copy at +// http://www.boost.org/LICENSE_1_0.txt + +#ifdef TEST_STD +# include +#else +# include +#endif + +#include + +#include "test.hpp" +#include "check_integral_constant.hpp" +#include + +// These conditions should be similar to those in is_swappable.hpp +#if defined(BOOST_DINKUMWARE_STDLIB) && (BOOST_CXX_VERSION < 201703L) && \ + !defined(BOOST_NO_SFINAE_EXPR) && !defined(BOOST_NO_CXX11_DECLTYPE) && !defined(BOOST_NO_CXX11_FUNCTION_TEMPLATE_DEFAULT_ARGS) && !defined(BOOST_NO_CXX11_RVALUE_REFERENCES) && \ + !defined(BOOST_NO_CXX11_VARIADIC_TEMPLATES) && !BOOST_WORKAROUND(BOOST_MSVC, < 1800) // these are required for is_constructible and is_assignable +#define BOOST_TYPE_TRAITS_IS_SWAPPABLE_MSVC_EMULATED +#elif defined(BOOST_NO_SFINAE_EXPR) || defined(BOOST_NO_CXX11_DECLTYPE) || defined(BOOST_NO_CXX11_FUNCTION_TEMPLATE_DEFAULT_ARGS) +#define BOOST_TYPE_TRAITS_IS_SWAPPABLE_CXX03_EMULATED +#endif + +struct X +{ +}; + +struct Y +{ + Y( Y const& ) {} +}; + +struct Z +{ + Z& operator=( Z const& ) { return *this; } +}; + +struct U +{ +}; + +void swap(U&, U&) {} + +#if !defined(BOOST_TYPE_TRAITS_IS_SWAPPABLE_CXX03_EMULATED) && !defined(BOOST_NO_CXX11_DELETED_FUNCTIONS) + +struct not_swappable +{ + not_swappable(not_swappable const&) = delete; + not_swappable& operator= (not_swappable const&) = delete; +}; + +namespace test_ns { + +// Not swappable using std::swap, but swappable using test_ns::swap +struct only_adl_swappable +{ + only_adl_swappable(only_adl_swappable const&) = delete; + only_adl_swappable& operator= (only_adl_swappable const&) = delete; +}; + +inline void swap(only_adl_swappable&, only_adl_swappable&) BOOST_NOEXCEPT {} + +} // namespace test_ns + +#endif + +TT_TEST_BEGIN(is_swappable) + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +#if defined(BOOST_TYPE_TRAITS_IS_SWAPPABLE_CXX03_EMULATED) +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +#else +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +#endif + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +#if defined(BOOST_TYPE_TRAITS_IS_SWAPPABLE_CXX03_EMULATED) + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable >::value), false); +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable const>::value), false); +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable volatile>::value), false); +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable const volatile>::value), false); + +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable >::value), false); +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable const>::value), false); +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable volatile>::value), false); +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable const volatile>::value), false); + +#else // defined(BOOST_TYPE_TRAITS_IS_SWAPPABLE_CXX03_EMULATED) + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable >::value), true); +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable const>::value), false); +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable volatile>::value), false); +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable const volatile>::value), false); + +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable >::value), true); +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable const>::value), false); +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable volatile>::value), false); +BOOST_CHECK_INTEGRAL_CONSTANT((::tt::is_swappable const volatile>::value), false); + +#endif // defined(BOOST_TYPE_TRAITS_IS_SWAPPABLE_CXX03_EMULATED) + +#if !defined(BOOST_TYPE_TRAITS_IS_SWAPPABLE_CXX03_EMULATED) && !defined(BOOST_NO_CXX11_DELETED_FUNCTIONS) + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +#if !defined(BOOST_TYPE_TRAITS_IS_SWAPPABLE_MSVC_EMULATED) + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, true); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +#else // !defined(BOOST_TYPE_TRAITS_IS_SWAPPABLE_MSVC_EMULATED) + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); +BOOST_CHECK_INTEGRAL_CONSTANT(::tt::is_swappable::value, false); + +#endif // !defined(BOOST_TYPE_TRAITS_IS_SWAPPABLE_MSVC_EMULATED) + +#endif // !defined(BOOST_TYPE_TRAITS_IS_SWAPPABLE_CXX03_EMULATED) && !defined(BOOST_NO_CXX11_DELETED_FUNCTIONS) + +TT_TEST_END From 5f43b228612f45a68705d691b482aeca7cf3f68c Mon Sep 17 00:00:00 2001 From: Andrey Semashev Date: Sat, 18 Feb 2023 19:58:36 +0300 Subject: [PATCH 3/3] Reuse is_swappable implementation in is_nothrow_swappable for gcc < 4.7. This avoids applying noexcept operator to a potentially invalid swap expression, which should resolve ICE with gcc 4.6. --- doc/history.qbk | 1 + .../detail/is_swappable_cxx_11.hpp | 21 +++++++++++++++++-- .../type_traits/is_nothrow_swappable.hpp | 3 +-- test/is_nothrow_swappable_test.cpp | 1 - 4 files changed, 21 insertions(+), 5 deletions(-) diff --git a/doc/history.qbk b/doc/history.qbk index d2b277f..ca412ba 100644 --- a/doc/history.qbk +++ b/doc/history.qbk @@ -10,6 +10,7 @@ [h4 Boost-1.82.0] * Added __is_swappable trait. +* Added a workaround for gcc 4.6 that allows __is_nothrow_swappable to work. [h4 Boost-1.70.0] diff --git a/include/boost/type_traits/detail/is_swappable_cxx_11.hpp b/include/boost/type_traits/detail/is_swappable_cxx_11.hpp index 293210a..390253c 100644 --- a/include/boost/type_traits/detail/is_swappable_cxx_11.hpp +++ b/include/boost/type_traits/detail/is_swappable_cxx_11.hpp @@ -34,7 +34,22 @@ template boost::false_type is_swappable_impl( ... ); template struct is_swappable_helper { typedef decltype( boost_type_traits_swappable_detail::is_swappable_impl(0) ) type; }; -#if !defined(BOOST_NO_CXX11_NOEXCEPT) && !BOOST_WORKAROUND(BOOST_GCC, < 40700) +#if !defined(BOOST_NO_CXX11_NOEXCEPT) + +#if BOOST_WORKAROUND(BOOST_GCC, < 40700) + +// gcc 4.6 ICEs when noexcept operator is used on an invalid expression +template::type::value> +struct is_nothrow_swappable_with_helper { typedef boost::false_type type; }; +template +struct is_nothrow_swappable_with_helper { typedef boost::integral_constant(), boost::declval()))> type; }; + +template::type::value> +struct is_nothrow_swappable_helper { typedef boost::false_type type; }; +template +struct is_nothrow_swappable_helper { typedef boost::integral_constant(), boost::declval()))> type; }; + +#else // BOOST_WORKAROUND(BOOST_GCC, < 40700) template(), boost::declval()))> boost::integral_constant is_nothrow_swappable_with_impl( int ); template boost::false_type is_nothrow_swappable_with_impl( ... ); @@ -46,7 +61,9 @@ template boost::false_type is_nothrow_swappable_impl( ... ); template struct is_nothrow_swappable_helper { typedef decltype( boost_type_traits_swappable_detail::is_nothrow_swappable_impl(0) ) type; }; -#endif // !defined(BOOST_NO_CXX11_NOEXCEPT) && !BOOST_WORKAROUND(BOOST_GCC, < 40700) +#endif // BOOST_WORKAROUND(BOOST_GCC, < 40700) + +#endif // !defined(BOOST_NO_CXX11_NOEXCEPT) } // namespace boost_type_traits_swappable_detail diff --git a/include/boost/type_traits/is_nothrow_swappable.hpp b/include/boost/type_traits/is_nothrow_swappable.hpp index fc319f7..1ab3dcd 100644 --- a/include/boost/type_traits/is_nothrow_swappable.hpp +++ b/include/boost/type_traits/is_nothrow_swappable.hpp @@ -8,10 +8,9 @@ // http://www.boost.org/LICENSE_1_0.txt #include -#include #if defined(BOOST_NO_SFINAE_EXPR) || defined(BOOST_NO_CXX11_NOEXCEPT) || defined(BOOST_NO_CXX11_DECLTYPE) \ - || defined(BOOST_NO_CXX11_FUNCTION_TEMPLATE_DEFAULT_ARGS) || BOOST_WORKAROUND(BOOST_GCC, < 40700) + || defined(BOOST_NO_CXX11_FUNCTION_TEMPLATE_DEFAULT_ARGS) #include #include diff --git a/test/is_nothrow_swappable_test.cpp b/test/is_nothrow_swappable_test.cpp index fafa526..ad49f95 100644 --- a/test/is_nothrow_swappable_test.cpp +++ b/test/is_nothrow_swappable_test.cpp @@ -18,7 +18,6 @@ // These conditions should be similar to those in is_nothrow_swappable.hpp #if defined(BOOST_NO_SFINAE_EXPR) || defined(BOOST_NO_CXX11_NOEXCEPT) || defined(BOOST_NO_CXX11_DECLTYPE) || defined(BOOST_NO_CXX11_FUNCTION_TEMPLATE_DEFAULT_ARGS) \ - || BOOST_WORKAROUND(BOOST_GCC, < 40700) \ || (defined(__GLIBCXX__) && __GLIBCXX__ <= 20120301) // built-in clang++ -std=c++11 on Travis, w/ libstdc++ 4.6 #define BOOST_TYPE_TRAITS_IS_NOTHROW_SWAPPABLE_EMULATED #endif