diff --git a/include/boost/unordered/detail/emplace_args.hpp b/include/boost/unordered/detail/emplace_args.hpp index d9e5dad7..0e80d3c0 100644 --- a/include/boost/unordered/detail/emplace_args.hpp +++ b/include/boost/unordered/detail/emplace_args.hpp @@ -40,20 +40,7 @@ #if !defined(BOOST_NO_RVALUE_REFERENCES) && \ !defined(BOOST_NO_VARIADIC_TEMPLATES) -# if defined(__SGI_STL_PORT) || defined(_STLPORT_VERSION) -# elif defined(__STD_RWCOMPILER_H__) || defined(_RWSTD_VER) -# elif defined(_LIBCPP_VERSION) -# define BOOST_UNORDERED_STD_FORWARD_MOVE -# elif defined(__GLIBCPP__) || defined(__GLIBCXX__) -# if defined(__GLIBCXX__) && __GLIBCXX__ >= 20090804 -# define BOOST_UNORDERED_STD_FORWARD_MOVE -# endif -# elif defined(__STL_CONFIG_H) -# elif defined(__MSL_CPP__) -# elif defined(__IBMCPP__) -# elif defined(MSIPL_COMPILE_H) -# elif (defined(_YVALS) && !defined(__IBMCPP__)) || defined(_CPPLIB_VER) -# endif +#define BOOST_UNORDERED_VARIADIC_MOVE #endif namespace boost { namespace unordered { namespace detail { @@ -64,11 +51,11 @@ namespace boost { namespace unordered { namespace detail { // Either forwarding variadic arguments, or storing the arguments in // emplace_args##n -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) #define BOOST_UNORDERED_EMPLACE_TEMPLATE typename... Args #define BOOST_UNORDERED_EMPLACE_ARGS Args&&... args -#define BOOST_UNORDERED_EMPLACE_FORWARD std::forward(args)... +#define BOOST_UNORDERED_EMPLACE_FORWARD boost::forward(args)... #else @@ -302,7 +289,7 @@ BOOST_UNORDERED_CONSTRUCT_FROM_TUPLE(10, std) #endif -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) //////////////////////////////////////////////////////////////////////////// // Construct from variadic parameters @@ -310,7 +297,7 @@ BOOST_UNORDERED_CONSTRUCT_FROM_TUPLE(10, std) template inline void construct_impl(T* address, Args&&... args) { - new((void*) address) T(std::forward(args)...); + new((void*) address) T(boost::forward(args)...); } template @@ -329,7 +316,7 @@ BOOST_UNORDERED_CONSTRUCT_FROM_TUPLE(10, std) inline typename enable_if, void>::type construct_impl(std::pair* address, A0&& a0) { - new((void*) boost::addressof(address->first)) A(std::forward(a0)); + new((void*) boost::addressof(address->first)) A(boost::forward(a0)); new((void*) boost::addressof(address->second)) B(); } @@ -337,10 +324,10 @@ BOOST_UNORDERED_CONSTRUCT_FROM_TUPLE(10, std) inline typename enable_if, void>::type construct_impl(std::pair* address, A0&& a0, A1&& a1, A2&& a2) { - new((void*) boost::addressof(address->first)) A(std::forward(a0)); + new((void*) boost::addressof(address->first)) A(boost::forward(a0)); new((void*) boost::addressof(address->second)) B( - std::forward(a1), - std::forward(a2)); + boost::forward(a1), + boost::forward(a2)); } template * address, A0&& a0, A1&& a1, A2&& a2, A3&& a3, Args&&... args) { - new((void*) boost::addressof(address->first)) A(std::forward(a0)); + new((void*) boost::addressof(address->first)) A(boost::forward(a0)); new((void*) boost::addressof(address->second)) B( - std::forward(a1), - std::forward(a2), - std::forward(a3), - std::forward(args)...); + boost::forward(a1), + boost::forward(a2), + boost::forward(a3), + boost::forward(args)...); } #endif // BOOST_UNORDERED_DEPRECATED_PAIR_CONSTRUCT -#else // BOOST_UNORDERED_STD_FORWARD_MOVE +#else // BOOST_UNORDERED_VARIADIC_MOVE //////////////////////////////////////////////////////////////////////////////// // Construct from emplace_args @@ -471,7 +458,7 @@ BOOST_UNORDERED_CONSTRUCT_FROM_TUPLE(10, std) #undef BOOST_UNORDERED_CALL_FORWARD2 #endif // BOOST_UNORDERED_DEPRECATED_PAIR_CONSTRUCT -#endif // BOOST_UNORDERED_STD_FORWARD_MOVE +#endif // BOOST_UNORDERED_VARIADIC_MOVE //////////////////////////////////////////////////////////////////////////// // Construct without using the emplace args mechanism. diff --git a/include/boost/unordered/detail/extract_key.hpp b/include/boost/unordered/detail/extract_key.hpp index ab0d0cd0..6cc4a23e 100644 --- a/include/boost/unordered/detail/extract_key.hpp +++ b/include/boost/unordered/detail/extract_key.hpp @@ -63,7 +63,7 @@ namespace detail { return no_key(); } -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) template static no_key extract(Args const&...) { @@ -126,7 +126,7 @@ namespace detail { return v.first; } -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) template static key_type const& extract(key_type const& k, Arg1 const&, Args const&...) @@ -165,7 +165,7 @@ namespace detail { } #endif -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) #define BOOST_UNORDERED_KEY_FROM_TUPLE(namespace_) \ template \ diff --git a/include/boost/unordered/detail/unique.hpp b/include/boost/unordered/detail/unique.hpp index 58740fe9..9c049f78 100644 --- a/include/boost/unordered/detail/unique.hpp +++ b/include/boost/unordered/detail/unique.hpp @@ -337,7 +337,7 @@ namespace boost { namespace unordered { namespace detail { // exception (need strong safety in such a case). node_constructor a(this->node_alloc()); a.construct_node(); -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) a.construct_value(boost::unordered::piecewise_construct, boost::make_tuple(k), boost::make_tuple()); #else @@ -364,7 +364,7 @@ namespace boost { namespace unordered { namespace detail { template emplace_return emplace(BOOST_UNORDERED_EMPLACE_ARGS) { -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) return emplace_impl( extractor::extract(BOOST_UNORDERED_EMPLACE_FORWARD), BOOST_UNORDERED_EMPLACE_FORWARD); @@ -376,7 +376,7 @@ namespace boost { namespace unordered { namespace detail { #endif } -#if !defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if !defined(BOOST_UNORDERED_VARIADIC_MOVE) template emplace_return emplace( boost::unordered::detail::emplace_args1 const& args) diff --git a/include/boost/unordered/unordered_map.hpp b/include/boost/unordered/unordered_map.hpp index c001533f..1a7ff151 100644 --- a/include/boost/unordered/unordered_map.hpp +++ b/include/boost/unordered/unordered_map.hpp @@ -233,17 +233,17 @@ namespace unordered // emplace -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) template std::pair emplace(Args&&... args) { - return table_.emplace(std::forward(args)...); + return table_.emplace(boost::forward(args)...); } template iterator emplace_hint(const_iterator, Args&&... args) { - return table_.emplace(std::forward(args)...).first; + return table_.emplace(boost::forward(args)...).first; } #else @@ -718,17 +718,17 @@ namespace unordered // emplace -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) template iterator emplace(Args&&... args) { - return table_.emplace(std::forward(args)...); + return table_.emplace(boost::forward(args)...); } template iterator emplace_hint(const_iterator, Args&&... args) { - return table_.emplace(std::forward(args)...); + return table_.emplace(boost::forward(args)...); } #else diff --git a/include/boost/unordered/unordered_set.hpp b/include/boost/unordered/unordered_set.hpp index a0da2093..384769dd 100644 --- a/include/boost/unordered/unordered_set.hpp +++ b/include/boost/unordered/unordered_set.hpp @@ -231,17 +231,17 @@ namespace unordered // emplace -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) template std::pair emplace(Args&&... args) { - return table_.emplace(std::forward(args)...); + return table_.emplace(boost::forward(args)...); } template iterator emplace_hint(const_iterator, Args&&... args) { - return table_.emplace(std::forward(args)...).first; + return table_.emplace(boost::forward(args)...).first; } #else @@ -702,17 +702,17 @@ namespace unordered // emplace -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) template iterator emplace(Args&&... args) { - return table_.emplace(std::forward(args)...); + return table_.emplace(boost::forward(args)...); } template iterator emplace_hint(const_iterator, Args&&... args) { - return table_.emplace(std::forward(args)...); + return table_.emplace(boost::forward(args)...); } #else diff --git a/test/objects/cxx11_allocator.hpp b/test/objects/cxx11_allocator.hpp index bb51713a..c24c57cc 100644 --- a/test/objects/cxx11_allocator.hpp +++ b/test/objects/cxx11_allocator.hpp @@ -168,10 +168,10 @@ namespace test new(p) T(t); } -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) template void construct(T* p, Args&&... args) { detail::tracker.track_construct((void*) p, sizeof(T), tag_); - new(p) T(std::forward(args)...); + new(p) T(boost::forward(args)...); } #endif diff --git a/test/objects/exception.hpp b/test/objects/exception.hpp index 51123026..3b3c105e 100644 --- a/test/objects/exception.hpp +++ b/test/objects/exception.hpp @@ -357,11 +357,11 @@ namespace exception detail::tracker.track_construct((void*) p, sizeof(T), tag_); } -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) template void construct(T* p, Args&&... args) { UNORDERED_SCOPE(allocator::construct(pointer, Args&&...)) { UNORDERED_EPOINT("Mock allocator construct function."); - new(p) T(std::forward(args)...); + new(p) T(boost::forward(args)...); } detail::tracker.track_construct((void*) p, sizeof(T), tag_); } diff --git a/test/objects/minimal.hpp b/test/objects/minimal.hpp index 5b7ae246..4c7118b6 100644 --- a/test/objects/minimal.hpp +++ b/test/objects/minimal.hpp @@ -367,9 +367,9 @@ namespace minimal void construct(T* p, T const& t) { new((void*)p) T(t); } -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) template void construct(T* p, Args&&... args) { - new((void*)p) T(std::forward(args)...); + new((void*)p) T(boost::forward(args)...); } #endif @@ -439,9 +439,9 @@ namespace minimal void construct(T* p, T const& t) { new((void*)p) T(t); } -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) template void construct(T* p, Args&&... args) { - new((void*)p) T(std::forward(args)...); + new((void*)p) T(boost::forward(args)...); } #endif diff --git a/test/objects/test.hpp b/test/objects/test.hpp index fc690c13..54e97a51 100644 --- a/test/objects/test.hpp +++ b/test/objects/test.hpp @@ -259,10 +259,10 @@ namespace test new(p) T(t); } -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) template void construct(T* p, Args&&... args) { detail::tracker.track_construct((void*) p, sizeof(T), tag_); - new(p) T(std::forward(args)...); + new(p) T(boost::forward(args)...); } #endif diff --git a/test/unordered/unnecessary_copy_tests.cpp b/test/unordered/unnecessary_copy_tests.cpp index a531a6ce..d9f85195 100644 --- a/test/unordered/unnecessary_copy_tests.cpp +++ b/test/unordered/unnecessary_copy_tests.cpp @@ -9,6 +9,23 @@ #include #include "../helpers/test.hpp" +#if defined(BOOST_UNORDERED_VARIADIC_MOVE) +# if defined(__SGI_STL_PORT) || defined(_STLPORT_VERSION) +# elif defined(__STD_RWCOMPILER_H__) || defined(_RWSTD_VER) +# elif defined(_LIBCPP_VERSION) +# define BOOST_UNORDERED_VARIADIC_MOVE +# elif defined(__GLIBCPP__) || defined(__GLIBCXX__) +# if defined(__GLIBCXX__) && __GLIBCXX__ >= 20090804 +# define BOOST_UNORDERED_VARIADIC_MOVE +# endif +# elif defined(__STL_CONFIG_H) +# elif defined(__MSL_CPP__) +# elif defined(__IBMCPP__) +# elif defined(MSIPL_COMPILE_H) +# elif (defined(_YVALS) && !defined(__IBMCPP__)) || defined(_CPPLIB_VER) +# endif +#endif + namespace unnecessary_copy_tests { struct count_copies @@ -243,9 +260,7 @@ namespace unnecessary_copy_tests // the existing element. reset(); x.emplace(); -#if defined(BOOST_UNORDERED_STD_FORWARD_MOVE) - COPY_COUNT(1); MOVE_COUNT(0); -#elif !defined(BOOST_NO_RVALUE_REFERENCES) +#if !defined(BOOST_NO_RVALUE_REFERENCES) // source_cost doesn't make much sense here, but it seems to fit. COPY_COUNT(1); MOVE_COUNT(source_cost); #else