From 3d952d3c0f712743f39f7d9627186e762c120183 Mon Sep 17 00:00:00 2001 From: Christian Mazakas Date: Wed, 23 Feb 2022 14:26:28 -0800 Subject: [PATCH] Add missing `[[nodiscard]]` qualifiers as outlined by C++20 --- include/boost/unordered/unordered_map.hpp | 15 ++++++++++++--- include/boost/unordered/unordered_set.hpp | 15 ++++++++++++--- 2 files changed, 24 insertions(+), 6 deletions(-) diff --git a/include/boost/unordered/unordered_map.hpp b/include/boost/unordered/unordered_map.hpp index a7815d87..0341d229 100644 --- a/include/boost/unordered/unordered_map.hpp +++ b/include/boost/unordered/unordered_map.hpp @@ -210,7 +210,10 @@ namespace boost { // size and capacity - bool empty() const BOOST_NOEXCEPT { return table_.size_ == 0; } + BOOST_ATTRIBUTE_NODISCARD bool empty() const BOOST_NOEXCEPT + { + return table_.size_ == 0; + } size_type size() const BOOST_NOEXCEPT { return table_.size_; } @@ -1177,7 +1180,10 @@ namespace boost { // size and capacity - bool empty() const BOOST_NOEXCEPT { return table_.size_ == 0; } + BOOST_ATTRIBUTE_NODISCARD bool empty() const BOOST_NOEXCEPT + { + return table_.size_ == 0; + } size_type size() const BOOST_NOEXCEPT { return table_.size_; } @@ -2705,7 +2711,10 @@ namespace boost { bool operator!() const BOOST_NOEXCEPT { return ptr_ ? 0 : 1; } - bool empty() const BOOST_NOEXCEPT { return ptr_ ? 0 : 1; } + BOOST_ATTRIBUTE_NODISCARD bool empty() const BOOST_NOEXCEPT + { + return ptr_ ? 0 : 1; + } void swap(node_handle_map& n) BOOST_NOEXCEPT_IF( value_allocator_traits::propagate_on_container_swap::value || diff --git a/include/boost/unordered/unordered_set.hpp b/include/boost/unordered/unordered_set.hpp index 57133eda..d7e0f99c 100644 --- a/include/boost/unordered/unordered_set.hpp +++ b/include/boost/unordered/unordered_set.hpp @@ -208,7 +208,10 @@ namespace boost { // size and capacity - bool empty() const BOOST_NOEXCEPT { return table_.size_ == 0; } + BOOST_ATTRIBUTE_NODISCARD bool empty() const BOOST_NOEXCEPT + { + return table_.size_ == 0; + } size_type size() const BOOST_NOEXCEPT { return table_.size_; } @@ -835,7 +838,10 @@ namespace boost { // size and capacity - bool empty() const BOOST_NOEXCEPT { return table_.size_ == 0; } + BOOST_ATTRIBUTE_NODISCARD bool empty() const BOOST_NOEXCEPT + { + return table_.size_ == 0; + } size_type size() const BOOST_NOEXCEPT { return table_.size_; } @@ -2169,7 +2175,10 @@ namespace boost { bool operator!() const BOOST_NOEXCEPT { return ptr_ ? 0 : 1; } - bool empty() const BOOST_NOEXCEPT { return ptr_ ? 0 : 1; } + BOOST_ATTRIBUTE_NODISCARD bool empty() const BOOST_NOEXCEPT + { + return ptr_ ? 0 : 1; + } void swap(node_handle_set& n) BOOST_NOEXCEPT_IF( value_allocator_traits::propagate_on_container_swap::value ||