boostorg/unordered
1
0
Fork 1
mirror of https://github.com/boostorg/unordered.git synced 2025-07-30 03:17:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Account for extra moves/copies when using Visual Age.

Browse Source
This commit is contained in:
Daniel James
2013-12-15 17:11:26 +00:00
parent 59c83ab942
commit 5995e5521f
1 changed files with 24 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
test/unordered/unnecessary_copy_tests.cpp
View File

@ -119,6 +119,20 @@ namespace unnecessary_copy_tests
} }
} }
// Boost.Move doesn't seem to work very well on this compiler.
// For example for:
//
// T x;
//
// It will default construct T, and then move it in.
// For 'T const' it seems to copy.
#if defined(__IBMCPP__) && __IBMCPP__ <= 1210
#define EXTRA_CONSTRUCT_COST 1
#else
#define EXTRA_CONSTRUCT_COST 0
#endif
#define COPY_COUNT(n) \ #define COPY_COUNT(n) \
if(::unnecessary_copy_tests::count_copies::copies != n) { \ if(::unnecessary_copy_tests::count_copies::copies != n) { \
BOOST_ERROR("Wrong number of copies."); \ BOOST_ERROR("Wrong number of copies."); \
@ -150,9 +164,13 @@ namespace unnecessary_copy_tests
BOOST_ERROR("Wrong number of moves."); \ BOOST_ERROR("Wrong number of moves."); \
std::cerr \ std::cerr \
<< "Number of moves: " \ << "Number of moves: " \
<< ::unnecessary_copy_tests::count_copies::copies \ << ::unnecessary_copy_tests::count_copies::moves \
<< " expecting: [" << a << ", " << b << "]" << std::endl; \ << " expecting: [" << a << ", " << b << "]" << std::endl; \
} }
#define COPY_COUNT_EXTRA(a, b) \
COPY_COUNT_RANGE(a, a + b * EXTRA_CONSTRUCT_COST)
#define MOVE_COUNT_EXTRA(a, b) \
MOVE_COUNT_RANGE(a, a + b * EXTRA_CONSTRUCT_COST)
namespace unnecessary_copy_tests namespace unnecessary_copy_tests
{ {
@ -229,7 +247,7 @@ namespace unnecessary_copy_tests
reset(); reset();
T x; T x;
BOOST_DEDUCED_TYPENAME T::value_type a; BOOST_DEDUCED_TYPENAME T::value_type a;
COPY_COUNT(1); MOVE_COUNT(0); COPY_COUNT(1); MOVE_COUNT_EXTRA(0, 1);
x.emplace(boost::move(a)); x.emplace(boost::move(a));
#if !defined(BOOST_NO_CXX11_RVALUE_REFERENCES) #if !defined(BOOST_NO_CXX11_RVALUE_REFERENCES)
COPY_COUNT(1); MOVE_COUNT(1); COPY_COUNT(1); MOVE_COUNT(1);
@ -263,10 +281,10 @@ namespace unnecessary_copy_tests
T x; T x;
COPY_COUNT(0); MOVE_COUNT(0); COPY_COUNT(0); MOVE_COUNT(0);
BOOST_DEDUCED_TYPENAME T::value_type a; BOOST_DEDUCED_TYPENAME T::value_type a;
COPY_COUNT(1); MOVE_COUNT(0); COPY_COUNT(1); MOVE_COUNT_EXTRA(0, 1);
x.emplace(boost::move(a)); x.emplace(boost::move(a));
#if defined(BOOST_NO_CXX11_RVALUE_REFERENCES) #if defined(BOOST_NO_CXX11_RVALUE_REFERENCES)
COPY_COUNT(2); MOVE_COUNT(0); COPY_COUNT(2); MOVE_COUNT_EXTRA(0, 1);
#else #else
COPY_COUNT(1); MOVE_COUNT(1); COPY_COUNT(1); MOVE_COUNT(1);
#endif #endif
@ -380,7 +398,7 @@ namespace unnecessary_copy_tests
// TODO: Run tests for pairs without const etc. // TODO: Run tests for pairs without const etc.
std::pair<count_copies const, count_copies> a; std::pair<count_copies const, count_copies> a;
x.emplace(a); x.emplace(a);
COPY_COUNT(4); MOVE_COUNT(0); COPY_COUNT_EXTRA(4, 1); MOVE_COUNT_EXTRA(0, 1);
// //
// 0 arguments // 0 arguments
@ -398,7 +416,7 @@ namespace unnecessary_copy_tests
// Visual C++ 11 handles calling move for default arguments. // Visual C++ 11 handles calling move for default arguments.
COPY_COUNT(3); MOVE_COUNT(1); COPY_COUNT(3); MOVE_COUNT(1);
# else # else
COPY_COUNT(2); MOVE_COUNT(0); COPY_COUNT_EXTRA(2, 1); MOVE_COUNT_EXTRA(0, 1);
# endif # endif
#endif #endif