boostorg/unordered
1
0
Fork 1
mirror of https://github.com/boostorg/unordered.git synced 2025-07-30 11:27:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update FOA move assignment operator to uphold the strong guarantee for Hash, KeyEqual

Browse Source
This commit is contained in:
Christian Mazakas
2022-12-01 15:51:22 -08:00
parent 2043f98593
commit c8910e8007
1 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
include/boost/unordered/detail/foa.hpp
View File

@ -1306,19 +1306,32 @@ public:
table& operator=(table&& x) table& operator=(table&& x)
noexcept( noexcept(
alloc_traits::is_always_equal::value&& alloc_traits::propagate_on_container_move_assignment::value||
std::is_nothrow_move_assignable<Hash>::value&& alloc_traits::is_always_equal::value)
std::is_nothrow_move_assignable<Pred>::value)
{ {
BOOST_UNORDERED_STATIC_ASSERT_HASH_PRED(Hash, Pred)
static constexpr auto pocma= static constexpr auto pocma=
alloc_traits::propagate_on_container_move_assignment::value; alloc_traits::propagate_on_container_move_assignment::value;
if(this!=std::addressof(x)){ if(this!=std::addressof(x)){
/* Given ambiguity in implementation strategies briefly discussed here:
* https://www.open-std.org/jtc1/sc22/wg21/docs/lwg-active.html#2227
*
* we opt into requiring nothrow swappability and eschew the move
* operations associated with Hash, Pred.
*
* To this end, we ensure that the user never has to consider the
* moved-from state of their Hash, Pred objects
*/
using std::swap;
clear(); clear();
h()=std::move(x.h()); swap(h(),x.h());
pred()=std::move(x.pred()); swap(pred(),x.pred());
if(pocma||al()==x.al()){ if(pocma||al()==x.al()){
using std::swap;
reserve(0); reserve(0);
move_assign_if<pocma>(al(),x.al()); move_assign_if<pocma>(al(),x.al());
swap(size_,x.size_); swap(size_,x.size_);