From 1b3f05628b428442f1502c81bdc236466b95e3f0 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Tue, 22 Jun 2021 14:01:06 +0200 Subject: [PATCH] Android: Remove check for missing game ID Now that DOL and ELF files are assigned game IDs, all games have game IDs. (Unless you intentionally craft an ISO file that has the first bytes set to null, but if you do that I think you can live with Dolphin creating a file in GameSettings called ".ini") --- .../dolphinemu/adapters/GameRowPresenter.java | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/adapters/GameRowPresenter.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/adapters/GameRowPresenter.java index aa600173f4..eda245408e 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/adapters/GameRowPresenter.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/adapters/GameRowPresenter.java @@ -88,20 +88,8 @@ public final class GameRowPresenter extends Presenter holder.cardParent.setOnLongClickListener((view) -> { FragmentActivity activity = (FragmentActivity) view.getContext(); - String gameId = gameFile.getGameId(); - - if (gameId.isEmpty()) - { - AlertDialog.Builder builder = new AlertDialog.Builder(activity, R.style.DolphinDialogBase); - builder.setTitle("Game Settings"); - builder.setMessage("Files without game IDs don't support game-specific settings."); - - builder.show(); - return true; - } - GamePropertiesDialog fragment = GamePropertiesDialog.newInstance(holder.gameFile); - ((FragmentActivity) view.getContext()).getSupportFragmentManager().beginTransaction() + activity.getSupportFragmentManager().beginTransaction() .add(fragment, GamePropertiesDialog.TAG).commit(); return true;