diff --git a/Source/Core/AudioCommon/WASAPIStream.h b/Source/Core/AudioCommon/WASAPIStream.h index 6f3218cc4b..dfe0974a8c 100644 --- a/Source/Core/AudioCommon/WASAPIStream.h +++ b/Source/Core/AudioCommon/WASAPIStream.h @@ -32,7 +32,7 @@ class WASAPIStream final : public SoundStream #ifdef _WIN32 public: explicit WASAPIStream(); - ~WASAPIStream(); + ~WASAPIStream() override; bool Init() override; bool SetRunning(bool running) override; diff --git a/Source/Core/Common/Assembler/GekkoIRGen.cpp b/Source/Core/Common/Assembler/GekkoIRGen.cpp index 6afda9cde6..7ca8edbf94 100644 --- a/Source/Core/Common/Assembler/GekkoIRGen.cpp +++ b/Source/Core/Common/Assembler/GekkoIRGen.cpp @@ -31,7 +31,7 @@ public: { m_active_block = &m_output_result.blocks.emplace_back(base_addr); } - virtual ~GekkoIRPlugin() = default; + ~GekkoIRPlugin() override = default; void OnDirectivePre(GekkoDirective directive) override; void OnDirectivePost(GekkoDirective directive) override; diff --git a/Source/Core/Common/Crypto/AES.cpp b/Source/Core/Common/Crypto/AES.cpp index e27e6659ad..e0ffa5591d 100644 --- a/Source/Core/Common/Crypto/AES.cpp +++ b/Source/Core/Common/Crypto/AES.cpp @@ -46,8 +46,7 @@ public: ASSERT(!mbedtls_aes_setkey_dec(&ctx, key, 128)); } - virtual bool Crypt(const u8* iv, u8* iv_out, const u8* buf_in, u8* buf_out, - size_t len) const override + bool Crypt(const u8* iv, u8* iv_out, const u8* buf_in, u8* buf_out, size_t len) const override { std::array iv_tmp{}; if (iv) @@ -206,8 +205,7 @@ public: _mm_storeu_si128(&((__m128i*)buf_out)[d], block[d]); } - virtual bool Crypt(const u8* iv, u8* iv_out, const u8* buf_in, u8* buf_out, - size_t len) const override + bool Crypt(const u8* iv, u8* iv_out, const u8* buf_in, u8* buf_out, size_t len) const override { if (len % BLOCK_SIZE) return false; diff --git a/Source/Core/Common/Crypto/SHA1.cpp b/Source/Core/Common/Crypto/SHA1.cpp index 2ebfd7a4c8..85ad54f75d 100644 --- a/Source/Core/Common/Crypto/SHA1.cpp +++ b/Source/Core/Common/Crypto/SHA1.cpp @@ -41,18 +41,18 @@ public: mbedtls_sha1_init(&ctx); ASSERT(!mbedtls_sha1_starts_ret(&ctx)); } - ~ContextMbed() { mbedtls_sha1_free(&ctx); } - virtual void Update(const u8* msg, size_t len) override + ~ContextMbed() override { mbedtls_sha1_free(&ctx); } + void Update(const u8* msg, size_t len) override { ASSERT(!mbedtls_sha1_update_ret(&ctx, msg, len)); } - virtual Digest Finish() override + Digest Finish() override { Digest digest; ASSERT(!mbedtls_sha1_finish_ret(&ctx, digest.data())); return digest; } - virtual bool HwAccelerated() const override { return false; } + bool HwAccelerated() const override { return false; } private: mbedtls_sha1_context ctx{}; @@ -204,7 +204,7 @@ private: } ATTRIBUTE_TARGET("sha") - virtual void ProcessBlock(const u8* msg) override + void ProcessBlock(const u8* msg) override { // There are 80 rounds with 4 bytes per round, giving 0x140 byte work space, but we can keep // active state in just 0x40 bytes. @@ -248,7 +248,7 @@ private: // clang-format on } - virtual Digest GetDigest() override + Digest GetDigest() override { Digest digest; _mm_storeu_si128((__m128i*)&digest[0], byterev_16B(state[0])); @@ -257,7 +257,7 @@ private: return digest; } - virtual bool HwAccelerated() const override { return true; } + bool HwAccelerated() const override { return true; } std::array state{}; }; diff --git a/Source/Core/Common/GL/GLInterface/WGL.h b/Source/Core/Common/GL/GLInterface/WGL.h index ad2b665028..2f5a81e075 100644 --- a/Source/Core/Common/GL/GLInterface/WGL.h +++ b/Source/Core/Common/GL/GLInterface/WGL.h @@ -10,9 +10,9 @@ class GLContextWGL final : public GLContext { public: - ~GLContextWGL(); + ~GLContextWGL() override; - bool IsHeadless() const; + bool IsHeadless() const override; std::unique_ptr CreateSharedContext() override; diff --git a/Source/Core/Common/HostDisassembler.cpp b/Source/Core/Common/HostDisassembler.cpp index 14dd3b5b46..14f4af0258 100644 --- a/Source/Core/Common/HostDisassembler.cpp +++ b/Source/Core/Common/HostDisassembler.cpp @@ -101,7 +101,7 @@ class HostDisassemblerBochs final : public HostDisassembler { public: explicit HostDisassemblerBochs(); - ~HostDisassemblerBochs() = default; + ~HostDisassemblerBochs() override = default; private: disassembler m_disasm; diff --git a/Source/Core/Common/Logging/ConsoleListener.h b/Source/Core/Common/Logging/ConsoleListener.h index 77924b3406..a242847765 100644 --- a/Source/Core/Common/Logging/ConsoleListener.h +++ b/Source/Core/Common/Logging/ConsoleListener.h @@ -9,7 +9,7 @@ class ConsoleListener : public Common::Log::LogListener { public: ConsoleListener(); - ~ConsoleListener(); + ~ConsoleListener() override; void Log(Common::Log::LogLevel level, const char* text) override; diff --git a/Source/Core/Core/Boot/DolReader.h b/Source/Core/Core/Boot/DolReader.h index 1ff37e352e..5ef8500610 100644 --- a/Source/Core/Core/Boot/DolReader.h +++ b/Source/Core/Core/Boot/DolReader.h @@ -20,7 +20,7 @@ public: explicit DolReader(const std::string& filename); explicit DolReader(File::IOFile file); explicit DolReader(std::vector buffer); - ~DolReader(); + ~DolReader() override; bool IsValid() const override { return m_is_valid; } bool IsWii() const override { return m_is_wii; } diff --git a/Source/Core/Core/Boot/ElfReader.h b/Source/Core/Core/Boot/ElfReader.h index 8ca84b54bb..83fd878012 100644 --- a/Source/Core/Core/Boot/ElfReader.h +++ b/Source/Core/Core/Boot/ElfReader.h @@ -28,7 +28,7 @@ public: explicit ElfReader(const std::string& filename); explicit ElfReader(File::IOFile file); explicit ElfReader(std::vector buffer); - ~ElfReader(); + ~ElfReader() override; u32 Read32(int off) const { return base32[off >> 2]; } // Quick accessors ElfType GetType() const { return (ElfType)(header->e_type); } diff --git a/Source/Core/Core/Debugger/OSThread.h b/Source/Core/Core/Debugger/OSThread.h index 1302b7838c..1cc9b40898 100644 --- a/Source/Core/Core/Debugger/OSThread.h +++ b/Source/Core/Core/Debugger/OSThread.h @@ -132,7 +132,7 @@ class OSThreadView : public Common::Debug::ThreadView { public: explicit OSThreadView(const Core::CPUThreadGuard& guard, u32 addr); - ~OSThreadView() = default; + ~OSThreadView() override = default; const OSThread& Data() const; diff --git a/Source/Core/Core/FifoPlayer/FifoPlayer.cpp b/Source/Core/Core/FifoPlayer/FifoPlayer.cpp index 8f6a54916e..bb1ae839f5 100644 --- a/Source/Core/Core/FifoPlayer/FifoPlayer.cpp +++ b/Source/Core/Core/FifoPlayer/FifoPlayer.cpp @@ -220,7 +220,7 @@ class FifoPlayer::CPUCore final : public CPUCoreBase public: explicit CPUCore(FifoPlayer* parent) : m_parent(parent) {} CPUCore(const CPUCore&) = delete; - ~CPUCore() {} + ~CPUCore() override {} CPUCore& operator=(const CPUCore&) = delete; void Init() override diff --git a/Source/Core/Core/HLE/HLE_VarArgs.h b/Source/Core/Core/HLE/HLE_VarArgs.h index aac61ef74b..a1c3eee7e9 100644 --- a/Source/Core/Core/HLE/HLE_VarArgs.h +++ b/Source/Core/Core/HLE/HLE_VarArgs.h @@ -157,7 +157,7 @@ class VAListStruct : public VAList { public: explicit VAListStruct(const Core::CPUThreadGuard& guard, u32 address); - ~VAListStruct() = default; + ~VAListStruct() override = default; private: struct svr4_va_list diff --git a/Source/Core/Core/HW/DSPHLE/DSPHLE.h b/Source/Core/Core/HW/DSPHLE/DSPHLE.h index a88c66052c..08b5c75e03 100644 --- a/Source/Core/Core/HW/DSPHLE/DSPHLE.h +++ b/Source/Core/Core/HW/DSPHLE/DSPHLE.h @@ -28,7 +28,7 @@ public: DSPHLE(DSPHLE&& other) = delete; DSPHLE& operator=(const DSPHLE& other) = delete; DSPHLE& operator=(DSPHLE&& other) = delete; - ~DSPHLE(); + ~DSPHLE() override; bool Initialize(bool wii, bool dsp_thread) override; void Shutdown() override; diff --git a/Source/Core/Core/HW/DSPHLE/UCodes/AESnd.h b/Source/Core/Core/HW/DSPHLE/UCodes/AESnd.h index 9aa8ffb1ad..fce8dfa7f9 100644 --- a/Source/Core/Core/HW/DSPHLE/UCodes/AESnd.h +++ b/Source/Core/Core/HW/DSPHLE/UCodes/AESnd.h @@ -27,7 +27,7 @@ public: AESndAccelerator(AESndAccelerator&&) = delete; AESndAccelerator& operator=(const AESndAccelerator&) = delete; AESndAccelerator& operator=(AESndAccelerator&&) = delete; - ~AESndAccelerator(); + ~AESndAccelerator() override; protected: void OnRawReadEndException() override {} diff --git a/Source/Core/Core/HW/DSPHLE/UCodes/AXVoice.h b/Source/Core/Core/HW/DSPHLE/UCodes/AXVoice.h index 502ab657ed..87c569a6e4 100644 --- a/Source/Core/Core/HW/DSPHLE/UCodes/AXVoice.h +++ b/Source/Core/Core/HW/DSPHLE/UCodes/AXVoice.h @@ -129,7 +129,7 @@ public: HLEAccelerator(HLEAccelerator&&) = delete; HLEAccelerator& operator=(const HLEAccelerator&) = delete; HLEAccelerator& operator=(HLEAccelerator&&) = delete; - ~HLEAccelerator() = default; + ~HLEAccelerator() override = default; PB_TYPE* acc_pb = nullptr; diff --git a/Source/Core/Core/HW/DSPLLE/DSPLLE.h b/Source/Core/Core/HW/DSPLLE/DSPLLE.h index 1d92aad81c..5796fd8fee 100644 --- a/Source/Core/Core/HW/DSPLLE/DSPLLE.h +++ b/Source/Core/Core/HW/DSPLLE/DSPLLE.h @@ -20,7 +20,7 @@ class DSPLLE : public DSPEmulator { public: DSPLLE(); - ~DSPLLE(); + ~DSPLLE() override; bool Initialize(bool wii, bool dsp_thread) override; void Shutdown() override; diff --git a/Source/Core/Core/HW/EXI/EXI_DeviceAGP.h b/Source/Core/Core/HW/EXI/EXI_DeviceAGP.h index 0729576075..da4e417eab 100644 --- a/Source/Core/Core/HW/EXI/EXI_DeviceAGP.h +++ b/Source/Core/Core/HW/EXI/EXI_DeviceAGP.h @@ -18,7 +18,7 @@ class CEXIAgp : public IEXIDevice { public: CEXIAgp(Core::System& system, const Slot slot); - virtual ~CEXIAgp() override; + ~CEXIAgp() override; bool IsPresent() const override { return true; } void ImmWrite(u32 _uData, u32 _uSize) override; u32 ImmRead(u32 _uSize) override; diff --git a/Source/Core/Core/HW/EXI/EXI_DeviceEthernet.h b/Source/Core/Core/HW/EXI/EXI_DeviceEthernet.h index 79c8828d4f..71849a5222 100644 --- a/Source/Core/Core/HW/EXI/EXI_DeviceEthernet.h +++ b/Source/Core/Core/HW/EXI/EXI_DeviceEthernet.h @@ -216,7 +216,7 @@ class CEXIETHERNET : public IEXIDevice { public: CEXIETHERNET(Core::System& system, BBADeviceType type); - virtual ~CEXIETHERNET(); + ~CEXIETHERNET() override; void SetCS(int cs) override; bool IsPresent() const override; bool IsInterruptSet() override; diff --git a/Source/Core/Core/HW/EXI/EXI_DeviceMic.h b/Source/Core/Core/HW/EXI/EXI_DeviceMic.h index 4836c80583..7f83da4f2a 100644 --- a/Source/Core/Core/HW/EXI/EXI_DeviceMic.h +++ b/Source/Core/Core/HW/EXI/EXI_DeviceMic.h @@ -18,7 +18,7 @@ class CEXIMic : public IEXIDevice { public: CEXIMic(Core::System& system, const int index); - virtual ~CEXIMic(); + ~CEXIMic() override; void SetCS(int cs) override; bool IsInterruptSet() override; bool IsPresent() const override; diff --git a/Source/Core/Core/HW/EXI/EXI_DeviceModem.h b/Source/Core/Core/HW/EXI/EXI_DeviceModem.h index 535bbc3638..5c2cd0b4a3 100644 --- a/Source/Core/Core/HW/EXI/EXI_DeviceModem.h +++ b/Source/Core/Core/HW/EXI/EXI_DeviceModem.h @@ -33,7 +33,7 @@ class CEXIModem : public IEXIDevice { public: CEXIModem(Core::System& system, ModemDeviceType type); - virtual ~CEXIModem(); + ~CEXIModem() override; void SetCS(int cs) override; bool IsPresent() const override; bool IsInterruptSet() override; @@ -136,13 +136,13 @@ private: TAPServerNetworkInterface(CEXIModem* modem_ref, const std::string& destination); public: - virtual bool Activate() override; - virtual void Deactivate() override; - virtual bool IsActivated() override; - virtual bool SendAndRemoveAllHDLCFrames(std::string* send_buffer) override; - virtual bool RecvInit() override; - virtual void RecvStart() override; - virtual void RecvStop() override; + bool Activate() override; + void Deactivate() override; + bool IsActivated() override; + bool SendAndRemoveAllHDLCFrames(std::string* send_buffer) override; + bool RecvInit() override; + void RecvStart() override; + void RecvStop() override; private: TAPServerConnection m_tapserver_if; diff --git a/Source/Core/Core/HW/GCMemcard/GCMemcardDirectory.h b/Source/Core/Core/HW/GCMemcard/GCMemcardDirectory.h index 7967c52670..7e53259a27 100644 --- a/Source/Core/Core/HW/GCMemcard/GCMemcardDirectory.h +++ b/Source/Core/Core/HW/GCMemcard/GCMemcardDirectory.h @@ -24,7 +24,7 @@ class GCMemcardDirectory : public MemoryCardBase public: GCMemcardDirectory(const std::string& directory, ExpansionInterface::Slot slot, const Memcard::HeaderData& header_data, u32 game_id); - ~GCMemcardDirectory(); + ~GCMemcardDirectory() override; GCMemcardDirectory(const GCMemcardDirectory&) = delete; GCMemcardDirectory& operator=(const GCMemcardDirectory&) = delete; diff --git a/Source/Core/Core/HW/GCMemcard/GCMemcardRaw.h b/Source/Core/Core/HW/GCMemcard/GCMemcardRaw.h index 08ab581caa..0c7ae75ee2 100644 --- a/Source/Core/Core/HW/GCMemcard/GCMemcardRaw.h +++ b/Source/Core/Core/HW/GCMemcard/GCMemcardRaw.h @@ -19,7 +19,7 @@ class MemoryCard : public MemoryCardBase public: MemoryCard(const std::string& filename, ExpansionInterface::Slot card_slot, u16 size_mbits = Memcard::MBIT_SIZE_MEMORY_CARD_2043); - ~MemoryCard(); + ~MemoryCard() override; void FlushThread(); void MakeDirty(); diff --git a/Source/Core/Core/HW/MMIO.cpp b/Source/Core/Core/HW/MMIO.cpp index af50aae0a0..4e27c17048 100644 --- a/Source/Core/Core/HW/MMIO.cpp +++ b/Source/Core/Core/HW/MMIO.cpp @@ -39,7 +39,7 @@ class ConstantHandlingMethod : public ReadHandlingMethod { public: explicit ConstantHandlingMethod(T value) : value_(value) {} - virtual ~ConstantHandlingMethod() = default; + ~ConstantHandlingMethod() override = default; void AcceptReadVisitor(ReadHandlingMethodVisitor& v) const override { v.VisitConstant(value_); @@ -62,7 +62,7 @@ class NopHandlingMethod : public WriteHandlingMethod { public: NopHandlingMethod() {} - virtual ~NopHandlingMethod() = default; + ~NopHandlingMethod() override = default; void AcceptWriteVisitor(WriteHandlingMethodVisitor& v) const override { v.VisitNop(); } }; template @@ -79,7 +79,7 @@ class DirectHandlingMethod : public ReadHandlingMethod, public WriteHandlingM { public: DirectHandlingMethod(T* addr, u32 mask) : addr_(addr), mask_(mask) {} - virtual ~DirectHandlingMethod() = default; + ~DirectHandlingMethod() override = default; void AcceptReadVisitor(ReadHandlingMethodVisitor& v) const override { v.VisitDirect(addr_, mask_); @@ -122,7 +122,7 @@ public: { } - virtual ~ComplexHandlingMethod() = default; + ~ComplexHandlingMethod() override = default; void AcceptReadVisitor(ReadHandlingMethodVisitor& v) const override { v.VisitComplex(&read_lambda_); diff --git a/Source/Core/Core/HW/SI/SI_DeviceGBAEmu.h b/Source/Core/Core/HW/SI/SI_DeviceGBAEmu.h index a9677889ce..34eba00d88 100644 --- a/Source/Core/Core/HW/SI/SI_DeviceGBAEmu.h +++ b/Source/Core/Core/HW/SI/SI_DeviceGBAEmu.h @@ -21,7 +21,7 @@ class CSIDevice_GBAEmu final : public ISIDevice { public: CSIDevice_GBAEmu(Core::System& system, SIDevices device, int device_number); - ~CSIDevice_GBAEmu(); + ~CSIDevice_GBAEmu() override; int RunBuffer(u8* buffer, int request_length) override; int TransferInterval() override; diff --git a/Source/Core/Core/HW/WiimoteEmu/Extension/Extension.h b/Source/Core/Core/HW/WiimoteEmu/Extension/Extension.h index e799853774..2f5efd5a94 100644 --- a/Source/Core/Core/HW/WiimoteEmu/Extension/Extension.h +++ b/Source/Core/Core/HW/WiimoteEmu/Extension/Extension.h @@ -120,7 +120,7 @@ protected: using EncryptedExtension::EncryptedExtension; private: - void UpdateEncryptionKey() final override; + void UpdateEncryptionKey() final; }; class Extension3rdParty : public EncryptedExtension @@ -129,7 +129,7 @@ protected: using EncryptedExtension::EncryptedExtension; private: - void UpdateEncryptionKey() final override; + void UpdateEncryptionKey() final; }; } // namespace WiimoteEmu diff --git a/Source/Core/Core/HW/WiimoteEmu/WiimoteEmu.h b/Source/Core/Core/HW/WiimoteEmu/WiimoteEmu.h index be5fdfdc6e..94da0a563c 100644 --- a/Source/Core/Core/HW/WiimoteEmu/WiimoteEmu.h +++ b/Source/Core/Core/HW/WiimoteEmu/WiimoteEmu.h @@ -137,7 +137,7 @@ public: static constexpr const char* SIDEWAYS_OPTION = "Sideways Wiimote"; explicit Wiimote(unsigned int index); - ~Wiimote(); + ~Wiimote() override; std::string GetName() const override; diff --git a/Source/Core/Core/HW/WiimoteReal/IOhidapi.h b/Source/Core/Core/HW/WiimoteReal/IOhidapi.h index 8074ecc1ab..9a6f6f09cf 100644 --- a/Source/Core/Core/HW/WiimoteReal/IOhidapi.h +++ b/Source/Core/Core/HW/WiimoteReal/IOhidapi.h @@ -34,7 +34,7 @@ class WiimoteScannerHidapi final : public WiimoteScannerBackend { public: WiimoteScannerHidapi(); - ~WiimoteScannerHidapi(); + ~WiimoteScannerHidapi() override; bool IsReady() const override; void FindWiimotes(std::vector&, Wiimote*&) override; void Update() override {} // not needed for hidapi diff --git a/Source/Core/Core/HotkeyManager.h b/Source/Core/Core/HotkeyManager.h index 5818ea3ba4..cdcc149309 100644 --- a/Source/Core/Core/HotkeyManager.h +++ b/Source/Core/Core/HotkeyManager.h @@ -233,7 +233,7 @@ class HotkeyManager : public ControllerEmu::EmulatedController { public: HotkeyManager(); - ~HotkeyManager(); + ~HotkeyManager() override; void GetInput(HotkeyStatus* hk, bool ignore_focus); std::string GetName() const override; diff --git a/Source/Core/Core/IOS/ES/ES.h b/Source/Core/Core/IOS/ES/ES.h index 4b9adbf576..e5c9f4f06a 100644 --- a/Source/Core/Core/IOS/ES/ES.h +++ b/Source/Core/Core/IOS/ES/ES.h @@ -234,7 +234,7 @@ public: ESDevice(ESDevice&& other) = delete; ESDevice& operator=(const ESDevice& other) = delete; ESDevice& operator=(ESDevice&& other) = delete; - ~ESDevice(); + ~ESDevice() override; static void InitializeEmulationState(CoreTiming::CoreTimingManager& core_timing); static void FinalizeEmulationState(); diff --git a/Source/Core/Core/IOS/FS/FileSystemProxy.h b/Source/Core/Core/IOS/FS/FileSystemProxy.h index 8f3bb1e8b4..6e33b3e9dd 100644 --- a/Source/Core/Core/IOS/FS/FileSystemProxy.h +++ b/Source/Core/Core/IOS/FS/FileSystemProxy.h @@ -117,7 +117,7 @@ class FSDevice final : public EmulationDevice { public: FSDevice(EmulationKernel& ios, FSCore& core, const std::string& device_name); - ~FSDevice(); + ~FSDevice() override; void DoState(PointerWrap& p) override; diff --git a/Source/Core/Core/IOS/FS/HostBackend/FS.h b/Source/Core/Core/IOS/FS/HostBackend/FS.h index 3c68a59495..6f6e74ffa3 100644 --- a/Source/Core/Core/IOS/FS/HostBackend/FS.h +++ b/Source/Core/Core/IOS/FS/HostBackend/FS.h @@ -23,7 +23,7 @@ class HostFileSystem final : public FileSystem { public: HostFileSystem(const std::string& root_path, std::vector nand_redirects = {}); - ~HostFileSystem(); + ~HostFileSystem() override; void DoState(PointerWrap& p) override; diff --git a/Source/Core/Core/IOS/IOS.h b/Source/Core/Core/IOS/IOS.h index 2f8fe04017..de67d53980 100644 --- a/Source/Core/Core/IOS/IOS.h +++ b/Source/Core/Core/IOS/IOS.h @@ -153,7 +153,7 @@ class EmulationKernel final : public Kernel { public: EmulationKernel(Core::System& system, u64 ios_title_id); - ~EmulationKernel(); + ~EmulationKernel() override; // Get a resource manager by name. // This only works for devices which are part of the device map. diff --git a/Source/Core/Core/IOS/Network/SSL.h b/Source/Core/Core/IOS/Network/SSL.h index 980361c901..50650fb0e2 100644 --- a/Source/Core/Core/IOS/Network/SSL.h +++ b/Source/Core/Core/IOS/Network/SSL.h @@ -84,7 +84,7 @@ class NetSSLDevice : public EmulationDevice public: NetSSLDevice(EmulationKernel& ios, const std::string& device_name); - virtual ~NetSSLDevice(); + ~NetSSLDevice() override; std::optional IOCtl(const IOCtlRequest& request) override; std::optional IOCtlV(const IOCtlVRequest& request) override; diff --git a/Source/Core/Core/IOS/USB/Bluetooth/BTEmu.h b/Source/Core/Core/IOS/USB/Bluetooth/BTEmu.h index 7da6e6ee13..70735d0da8 100644 --- a/Source/Core/Core/IOS/USB/Bluetooth/BTEmu.h +++ b/Source/Core/Core/IOS/USB/Bluetooth/BTEmu.h @@ -41,7 +41,7 @@ class BluetoothEmuDevice final : public BluetoothBaseDevice public: BluetoothEmuDevice(EmulationKernel& ios, const std::string& device_name); - virtual ~BluetoothEmuDevice(); + ~BluetoothEmuDevice() override; std::optional Close(u32 fd) override; std::optional IOCtlV(const IOCtlVRequest& request) override; diff --git a/Source/Core/Core/IOS/USB/Emulated/Skylanders/Skylander.h b/Source/Core/Core/IOS/USB/Emulated/Skylanders/Skylander.h index f53b04484f..f9f8f8f616 100644 --- a/Source/Core/Core/IOS/USB/Emulated/Skylanders/Skylander.h +++ b/Source/Core/Core/IOS/USB/Emulated/Skylanders/Skylander.h @@ -73,7 +73,7 @@ class SkylanderUSB final : public Device { public: SkylanderUSB(); - ~SkylanderUSB(); + ~SkylanderUSB() override; DeviceDescriptor GetDeviceDescriptor() const override; std::vector GetConfigurations() const override; std::vector GetInterfaces(u8 config) const override; diff --git a/Source/Core/Core/IOS/USB/Host.h b/Source/Core/Core/IOS/USB/Host.h index e457c2bc5b..9d0f537f33 100644 --- a/Source/Core/Core/IOS/USB/Host.h +++ b/Source/Core/Core/IOS/USB/Host.h @@ -25,7 +25,7 @@ class USBHost : public EmulationDevice { public: USBHost(EmulationKernel& ios, const std::string& device_name); - virtual ~USBHost(); + ~USBHost() override; std::optional Open(const OpenRequest& request) override; diff --git a/Source/Core/Core/IOS/USB/LibusbDevice.h b/Source/Core/Core/IOS/USB/LibusbDevice.h index 908e9e8b0d..e6151b11e2 100644 --- a/Source/Core/Core/IOS/USB/LibusbDevice.h +++ b/Source/Core/Core/IOS/USB/LibusbDevice.h @@ -27,7 +27,7 @@ class LibusbDevice final : public Device { public: LibusbDevice(libusb_device* device, const libusb_device_descriptor& device_descriptor); - ~LibusbDevice(); + ~LibusbDevice() override; DeviceDescriptor GetDeviceDescriptor() const override; std::vector GetConfigurations() const override; std::vector GetInterfaces(u8 config) const override; diff --git a/Source/Core/Core/NetPlayClient.h b/Source/Core/Core/NetPlayClient.h index b5ba32bcb4..d5675ee63e 100644 --- a/Source/Core/Core/NetPlayClient.h +++ b/Source/Core/Core/NetPlayClient.h @@ -116,7 +116,7 @@ public: NetPlayClient(const std::string& address, const u16 port, NetPlayUI* dialog, const std::string& name, const NetTraversalConfig& traversal_config); - ~NetPlayClient(); + ~NetPlayClient() override; std::vector GetPlayers(); const NetSettings& GetNetSettings() const; diff --git a/Source/Core/Core/NetPlayServer.h b/Source/Core/Core/NetPlayServer.h index 12bfebb323..da32b64d4b 100644 --- a/Source/Core/Core/NetPlayServer.h +++ b/Source/Core/Core/NetPlayServer.h @@ -44,7 +44,7 @@ public: NetPlayServer(u16 port, bool forward_port, NetPlayUI* dialog, const NetTraversalConfig& traversal_config); - ~NetPlayServer(); + ~NetPlayServer() override; bool ChangeGame(const SyncIdentifier& sync_identifier, const std::string& netplay_name); bool ComputeGameDigest(const SyncIdentifier& sync_identifier); diff --git a/Source/Core/Core/NetworkCaptureLogger.h b/Source/Core/Core/NetworkCaptureLogger.h index 89dd24030b..3cdece97dc 100644 --- a/Source/Core/Core/NetworkCaptureLogger.h +++ b/Source/Core/Core/NetworkCaptureLogger.h @@ -86,7 +86,7 @@ class PCAPSSLCaptureLogger final : public NetworkCaptureLogger { public: PCAPSSLCaptureLogger(); - ~PCAPSSLCaptureLogger(); + ~PCAPSSLCaptureLogger() override; void OnNewSocket(s32 socket) override; diff --git a/Source/Core/Core/PowerPC/CachedInterpreter/CachedInterpreter.h b/Source/Core/Core/PowerPC/CachedInterpreter/CachedInterpreter.h index a29cf53758..12e9c17c50 100644 --- a/Source/Core/Core/PowerPC/CachedInterpreter/CachedInterpreter.h +++ b/Source/Core/Core/PowerPC/CachedInterpreter/CachedInterpreter.h @@ -31,7 +31,7 @@ public: CachedInterpreter(CachedInterpreter&&) = delete; CachedInterpreter& operator=(const CachedInterpreter&) = delete; CachedInterpreter& operator=(CachedInterpreter&&) = delete; - ~CachedInterpreter(); + ~CachedInterpreter() override; void Init() override; void Shutdown() override; diff --git a/Source/Core/Core/PowerPC/Interpreter/Interpreter.h b/Source/Core/Core/PowerPC/Interpreter/Interpreter.h index af800d65cb..b3816e701b 100644 --- a/Source/Core/Core/PowerPC/Interpreter/Interpreter.h +++ b/Source/Core/Core/PowerPC/Interpreter/Interpreter.h @@ -30,7 +30,7 @@ public: Interpreter(Interpreter&&) = delete; Interpreter& operator=(const Interpreter&) = delete; Interpreter& operator=(Interpreter&&) = delete; - ~Interpreter(); + ~Interpreter() override; void Init() override; void Shutdown() override; diff --git a/Source/Core/Core/PowerPC/SignatureDB/CSVSignatureDB.h b/Source/Core/Core/PowerPC/SignatureDB/CSVSignatureDB.h index eeea114e67..8a844bb1b9 100644 --- a/Source/Core/Core/PowerPC/SignatureDB/CSVSignatureDB.h +++ b/Source/Core/Core/PowerPC/SignatureDB/CSVSignatureDB.h @@ -8,7 +8,7 @@ class CSVSignatureDB final : public HashSignatureDB { public: - ~CSVSignatureDB() = default; + ~CSVSignatureDB() override = default; bool Load(const std::string& file_path) override; bool Save(const std::string& file_path) const override; }; diff --git a/Source/Core/Core/PowerPC/SignatureDB/DSYSignatureDB.h b/Source/Core/Core/PowerPC/SignatureDB/DSYSignatureDB.h index cbe8bcecc1..2e320da697 100644 --- a/Source/Core/Core/PowerPC/SignatureDB/DSYSignatureDB.h +++ b/Source/Core/Core/PowerPC/SignatureDB/DSYSignatureDB.h @@ -8,7 +8,7 @@ class DSYSignatureDB final : public HashSignatureDB { public: - ~DSYSignatureDB() = default; + ~DSYSignatureDB() override = default; bool Load(const std::string& file_path) override; bool Save(const std::string& file_path) const override; }; diff --git a/Source/Core/DiscIO/Blob.h b/Source/Core/DiscIO/Blob.h index 7e075d2655..841a827b97 100644 --- a/Source/Core/DiscIO/Blob.h +++ b/Source/Core/DiscIO/Blob.h @@ -107,7 +107,7 @@ protected: class SectorReader : public BlobReader { public: - virtual ~SectorReader() = 0; + ~SectorReader() override = 0; bool Read(u64 offset, u64 size, u8* out_ptr) override; diff --git a/Source/Core/DiscIO/CompressedBlob.h b/Source/Core/DiscIO/CompressedBlob.h index 7eb29c3b35..15eeffc3db 100644 --- a/Source/Core/DiscIO/CompressedBlob.h +++ b/Source/Core/DiscIO/CompressedBlob.h @@ -45,7 +45,7 @@ class CompressedBlobReader final : public SectorReader public: static std::unique_ptr Create(File::IOFile file, const std::string& filename); - ~CompressedBlobReader(); + ~CompressedBlobReader() override; const CompressedBlobHeader& GetHeader() const { return m_header; } diff --git a/Source/Core/DiscIO/VolumeGC.h b/Source/Core/DiscIO/VolumeGC.h index 5cf4ea0eed..ff768c2e2a 100644 --- a/Source/Core/DiscIO/VolumeGC.h +++ b/Source/Core/DiscIO/VolumeGC.h @@ -29,7 +29,7 @@ class VolumeGC final : public VolumeDisc { public: VolumeGC(std::unique_ptr reader); - ~VolumeGC(); + ~VolumeGC() override; bool Read(u64 offset, u64 length, u8* buffer, const Partition& partition = PARTITION_NONE) const override; const FileSystem* GetFileSystem(const Partition& partition = PARTITION_NONE) const override; diff --git a/Source/Core/DiscIO/VolumeWii.h b/Source/Core/DiscIO/VolumeWii.h index c8dd6aedfa..2730fe0a48 100644 --- a/Source/Core/DiscIO/VolumeWii.h +++ b/Source/Core/DiscIO/VolumeWii.h @@ -58,7 +58,7 @@ public: static_assert(sizeof(HashBlock) == BLOCK_HEADER_SIZE); VolumeWii(std::unique_ptr reader); - ~VolumeWii(); + ~VolumeWii() override; bool Read(u64 offset, u64 length, u8* buffer, const Partition& partition) const override; bool HasWiiHashes() const override; bool HasWiiEncryption() const override; diff --git a/Source/Core/DiscIO/WIABlob.h b/Source/Core/DiscIO/WIABlob.h index e0d6a66d87..f42a7f4c73 100644 --- a/Source/Core/DiscIO/WIABlob.h +++ b/Source/Core/DiscIO/WIABlob.h @@ -44,7 +44,7 @@ template class WIARVZFileReader final : public BlobReader { public: - ~WIARVZFileReader(); + ~WIARVZFileReader() override; static std::unique_ptr Create(File::IOFile file, const std::string& path); diff --git a/Source/Core/DiscIO/WIACompression.h b/Source/Core/DiscIO/WIACompression.h index 42f4a7fa19..5f3ea2df9b 100644 --- a/Source/Core/DiscIO/WIACompression.h +++ b/Source/Core/DiscIO/WIACompression.h @@ -75,7 +75,7 @@ private: class Bzip2Decompressor final : public Decompressor { public: - ~Bzip2Decompressor(); + ~Bzip2Decompressor() override; bool Decompress(const DecompressionBuffer& in, DecompressionBuffer* out, size_t* in_bytes_read) override; @@ -89,7 +89,7 @@ class LZMADecompressor final : public Decompressor { public: LZMADecompressor(bool lzma2, const u8* filter_options, size_t filter_options_size); - ~LZMADecompressor(); + ~LZMADecompressor() override; bool Decompress(const DecompressionBuffer& in, DecompressionBuffer* out, size_t* in_bytes_read) override; @@ -106,7 +106,7 @@ class ZstdDecompressor final : public Decompressor { public: ZstdDecompressor(); - ~ZstdDecompressor(); + ~ZstdDecompressor() override; bool Decompress(const DecompressionBuffer& in, DecompressionBuffer* out, size_t* in_bytes_read) override; @@ -164,7 +164,7 @@ class PurgeCompressor final : public Compressor { public: PurgeCompressor(); - ~PurgeCompressor(); + ~PurgeCompressor() override; bool Start(std::optional size) override; bool AddPrecedingDataOnlyForPurgeHashing(const u8* data, size_t size) override; @@ -184,7 +184,7 @@ class Bzip2Compressor final : public Compressor { public: Bzip2Compressor(int compression_level); - ~Bzip2Compressor(); + ~Bzip2Compressor() override; bool Start(std::optional size) override; bool Compress(const u8* data, size_t size) override; @@ -206,7 +206,7 @@ class LZMACompressor final : public Compressor public: LZMACompressor(bool lzma2, int compression_level, u8 compressor_data_out[7], u8* compressor_data_size_out); - ~LZMACompressor(); + ~LZMACompressor() override; bool Start(std::optional size) override; bool Compress(const u8* data, size_t size) override; @@ -229,7 +229,7 @@ class ZstdCompressor final : public Compressor { public: ZstdCompressor(int compression_level); - ~ZstdCompressor(); + ~ZstdCompressor() override; bool Start(std::optional size) override; bool Compress(const u8* data, size_t size) override; diff --git a/Source/Core/DiscIO/WbfsBlob.h b/Source/Core/DiscIO/WbfsBlob.h index 29bc48e85f..8e19f4999e 100644 --- a/Source/Core/DiscIO/WbfsBlob.h +++ b/Source/Core/DiscIO/WbfsBlob.h @@ -18,7 +18,7 @@ static constexpr u32 WBFS_MAGIC = 0x53464257; // "WBFS" (byteswapped to little class WbfsFileReader final : public BlobReader { public: - ~WbfsFileReader(); + ~WbfsFileReader() override; static std::unique_ptr Create(File::IOFile file, const std::string& path); diff --git a/Source/Core/DolphinQt/CheatsManager.h b/Source/Core/DolphinQt/CheatsManager.h index 708cc4095f..c0b392d74b 100644 --- a/Source/Core/DolphinQt/CheatsManager.h +++ b/Source/Core/DolphinQt/CheatsManager.h @@ -34,7 +34,7 @@ class CheatsManager : public QDialog Q_OBJECT public: explicit CheatsManager(Core::System& system, QWidget* parent = nullptr); - ~CheatsManager(); + ~CheatsManager() override; signals: void OpenGeneralSettings(); diff --git a/Source/Core/DolphinQt/Config/GameConfigHighlighter.h b/Source/Core/DolphinQt/Config/GameConfigHighlighter.h index 072dcab72a..b01febed42 100644 --- a/Source/Core/DolphinQt/Config/GameConfigHighlighter.h +++ b/Source/Core/DolphinQt/Config/GameConfigHighlighter.h @@ -17,7 +17,7 @@ class GameConfigHighlighter : public QSyntaxHighlighter public: explicit GameConfigHighlighter(QTextDocument* parent = nullptr); - ~GameConfigHighlighter(); + ~GameConfigHighlighter() override; protected: void highlightBlock(const QString& text) override; diff --git a/Source/Core/DolphinQt/Config/GameConfigWidget.h b/Source/Core/DolphinQt/Config/GameConfigWidget.h index c0eb9eb15e..1f29168013 100644 --- a/Source/Core/DolphinQt/Config/GameConfigWidget.h +++ b/Source/Core/DolphinQt/Config/GameConfigWidget.h @@ -29,7 +29,7 @@ class GameConfigWidget : public QWidget Q_OBJECT public: explicit GameConfigWidget(const UICommon::GameFile& game); - ~GameConfigWidget(); + ~GameConfigWidget() override; private: void CreateWidgets(); diff --git a/Source/Core/DolphinQt/Config/Graphics/PostProcessingConfigWindow.h b/Source/Core/DolphinQt/Config/Graphics/PostProcessingConfigWindow.h index 1faed07930..5c02368c8c 100644 --- a/Source/Core/DolphinQt/Config/Graphics/PostProcessingConfigWindow.h +++ b/Source/Core/DolphinQt/Config/Graphics/PostProcessingConfigWindow.h @@ -27,7 +27,7 @@ class PostProcessingConfigWindow final : public QDialog Q_OBJECT public: explicit PostProcessingConfigWindow(EnhancementsWidget* parent, const std::string& shader); - ~PostProcessingConfigWindow(); + ~PostProcessingConfigWindow() override; private: class ConfigGroup final diff --git a/Source/Core/DolphinQt/Config/GraphicsModListWidget.h b/Source/Core/DolphinQt/Config/GraphicsModListWidget.h index ff310af56c..092b7c4195 100644 --- a/Source/Core/DolphinQt/Config/GraphicsModListWidget.h +++ b/Source/Core/DolphinQt/Config/GraphicsModListWidget.h @@ -35,7 +35,7 @@ class GraphicsModListWidget : public QWidget Q_OBJECT public: explicit GraphicsModListWidget(const UICommon::GameFile& game); - ~GraphicsModListWidget(); + ~GraphicsModListWidget() override; void SaveToDisk(); diff --git a/Source/Core/DolphinQt/Config/LogConfigWidget.h b/Source/Core/DolphinQt/Config/LogConfigWidget.h index 43f750065b..790f46170b 100644 --- a/Source/Core/DolphinQt/Config/LogConfigWidget.h +++ b/Source/Core/DolphinQt/Config/LogConfigWidget.h @@ -17,7 +17,7 @@ class LogConfigWidget final : public QDockWidget Q_OBJECT public: explicit LogConfigWidget(QWidget* parent = nullptr); - ~LogConfigWidget(); + ~LogConfigWidget() override; protected: void closeEvent(QCloseEvent* event) override; diff --git a/Source/Core/DolphinQt/Config/LogWidget.h b/Source/Core/DolphinQt/Config/LogWidget.h index e74c4610db..ab8d20273e 100644 --- a/Source/Core/DolphinQt/Config/LogWidget.h +++ b/Source/Core/DolphinQt/Config/LogWidget.h @@ -23,7 +23,7 @@ class LogWidget final : public QDockWidget Q_OBJECT public: explicit LogWidget(QWidget* parent = nullptr); - ~LogWidget(); + ~LogWidget() override; protected: void closeEvent(QCloseEvent*) override; diff --git a/Source/Core/DolphinQt/Config/Mapping/GCPadWiiUConfigDialog.h b/Source/Core/DolphinQt/Config/Mapping/GCPadWiiUConfigDialog.h index 0bcfb8f966..f18510d3c5 100644 --- a/Source/Core/DolphinQt/Config/Mapping/GCPadWiiUConfigDialog.h +++ b/Source/Core/DolphinQt/Config/Mapping/GCPadWiiUConfigDialog.h @@ -15,7 +15,7 @@ class GCPadWiiUConfigDialog final : public QDialog Q_OBJECT public: explicit GCPadWiiUConfigDialog(int port, QWidget* parent = nullptr); - ~GCPadWiiUConfigDialog(); + ~GCPadWiiUConfigDialog() override; private: void LoadSettings(); diff --git a/Source/Core/DolphinQt/Debugger/AssemblerWidget.h b/Source/Core/DolphinQt/Debugger/AssemblerWidget.h index d130d01701..e7d3068a1e 100644 --- a/Source/Core/DolphinQt/Debugger/AssemblerWidget.h +++ b/Source/Core/DolphinQt/Debugger/AssemblerWidget.h @@ -31,10 +31,10 @@ public: bool ApplicationCloseRequest(); - ~AssemblerWidget(); + ~AssemblerWidget() override; protected: - void closeEvent(QCloseEvent*); + void closeEvent(QCloseEvent*) override; private: enum class AsmKind diff --git a/Source/Core/DolphinQt/Debugger/BreakpointWidget.cpp b/Source/Core/DolphinQt/Debugger/BreakpointWidget.cpp index 2c59e86f69..1aa08c7596 100644 --- a/Source/Core/DolphinQt/Debugger/BreakpointWidget.cpp +++ b/Source/Core/DolphinQt/Debugger/BreakpointWidget.cpp @@ -65,7 +65,8 @@ public: CustomDelegate(BreakpointWidget* parent) : QStyledItemDelegate(parent) {} private: - void paint(QPainter* painter, const QStyleOptionViewItem& option, const QModelIndex& index) const + void paint(QPainter* painter, const QStyleOptionViewItem& option, + const QModelIndex& index) const override { Q_ASSERT(index.isValid()); diff --git a/Source/Core/DolphinQt/Debugger/BreakpointWidget.h b/Source/Core/DolphinQt/Debugger/BreakpointWidget.h index 59b4b14bfa..f48570f449 100644 --- a/Source/Core/DolphinQt/Debugger/BreakpointWidget.h +++ b/Source/Core/DolphinQt/Debugger/BreakpointWidget.h @@ -31,7 +31,7 @@ class BreakpointWidget : public QDockWidget Q_OBJECT public: explicit BreakpointWidget(QWidget* parent = nullptr); - ~BreakpointWidget(); + ~BreakpointWidget() override; void AddBP(u32 addr); void AddBP(u32 addr, bool break_on_hit, bool log_on_hit, const QString& condition); diff --git a/Source/Core/DolphinQt/Debugger/CodeWidget.h b/Source/Core/DolphinQt/Debugger/CodeWidget.h index 62f2642222..10f56e1546 100644 --- a/Source/Core/DolphinQt/Debugger/CodeWidget.h +++ b/Source/Core/DolphinQt/Debugger/CodeWidget.h @@ -33,7 +33,7 @@ class CodeWidget : public QDockWidget Q_OBJECT public: explicit CodeWidget(QWidget* parent = nullptr); - ~CodeWidget(); + ~CodeWidget() override; void Step(); void StepOver(); diff --git a/Source/Core/DolphinQt/Debugger/GekkoSyntaxHighlight.cpp b/Source/Core/DolphinQt/Debugger/GekkoSyntaxHighlight.cpp index 3311bae28b..683099cf98 100644 --- a/Source/Core/DolphinQt/Debugger/GekkoSyntaxHighlight.cpp +++ b/Source/Core/DolphinQt/Debugger/GekkoSyntaxHighlight.cpp @@ -16,7 +16,7 @@ using namespace Common::GekkoAssembler::detail; class HighlightParsePlugin : public ParsePlugin { public: - virtual ~HighlightParsePlugin() = default; + ~HighlightParsePlugin() override = default; std::vector>&& MoveParens() { return std::move(m_matched_parens); } std::vector>&& MoveFormatting() diff --git a/Source/Core/DolphinQt/Debugger/MemoryWidget.h b/Source/Core/DolphinQt/Debugger/MemoryWidget.h index fad91e0626..6aa1f01aa5 100644 --- a/Source/Core/DolphinQt/Debugger/MemoryWidget.h +++ b/Source/Core/DolphinQt/Debugger/MemoryWidget.h @@ -32,7 +32,7 @@ class MemoryWidget : public QDockWidget Q_OBJECT public: explicit MemoryWidget(Core::System& system, QWidget* parent = nullptr); - ~MemoryWidget(); + ~MemoryWidget() override; void SetAddress(u32 address); void Update(); diff --git a/Source/Core/DolphinQt/Debugger/NetworkWidget.h b/Source/Core/DolphinQt/Debugger/NetworkWidget.h index eb235129bd..c1b1e564d9 100644 --- a/Source/Core/DolphinQt/Debugger/NetworkWidget.h +++ b/Source/Core/DolphinQt/Debugger/NetworkWidget.h @@ -21,7 +21,7 @@ class NetworkWidget : public QDockWidget Q_OBJECT public: explicit NetworkWidget(QWidget* parent = nullptr); - ~NetworkWidget(); + ~NetworkWidget() override; protected: void closeEvent(QCloseEvent*) override; diff --git a/Source/Core/DolphinQt/Debugger/RegisterWidget.h b/Source/Core/DolphinQt/Debugger/RegisterWidget.h index 13432692a6..8f02089379 100644 --- a/Source/Core/DolphinQt/Debugger/RegisterWidget.h +++ b/Source/Core/DolphinQt/Debugger/RegisterWidget.h @@ -23,7 +23,7 @@ class RegisterWidget : public QDockWidget Q_OBJECT public: explicit RegisterWidget(QWidget* parent = nullptr); - ~RegisterWidget(); + ~RegisterWidget() override; signals: void RequestTableUpdate(); diff --git a/Source/Core/DolphinQt/Debugger/ThreadWidget.h b/Source/Core/DolphinQt/Debugger/ThreadWidget.h index 5aedd72a4f..3ab86b06f8 100644 --- a/Source/Core/DolphinQt/Debugger/ThreadWidget.h +++ b/Source/Core/DolphinQt/Debugger/ThreadWidget.h @@ -19,7 +19,7 @@ class ThreadWidget : public QDockWidget Q_OBJECT public: explicit ThreadWidget(QWidget* parent = nullptr); - ~ThreadWidget(); + ~ThreadWidget() override; signals: void RequestBreakpoint(u32 addr); diff --git a/Source/Core/DolphinQt/Debugger/WatchWidget.h b/Source/Core/DolphinQt/Debugger/WatchWidget.h index a3256ecd94..b1e1383803 100644 --- a/Source/Core/DolphinQt/Debugger/WatchWidget.h +++ b/Source/Core/DolphinQt/Debugger/WatchWidget.h @@ -25,7 +25,7 @@ class WatchWidget : public QDockWidget Q_OBJECT public: explicit WatchWidget(QWidget* parent = nullptr); - ~WatchWidget(); + ~WatchWidget() override; void AddWatch(QString name, u32 addr); signals: diff --git a/Source/Core/DolphinQt/DiscordHandler.h b/Source/Core/DolphinQt/DiscordHandler.h index a4fc342530..b9a1f070da 100644 --- a/Source/Core/DolphinQt/DiscordHandler.h +++ b/Source/Core/DolphinQt/DiscordHandler.h @@ -22,7 +22,7 @@ class DiscordHandler : public QObject, public Discord::Handler #ifdef USE_DISCORD_PRESENCE public: explicit DiscordHandler(QWidget* parent); - ~DiscordHandler(); + ~DiscordHandler() override; void Start(); void Stop(); diff --git a/Source/Core/DolphinQt/FIFO/FIFOAnalyzer.h b/Source/Core/DolphinQt/FIFO/FIFOAnalyzer.h index 38a83d35c7..90cf9b8b19 100644 --- a/Source/Core/DolphinQt/FIFO/FIFOAnalyzer.h +++ b/Source/Core/DolphinQt/FIFO/FIFOAnalyzer.h @@ -26,7 +26,7 @@ class FIFOAnalyzer final : public QWidget public: explicit FIFOAnalyzer(FifoPlayer& fifo_player); - ~FIFOAnalyzer(); + ~FIFOAnalyzer() override; void Update(); diff --git a/Source/Core/DolphinQt/FIFO/FIFOPlayerWindow.h b/Source/Core/DolphinQt/FIFO/FIFOPlayerWindow.h index 647c95710d..5b0bf5dc21 100644 --- a/Source/Core/DolphinQt/FIFO/FIFOPlayerWindow.h +++ b/Source/Core/DolphinQt/FIFO/FIFOPlayerWindow.h @@ -23,7 +23,7 @@ class FIFOPlayerWindow : public QWidget public: explicit FIFOPlayerWindow(FifoPlayer& fifo_player, FifoRecorder& fifo_recorder, QWidget* parent = nullptr); - ~FIFOPlayerWindow(); + ~FIFOPlayerWindow() override; signals: void LoadFIFORequested(const QString& path); @@ -50,7 +50,7 @@ private: void UpdateInfo(); void UpdateLimits(); - bool eventFilter(QObject* object, QEvent* event) final override; + bool eventFilter(QObject* object, QEvent* event) final; FifoPlayer& m_fifo_player; FifoRecorder& m_fifo_recorder; diff --git a/Source/Core/DolphinQt/GBAHost.h b/Source/Core/DolphinQt/GBAHost.h index 99e28bd2af..3c67360c64 100644 --- a/Source/Core/DolphinQt/GBAHost.h +++ b/Source/Core/DolphinQt/GBAHost.h @@ -18,7 +18,7 @@ class GBAHost : public GBAHostInterface { public: explicit GBAHost(std::weak_ptr core); - ~GBAHost(); + ~GBAHost() override; void GameChanged() override; void FrameEnded(const std::vector& video_buffer) override; diff --git a/Source/Core/DolphinQt/GCMemcardCreateNewDialog.h b/Source/Core/DolphinQt/GCMemcardCreateNewDialog.h index a9a5089056..233145f941 100644 --- a/Source/Core/DolphinQt/GCMemcardCreateNewDialog.h +++ b/Source/Core/DolphinQt/GCMemcardCreateNewDialog.h @@ -13,7 +13,7 @@ class GCMemcardCreateNewDialog : public QDialog Q_OBJECT public: explicit GCMemcardCreateNewDialog(QWidget* parent = nullptr); - ~GCMemcardCreateNewDialog(); + ~GCMemcardCreateNewDialog() override; std::string GetMemoryCardPath() const; diff --git a/Source/Core/DolphinQt/GCMemcardManager.h b/Source/Core/DolphinQt/GCMemcardManager.h index f87d001d8a..2f5f974efc 100644 --- a/Source/Core/DolphinQt/GCMemcardManager.h +++ b/Source/Core/DolphinQt/GCMemcardManager.h @@ -41,7 +41,7 @@ class GCMemcardManager : public QDialog Q_OBJECT public: explicit GCMemcardManager(QWidget* parent = nullptr); - ~GCMemcardManager(); + ~GCMemcardManager() override; static QString GetErrorMessagesForErrorCode(const Memcard::GCMemcardErrorCode& code); static QString GetErrorMessageForErrorCode(Memcard::ReadSavefileErrorCode code); diff --git a/Source/Core/DolphinQt/GameList/GameList.h b/Source/Core/DolphinQt/GameList/GameList.h index 54ca50ab15..df771bba87 100644 --- a/Source/Core/DolphinQt/GameList/GameList.h +++ b/Source/Core/DolphinQt/GameList/GameList.h @@ -26,7 +26,7 @@ class GameList final : public QStackedWidget public: explicit GameList(QWidget* parent = nullptr); - ~GameList(); + ~GameList() override; std::shared_ptr GetSelectedGame() const; QList> GetSelectedGames() const; diff --git a/Source/Core/DolphinQt/Host.h b/Source/Core/DolphinQt/Host.h index cee44a2e6a..0eacfe646d 100644 --- a/Source/Core/DolphinQt/Host.h +++ b/Source/Core/DolphinQt/Host.h @@ -17,7 +17,7 @@ class Host final : public QObject Q_OBJECT public: - ~Host(); + ~Host() override; static Host* GetInstance(); diff --git a/Source/Core/DolphinQt/HotkeyScheduler.h b/Source/Core/DolphinQt/HotkeyScheduler.h index c61cdb265d..301d1c198a 100644 --- a/Source/Core/DolphinQt/HotkeyScheduler.h +++ b/Source/Core/DolphinQt/HotkeyScheduler.h @@ -16,7 +16,7 @@ class HotkeyScheduler : public QObject Q_OBJECT public: explicit HotkeyScheduler(); - ~HotkeyScheduler(); + ~HotkeyScheduler() override; void Start(); void Stop(); diff --git a/Source/Core/DolphinQt/MainWindow.h b/Source/Core/DolphinQt/MainWindow.h index 934574044a..272fd27b60 100644 --- a/Source/Core/DolphinQt/MainWindow.h +++ b/Source/Core/DolphinQt/MainWindow.h @@ -85,7 +85,7 @@ class MainWindow final : public QMainWindow public: explicit MainWindow(Core::System& system, std::unique_ptr boot_parameters, const std::string& movie_path); - ~MainWindow(); + ~MainWindow() override; WindowSystemInfo GetWindowSystemInfo() const; diff --git a/Source/Core/DolphinQt/NetPlay/NetPlayBrowser.h b/Source/Core/DolphinQt/NetPlay/NetPlayBrowser.h index c6a79fe870..dcadd036a7 100644 --- a/Source/Core/DolphinQt/NetPlay/NetPlayBrowser.h +++ b/Source/Core/DolphinQt/NetPlay/NetPlayBrowser.h @@ -29,7 +29,7 @@ class NetPlayBrowser : public QDialog Q_OBJECT public: explicit NetPlayBrowser(QWidget* parent = nullptr); - ~NetPlayBrowser(); + ~NetPlayBrowser() override; void accept() override; signals: diff --git a/Source/Core/DolphinQt/NetPlay/NetPlayDialog.h b/Source/Core/DolphinQt/NetPlay/NetPlayDialog.h index f053772a18..cef765d368 100644 --- a/Source/Core/DolphinQt/NetPlay/NetPlayDialog.h +++ b/Source/Core/DolphinQt/NetPlay/NetPlayDialog.h @@ -40,7 +40,7 @@ public: explicit NetPlayDialog(const GameListModel& game_list_model, StartGameCallback start_game_callback, QWidget* parent = nullptr); - ~NetPlayDialog(); + ~NetPlayDialog() override; void show(std::string nickname, bool use_traversal); void reject() override; diff --git a/Source/Core/DolphinQt/QtUtils/ElidedButton.h b/Source/Core/DolphinQt/QtUtils/ElidedButton.h index 8adaad4f15..764da8f39c 100644 --- a/Source/Core/DolphinQt/QtUtils/ElidedButton.h +++ b/Source/Core/DolphinQt/QtUtils/ElidedButton.h @@ -14,9 +14,9 @@ public: Qt::TextElideMode elideMode() const; void setElideMode(Qt::TextElideMode elide_mode); - QSize sizeHint() const final override; + QSize sizeHint() const final; private: - void paintEvent(QPaintEvent* event) final override; + void paintEvent(QPaintEvent* event) final; Qt::TextElideMode m_elide_mode; }; diff --git a/Source/Core/DolphinQt/RiivolutionBootWidget.h b/Source/Core/DolphinQt/RiivolutionBootWidget.h index 2455001928..9c6fd32092 100644 --- a/Source/Core/DolphinQt/RiivolutionBootWidget.h +++ b/Source/Core/DolphinQt/RiivolutionBootWidget.h @@ -24,7 +24,7 @@ public: explicit RiivolutionBootWidget(std::string game_id, std::optional revision, std::optional disc, std::string base_game_path, QWidget* parent = nullptr); - ~RiivolutionBootWidget(); + ~RiivolutionBootWidget() override; bool ShouldBoot() const { return m_should_boot; } std::vector& GetPatches() { return m_patches; } diff --git a/Source/Core/DolphinQt/SearchBar.h b/Source/Core/DolphinQt/SearchBar.h index 145aa49799..07b009f877 100644 --- a/Source/Core/DolphinQt/SearchBar.h +++ b/Source/Core/DolphinQt/SearchBar.h @@ -24,7 +24,7 @@ private: void CreateWidgets(); void ConnectWidgets(); - bool eventFilter(QObject* object, QEvent* event) final override; + bool eventFilter(QObject* object, QEvent* event) final; QLineEdit* m_search_edit; QPushButton* m_close_button; diff --git a/Source/Core/DolphinQt/Settings.h b/Source/Core/DolphinQt/Settings.h index 50440e85a1..a109c37ae6 100644 --- a/Source/Core/DolphinQt/Settings.h +++ b/Source/Core/DolphinQt/Settings.h @@ -44,7 +44,7 @@ public: Settings(Settings&&) = delete; Settings& operator=(Settings&&) = delete; - ~Settings(); + ~Settings() override; void UnregisterDevicesChangedCallback(); diff --git a/Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.h b/Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.h index 49f562104e..772498914e 100644 --- a/Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.h +++ b/Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.h @@ -56,7 +56,7 @@ private: QVBoxLayout* CreateSlotLayout(); QVBoxLayout* CreateFinderLayout(); void closeEvent(QCloseEvent* bar) override; - bool eventFilter(QObject* object, QEvent* event) final override; + bool eventFilter(QObject* object, QEvent* event) final; // UI void EmulatePortal(bool emulate); diff --git a/Source/Core/InputCommon/ControllerEmu/ControlGroup/AnalogStick.h b/Source/Core/InputCommon/ControllerEmu/ControlGroup/AnalogStick.h index 377e63251d..09beffe728 100644 --- a/Source/Core/InputCommon/ControllerEmu/ControlGroup/AnalogStick.h +++ b/Source/Core/InputCommon/ControllerEmu/ControlGroup/AnalogStick.h @@ -17,7 +17,7 @@ public: AnalogStick(const char* name, std::unique_ptr&& stick_gate); AnalogStick(const char* name, const char* ui_name, std::unique_ptr&& stick_gate); - ReshapeData GetReshapableState(bool adjusted) const final override; + ReshapeData GetReshapableState(bool adjusted) const final; ControlState GetGateRadiusAtAngle(double ang) const override; StateData GetState() const; diff --git a/Source/Core/InputCommon/ControllerEmu/ControlGroup/Cursor.h b/Source/Core/InputCommon/ControllerEmu/ControlGroup/Cursor.h index 7b2e5f581c..a59826124a 100644 --- a/Source/Core/InputCommon/ControllerEmu/ControlGroup/Cursor.h +++ b/Source/Core/InputCommon/ControllerEmu/ControlGroup/Cursor.h @@ -24,7 +24,7 @@ public: Cursor(std::string name, std::string ui_name); - ReshapeData GetReshapableState(bool adjusted) const final override; + ReshapeData GetReshapableState(bool adjusted) const final; ControlState GetGateRadiusAtAngle(double ang) const override; // Modifies the state diff --git a/Source/Core/InputCommon/ControllerEmu/ControlGroup/Force.h b/Source/Core/InputCommon/ControllerEmu/ControlGroup/Force.h index 8815cffa73..abe02a44d4 100644 --- a/Source/Core/InputCommon/ControllerEmu/ControlGroup/Force.h +++ b/Source/Core/InputCommon/ControllerEmu/ControlGroup/Force.h @@ -18,10 +18,10 @@ public: explicit Force(const std::string& name); - ReshapeData GetReshapableState(bool adjusted) const final override; - ControlState GetGateRadiusAtAngle(double ang) const final override; + ReshapeData GetReshapableState(bool adjusted) const final; + ControlState GetGateRadiusAtAngle(double ang) const final; - ControlState GetDefaultInputRadiusAtAngle(double angle) const final override; + ControlState GetDefaultInputRadiusAtAngle(double angle) const final; StateData GetState(bool adjusted = true) const; diff --git a/Source/Core/InputCommon/ControllerEmu/ControlGroup/Tilt.h b/Source/Core/InputCommon/ControllerEmu/ControlGroup/Tilt.h index b9de77d712..69cfd7d202 100644 --- a/Source/Core/InputCommon/ControllerEmu/ControlGroup/Tilt.h +++ b/Source/Core/InputCommon/ControllerEmu/ControlGroup/Tilt.h @@ -18,12 +18,12 @@ public: explicit Tilt(const std::string& name); - ReshapeData GetReshapableState(bool adjusted) const final override; - ControlState GetGateRadiusAtAngle(double angle) const final override; + ReshapeData GetReshapableState(bool adjusted) const final; + ControlState GetGateRadiusAtAngle(double angle) const final; // Tilt is using the gate radius to adjust the tilt angle so we must provide an unadjusted value // for the default input radius. - ControlState GetDefaultInputRadiusAtAngle(double angle) const final override; + ControlState GetDefaultInputRadiusAtAngle(double angle) const final; StateData GetState() const; diff --git a/Source/Core/InputCommon/ControllerEmu/ControllerEmu.h b/Source/Core/InputCommon/ControllerEmu/ControllerEmu.h index 0c6ff27cd8..466906da04 100644 --- a/Source/Core/InputCommon/ControllerEmu/ControllerEmu.h +++ b/Source/Core/InputCommon/ControllerEmu/ControllerEmu.h @@ -235,7 +235,7 @@ protected: class EmulatedController : public ControlGroupContainer { public: - virtual ~EmulatedController(); + ~EmulatedController() override; virtual InputConfig* GetConfig() const = 0; diff --git a/Source/Core/InputCommon/ControllerEmu/StickGate.h b/Source/Core/InputCommon/ControllerEmu/StickGate.h index 496621492e..919cc08815 100644 --- a/Source/Core/InputCommon/ControllerEmu/StickGate.h +++ b/Source/Core/InputCommon/ControllerEmu/StickGate.h @@ -36,8 +36,8 @@ class OctagonStickGate : public StickGate public: // Radius of circumscribed circle explicit OctagonStickGate(ControlState radius); - ControlState GetRadiusAtAngle(double ang) const override final; - std::optional GetIdealCalibrationSampleCount() const override final; + ControlState GetRadiusAtAngle(double ang) const final; + std::optional GetIdealCalibrationSampleCount() const final; private: const ControlState m_radius; @@ -48,8 +48,8 @@ class RoundStickGate : public StickGate { public: explicit RoundStickGate(ControlState radius); - ControlState GetRadiusAtAngle(double ang) const override final; - std::optional GetIdealCalibrationSampleCount() const override final; + ControlState GetRadiusAtAngle(double ang) const final; + std::optional GetIdealCalibrationSampleCount() const final; private: const ControlState m_radius; @@ -60,8 +60,8 @@ class SquareStickGate : public StickGate { public: explicit SquareStickGate(ControlState half_width); - ControlState GetRadiusAtAngle(double ang) const override final; - std::optional GetIdealCalibrationSampleCount() const override final; + ControlState GetRadiusAtAngle(double ang) const final; + std::optional GetIdealCalibrationSampleCount() const final; private: const ControlState m_half_width; diff --git a/Source/Core/InputCommon/ControllerInterface/CoreDevice.h b/Source/Core/InputCommon/ControllerInterface/CoreDevice.h index f30dd4f405..95f9f5b88e 100644 --- a/Source/Core/InputCommon/ControllerInterface/CoreDevice.h +++ b/Source/Core/InputCommon/ControllerInterface/CoreDevice.h @@ -117,7 +117,7 @@ public: class Output : public Control { public: - virtual ~Output() = default; + ~Output() override = default; virtual void SetState(ControlState state) = 0; Output* ToOutput() override { return this; } }; diff --git a/Source/Core/InputCommon/ControllerInterface/DInput/DInputJoystick.h b/Source/Core/InputCommon/ControllerInterface/DInput/DInputJoystick.h index cb73f373f8..bf1f9aa91b 100644 --- a/Source/Core/InputCommon/ControllerInterface/DInput/DInputJoystick.h +++ b/Source/Core/InputCommon/ControllerInterface/DInput/DInputJoystick.h @@ -60,13 +60,13 @@ public: Core::DeviceRemoval UpdateInput() override; Joystick(const LPDIRECTINPUTDEVICE8 device); - ~Joystick(); + ~Joystick() override; std::string GetName() const override; std::string GetSource() const override; int GetSortPriority() const override { return -3; } - bool IsValid() const final override; + bool IsValid() const final; private: const LPDIRECTINPUTDEVICE8 m_device; diff --git a/Source/Core/InputCommon/ControllerInterface/DInput/DInputKeyboardMouse.h b/Source/Core/InputCommon/ControllerInterface/DInput/DInputKeyboardMouse.h index e7187849f6..67721e3301 100644 --- a/Source/Core/InputCommon/ControllerInterface/DInput/DInputKeyboardMouse.h +++ b/Source/Core/InputCommon/ControllerInterface/DInput/DInputKeyboardMouse.h @@ -97,7 +97,7 @@ public: Core::DeviceRemoval UpdateInput() override; KeyboardMouse(const LPDIRECTINPUTDEVICE8 kb_device, const LPDIRECTINPUTDEVICE8 mo_device); - ~KeyboardMouse(); + ~KeyboardMouse() override; std::string GetName() const override; std::string GetSource() const override; diff --git a/Source/Core/InputCommon/ControllerInterface/DualShockUDPClient/DualShockUDPClient.cpp b/Source/Core/InputCommon/ControllerInterface/DualShockUDPClient/DualShockUDPClient.cpp index ea24800762..cac67e1b8a 100644 --- a/Source/Core/InputCommon/ControllerInterface/DualShockUDPClient/DualShockUDPClient.cpp +++ b/Source/Core/InputCommon/ControllerInterface/DualShockUDPClient/DualShockUDPClient.cpp @@ -71,11 +71,8 @@ private: : m_name(name), m_input(input), m_range(range), m_offset(offset) { } - std::string GetName() const final override { return m_name; } - ControlState GetState() const final override - { - return (ControlState(m_input) + m_offset) / m_range; - } + std::string GetName() const final { return m_name; } + ControlState GetState() const final { return (ControlState(m_input) + m_offset) / m_range; } private: const char* m_name; @@ -203,7 +200,7 @@ class InputBackend final : public ciface::InputBackend { public: InputBackend(ControllerInterface* controller_interface); - ~InputBackend(); + ~InputBackend() override; void PopulateDevices() override; private: diff --git a/Source/Core/InputCommon/ControllerInterface/SDL/SDL.cpp b/Source/Core/InputCommon/ControllerInterface/SDL/SDL.cpp index 07a38b0289..efa3bfa997 100644 --- a/Source/Core/InputCommon/ControllerInterface/SDL/SDL.cpp +++ b/Source/Core/InputCommon/ControllerInterface/SDL/SDL.cpp @@ -26,7 +26,7 @@ class InputBackend final : public ciface::InputBackend { public: InputBackend(ControllerInterface* controller_interface); - ~InputBackend(); + ~InputBackend() override; void PopulateDevices() override; void UpdateInput(std::vector>& devices_to_remove) override; diff --git a/Source/Core/InputCommon/ControllerInterface/SteamDeck/SteamDeck.cpp b/Source/Core/InputCommon/ControllerInterface/SteamDeck/SteamDeck.cpp index 2ffd741d01..f8615d138b 100644 --- a/Source/Core/InputCommon/ControllerInterface/SteamDeck/SteamDeck.cpp +++ b/Source/Core/InputCommon/ControllerInterface/SteamDeck/SteamDeck.cpp @@ -93,8 +93,8 @@ private: : m_name(name), m_input(input), m_range(range) { } - std::string GetName() const final override { return m_name; } - ControlState GetState() const final override { return ControlState(m_input) / m_range; } + std::string GetName() const final { return m_name; } + ControlState GetState() const final { return ControlState(m_input) / m_range; } private: const char* m_name; diff --git a/Source/Core/InputCommon/ControllerInterface/Wiimote/WiimoteController.cpp b/Source/Core/InputCommon/ControllerInterface/Wiimote/WiimoteController.cpp index c4e5fe028f..9b5fe3c1e9 100644 --- a/Source/Core/InputCommon/ControllerInterface/Wiimote/WiimoteController.cpp +++ b/Source/Core/InputCommon/ControllerInterface/Wiimote/WiimoteController.cpp @@ -51,7 +51,7 @@ public: std::string GetName() const override { return m_name; } - ControlState GetState() const final override { return ControlState(m_value) / m_extent; } + ControlState GetState() const final { return ControlState(m_value) / m_extent; } protected: const T& m_value; diff --git a/Source/Core/InputCommon/ControllerInterface/Wiimote/WiimoteController.h b/Source/Core/InputCommon/ControllerInterface/Wiimote/WiimoteController.h index bc60a1405e..c09a8da5db 100644 --- a/Source/Core/InputCommon/ControllerInterface/Wiimote/WiimoteController.h +++ b/Source/Core/InputCommon/ControllerInterface/Wiimote/WiimoteController.h @@ -29,7 +29,7 @@ class Device final : public Core::Device { public: Device(std::unique_ptr wiimote); - ~Device(); + ~Device() override; std::string GetName() const override; std::string GetSource() const override; diff --git a/Source/Core/InputCommon/ControllerInterface/Win32/Win32.cpp b/Source/Core/InputCommon/ControllerInterface/Win32/Win32.cpp index 36b847aa91..2e69fc80e6 100644 --- a/Source/Core/InputCommon/ControllerInterface/Win32/Win32.cpp +++ b/Source/Core/InputCommon/ControllerInterface/Win32/Win32.cpp @@ -31,7 +31,7 @@ class InputBackend final : public ciface::InputBackend { public: InputBackend(ControllerInterface* controller_interface); - ~InputBackend(); + ~InputBackend() override; void PopulateDevices() override; void HandleWindowChange() override; diff --git a/Source/Core/VideoBackends/D3D/D3DPerfQuery.h b/Source/Core/VideoBackends/D3D/D3DPerfQuery.h index 3d937b0012..5b9a7e262d 100644 --- a/Source/Core/VideoBackends/D3D/D3DPerfQuery.h +++ b/Source/Core/VideoBackends/D3D/D3DPerfQuery.h @@ -13,7 +13,7 @@ class PerfQuery : public PerfQueryBase { public: PerfQuery(); - ~PerfQuery(); + ~PerfQuery() override; void EnableQuery(PerfQueryGroup group) override; void DisableQuery(PerfQueryGroup group) override; diff --git a/Source/Core/VideoBackends/D3D/D3DVertexManager.h b/Source/Core/VideoBackends/D3D/D3DVertexManager.h index 4bdbf34bb0..c406eea12e 100644 --- a/Source/Core/VideoBackends/D3D/D3DVertexManager.h +++ b/Source/Core/VideoBackends/D3D/D3DVertexManager.h @@ -20,7 +20,7 @@ class D3DVertexFormat : public NativeVertexFormat { public: D3DVertexFormat(const PortableVertexDeclaration& vtx_decl); - ~D3DVertexFormat(); + ~D3DVertexFormat() override; ID3D11InputLayout* GetInputLayout(const void* vs_bytecode, size_t vs_bytecode_size); private: @@ -36,9 +36,9 @@ class VertexManager : public VertexManagerBase { public: VertexManager(); - ~VertexManager(); + ~VertexManager() override; - bool Initialize(); + bool Initialize() override; void UploadUtilityUniforms(const void* uniforms, u32 uniforms_size) override; bool UploadTexelBuffer(const void* data, u32 data_size, TexelBufferFormat format, diff --git a/Source/Core/VideoBackends/D3D/DXTexture.h b/Source/Core/VideoBackends/D3D/DXTexture.h index 188908c095..b6af824488 100644 --- a/Source/Core/VideoBackends/D3D/DXTexture.h +++ b/Source/Core/VideoBackends/D3D/DXTexture.h @@ -22,7 +22,7 @@ namespace DX11 class DXTexture final : public AbstractTexture { public: - ~DXTexture(); + ~DXTexture() override; static std::unique_ptr Create(const TextureConfig& config, std::string_view name); static std::unique_ptr CreateAdopted(ComPtr texture); @@ -56,7 +56,7 @@ class DXStagingTexture final : public AbstractStagingTexture { public: DXStagingTexture() = delete; - ~DXStagingTexture(); + ~DXStagingTexture() override; void CopyFromTexture(const AbstractTexture* src, const MathUtil::Rectangle& src_rect, u32 src_layer, u32 src_level, diff --git a/Source/Core/VideoBackends/D3D12/D3D12PerfQuery.h b/Source/Core/VideoBackends/D3D12/D3D12PerfQuery.h index 5f3c725eef..aacdff487a 100644 --- a/Source/Core/VideoBackends/D3D12/D3D12PerfQuery.h +++ b/Source/Core/VideoBackends/D3D12/D3D12PerfQuery.h @@ -13,7 +13,7 @@ class PerfQuery final : public PerfQueryBase { public: PerfQuery(); - ~PerfQuery(); + ~PerfQuery() override; static PerfQuery* GetInstance() { return static_cast(g_perf_query.get()); } diff --git a/Source/Core/VideoBackends/D3D12/D3D12SwapChain.h b/Source/Core/VideoBackends/D3D12/D3D12SwapChain.h index e044412ade..d7db3e7909 100644 --- a/Source/Core/VideoBackends/D3D12/D3D12SwapChain.h +++ b/Source/Core/VideoBackends/D3D12/D3D12SwapChain.h @@ -23,7 +23,7 @@ class SwapChain : public D3DCommon::SwapChain public: SwapChain(const WindowSystemInfo& wsi, IDXGIFactory* dxgi_factory, ID3D12CommandQueue* d3d_command_queue); - ~SwapChain(); + ~SwapChain() override; static std::unique_ptr Create(const WindowSystemInfo& wsi); diff --git a/Source/Core/VideoBackends/D3D12/D3D12VertexManager.h b/Source/Core/VideoBackends/D3D12/D3D12VertexManager.h index 0d6f1811c6..df637f1f53 100644 --- a/Source/Core/VideoBackends/D3D12/D3D12VertexManager.h +++ b/Source/Core/VideoBackends/D3D12/D3D12VertexManager.h @@ -15,7 +15,7 @@ class VertexManager final : public VertexManagerBase { public: VertexManager(); - ~VertexManager(); + ~VertexManager() override; bool Initialize() override; diff --git a/Source/Core/VideoBackends/D3D12/DX12Texture.h b/Source/Core/VideoBackends/D3D12/DX12Texture.h index 19962199a2..14bf55415b 100644 --- a/Source/Core/VideoBackends/D3D12/DX12Texture.h +++ b/Source/Core/VideoBackends/D3D12/DX12Texture.h @@ -20,7 +20,7 @@ namespace DX12 class DXTexture final : public AbstractTexture { public: - ~DXTexture(); + ~DXTexture() override; static std::unique_ptr Create(const TextureConfig& config, std::string_view name); static std::unique_ptr CreateAdopted(ID3D12Resource* resource); @@ -110,7 +110,7 @@ private: class DXStagingTexture final : public AbstractStagingTexture { public: - ~DXStagingTexture(); + ~DXStagingTexture() override; void CopyFromTexture(const AbstractTexture* src, const MathUtil::Rectangle& src_rect, u32 src_layer, u32 src_level, diff --git a/Source/Core/VideoBackends/D3DCommon/Shader.h b/Source/Core/VideoBackends/D3DCommon/Shader.h index 6a2d759cee..c450bf74cb 100644 --- a/Source/Core/VideoBackends/D3DCommon/Shader.h +++ b/Source/Core/VideoBackends/D3DCommon/Shader.h @@ -13,7 +13,7 @@ namespace D3DCommon class Shader : public AbstractShader { public: - virtual ~Shader() override; + ~Shader() override; const BinaryData& GetByteCode() const { return m_bytecode; } diff --git a/Source/Core/VideoBackends/Null/NullGfx.h b/Source/Core/VideoBackends/Null/NullGfx.h index a84b3743d4..5e1a25fef7 100644 --- a/Source/Core/VideoBackends/Null/NullGfx.h +++ b/Source/Core/VideoBackends/Null/NullGfx.h @@ -15,7 +15,7 @@ public: ~NullGfx() override; bool IsHeadless() const override; - virtual bool SupportsUtilityDrawing() const override; + bool SupportsUtilityDrawing() const override; std::unique_ptr CreateTexture(const TextureConfig& config, std::string_view name) override; diff --git a/Source/Core/VideoBackends/Null/NullTexture.h b/Source/Core/VideoBackends/Null/NullTexture.h index 505f843cd0..54e39151eb 100644 --- a/Source/Core/VideoBackends/Null/NullTexture.h +++ b/Source/Core/VideoBackends/Null/NullTexture.h @@ -33,7 +33,7 @@ class NullStagingTexture final : public AbstractStagingTexture { public: explicit NullStagingTexture(StagingTextureType type, const TextureConfig& config); - ~NullStagingTexture(); + ~NullStagingTexture() override; void CopyFromTexture(const AbstractTexture* src, const MathUtil::Rectangle& src_rect, u32 src_layer, u32 src_level, diff --git a/Source/Core/VideoBackends/OGL/OGLGfx.h b/Source/Core/VideoBackends/OGL/OGLGfx.h index 427aa3e559..7914488013 100644 --- a/Source/Core/VideoBackends/OGL/OGLGfx.h +++ b/Source/Core/VideoBackends/OGL/OGLGfx.h @@ -17,7 +17,7 @@ class OGLGfx final : public AbstractGfx { public: OGLGfx(std::unique_ptr main_gl_context, float backbuffer_scale); - ~OGLGfx(); + ~OGLGfx() override; bool IsHeadless() const override; @@ -67,9 +67,9 @@ public: void WaitForGPUIdle() override; void OnConfigChanged(u32 bits) override; - virtual void SelectLeftBuffer() override; - virtual void SelectRightBuffer() override; - virtual void SelectMainBuffer() override; + void SelectLeftBuffer() override; + void SelectRightBuffer() override; + void SelectMainBuffer() override; std::unique_ptr CreateAsyncShaderCompiler() override; diff --git a/Source/Core/VideoBackends/OGL/OGLPerfQuery.h b/Source/Core/VideoBackends/OGL/OGLPerfQuery.h index f593ab5447..166d7ef8a2 100644 --- a/Source/Core/VideoBackends/OGL/OGLPerfQuery.h +++ b/Source/Core/VideoBackends/OGL/OGLPerfQuery.h @@ -18,7 +18,7 @@ class PerfQuery : public PerfQueryBase { public: PerfQuery(); - ~PerfQuery() {} + ~PerfQuery() override {} void EnableQuery(PerfQueryGroup group) override; void DisableQuery(PerfQueryGroup group) override; void ResetQuery() override; @@ -50,7 +50,7 @@ class PerfQueryGL : public PerfQuery { public: PerfQueryGL(GLenum query_type); - ~PerfQueryGL(); + ~PerfQueryGL() override; void EnableQuery(PerfQueryGroup group) override; void DisableQuery(PerfQueryGroup group) override; @@ -68,7 +68,7 @@ class PerfQueryGLESNV : public PerfQuery { public: PerfQueryGLESNV(); - ~PerfQueryGLESNV(); + ~PerfQueryGLESNV() override; void EnableQuery(PerfQueryGroup group) override; void DisableQuery(PerfQueryGroup group) override; diff --git a/Source/Core/VideoBackends/OGL/OGLStreamBuffer.cpp b/Source/Core/VideoBackends/OGL/OGLStreamBuffer.cpp index 1d5deadfcf..1a14833f28 100644 --- a/Source/Core/VideoBackends/OGL/OGLStreamBuffer.cpp +++ b/Source/Core/VideoBackends/OGL/OGLStreamBuffer.cpp @@ -142,7 +142,7 @@ public: glBufferData(m_buffertype, m_size, nullptr, GL_STREAM_DRAW); } - ~MapAndOrphan() {} + ~MapAndOrphan() override {} std::pair Map(u32 size) override { if (m_iterator + size >= m_size) @@ -181,7 +181,7 @@ public: glBufferData(m_buffertype, m_size, nullptr, GL_STREAM_DRAW); } - ~MapAndSync() { DeleteFences(); } + ~MapAndSync() override { DeleteFences(); } std::pair Map(u32 size) override { AllocMemory(size); @@ -234,7 +234,7 @@ public: (coherent ? GL_MAP_COHERENT_BIT : GL_MAP_FLUSH_EXPLICIT_BIT)); } - ~BufferStorage() + ~BufferStorage() override { DeleteFences(); glUnmapBuffer(m_buffertype); @@ -280,7 +280,7 @@ public: glBindBuffer(m_buffertype, m_buffer); } - ~PinnedMemory() + ~PinnedMemory() override { DeleteFences(); glBindBuffer(m_buffertype, 0); @@ -315,7 +315,7 @@ public: m_pointer = new u8[m_size]; } - ~BufferSubData() { delete[] m_pointer; } + ~BufferSubData() override { delete[] m_pointer; } std::pair Map(u32 size) override { return std::make_pair(m_pointer, 0); } void Unmap(u32 used_size) override { glBufferSubData(m_buffertype, 0, used_size, m_pointer); } u8* m_pointer; @@ -335,7 +335,7 @@ public: m_pointer = new u8[m_size]; } - ~BufferData() { delete[] m_pointer; } + ~BufferData() override { delete[] m_pointer; } std::pair Map(u32 size) override { return std::make_pair(m_pointer, 0); } void Unmap(u32 used_size) override { diff --git a/Source/Core/VideoBackends/OGL/OGLTexture.h b/Source/Core/VideoBackends/OGL/OGLTexture.h index eea458c5a1..4106eeffa7 100644 --- a/Source/Core/VideoBackends/OGL/OGLTexture.h +++ b/Source/Core/VideoBackends/OGL/OGLTexture.h @@ -20,7 +20,7 @@ class OGLTexture final : public AbstractTexture { public: explicit OGLTexture(const TextureConfig& tex_config, std::string_view name); - ~OGLTexture(); + ~OGLTexture() override; void CopyRectangleFromTexture(const AbstractTexture* src, const MathUtil::Rectangle& src_rect, u32 src_layer, @@ -71,7 +71,7 @@ class OGLStagingTexture final : public AbstractStagingTexture { public: OGLStagingTexture() = delete; - ~OGLStagingTexture(); + ~OGLStagingTexture() override; void CopyFromTexture(const AbstractTexture* src, const MathUtil::Rectangle& src_rect, u32 src_layer, u32 src_level, diff --git a/Source/Core/VideoBackends/OGL/OGLVertexManager.h b/Source/Core/VideoBackends/OGL/OGLVertexManager.h index bc79efc149..f597b159c5 100644 --- a/Source/Core/VideoBackends/OGL/OGLVertexManager.h +++ b/Source/Core/VideoBackends/OGL/OGLVertexManager.h @@ -18,7 +18,7 @@ class GLVertexFormat : public NativeVertexFormat { public: GLVertexFormat(const PortableVertexDeclaration& vtx_decl); - ~GLVertexFormat(); + ~GLVertexFormat() override; GLuint VAO; }; diff --git a/Source/Core/VideoBackends/Software/SWGfx.cpp b/Source/Core/VideoBackends/Software/SWGfx.cpp index bfe7f95421..c758d1819e 100644 --- a/Source/Core/VideoBackends/Software/SWGfx.cpp +++ b/Source/Core/VideoBackends/Software/SWGfx.cpp @@ -71,7 +71,7 @@ class SWShader final : public AbstractShader { public: explicit SWShader(ShaderStage stage) : AbstractShader(stage) {} - ~SWShader() = default; + ~SWShader() override = default; BinaryData GetBinary() const override { return {}; } }; diff --git a/Source/Core/VideoBackends/Software/SWGfx.h b/Source/Core/VideoBackends/Software/SWGfx.h index 83773eccdb..2ea36de5d8 100644 --- a/Source/Core/VideoBackends/Software/SWGfx.h +++ b/Source/Core/VideoBackends/Software/SWGfx.h @@ -16,7 +16,7 @@ public: ~SWGfx() override; bool IsHeadless() const override; - virtual bool SupportsUtilityDrawing() const override; + bool SupportsUtilityDrawing() const override; std::unique_ptr CreateTexture(const TextureConfig& config, std::string_view name) override; diff --git a/Source/Core/VideoBackends/Software/SWTexture.h b/Source/Core/VideoBackends/Software/SWTexture.h index 9332dccb98..89f5fa136f 100644 --- a/Source/Core/VideoBackends/Software/SWTexture.h +++ b/Source/Core/VideoBackends/Software/SWTexture.h @@ -18,7 +18,7 @@ class SWTexture final : public AbstractTexture { public: explicit SWTexture(const TextureConfig& tex_config); - ~SWTexture() = default; + ~SWTexture() override = default; void CopyRectangleFromTexture(const AbstractTexture* src, const MathUtil::Rectangle& src_rect, u32 src_layer, @@ -40,7 +40,7 @@ class SWStagingTexture final : public AbstractStagingTexture { public: explicit SWStagingTexture(StagingTextureType type, const TextureConfig& config); - ~SWStagingTexture(); + ~SWStagingTexture() override; void CopyFromTexture(const AbstractTexture* src, const MathUtil::Rectangle& src_rect, u32 src_layer, u32 src_level, diff --git a/Source/Core/VideoBackends/Software/SWVertexLoader.h b/Source/Core/VideoBackends/Software/SWVertexLoader.h index 59b6ca65fd..604e18d194 100644 --- a/Source/Core/VideoBackends/Software/SWVertexLoader.h +++ b/Source/Core/VideoBackends/Software/SWVertexLoader.h @@ -17,7 +17,7 @@ class SWVertexLoader final : public VertexManagerBase { public: SWVertexLoader(); - ~SWVertexLoader(); + ~SWVertexLoader() override; DataReader PrepareForAdditionalData(OpcodeDecoder::Primitive primitive, u32 count, u32 stride, bool cullall) override; diff --git a/Source/Core/VideoBackends/Software/SWmain.cpp b/Source/Core/VideoBackends/Software/SWmain.cpp index 6878075dad..51c714ad2d 100644 --- a/Source/Core/VideoBackends/Software/SWmain.cpp +++ b/Source/Core/VideoBackends/Software/SWmain.cpp @@ -29,7 +29,7 @@ class PerfQuery : public PerfQueryBase { public: PerfQuery() {} - ~PerfQuery() {} + ~PerfQuery() override {} void EnableQuery(PerfQueryGroup type) override {} void DisableQuery(PerfQueryGroup type) override {} void ResetQuery() override { EfbInterface::ResetPerfQuery(); } diff --git a/Source/Core/VideoBackends/Vulkan/VKGfx.h b/Source/Core/VideoBackends/Vulkan/VKGfx.h index f2e411a9f6..209ea92913 100644 --- a/Source/Core/VideoBackends/Vulkan/VKGfx.h +++ b/Source/Core/VideoBackends/Vulkan/VKGfx.h @@ -79,7 +79,7 @@ public: void SetFullscreen(bool enable_fullscreen) override; bool IsFullscreen() const override; - virtual SurfaceInfo GetSurfaceInfo() const override; + SurfaceInfo GetSurfaceInfo() const override; // Completes the current render pass, executes the command buffer, and restores state ready for // next render. Use when you want to kick the current buffer to make room for new data. diff --git a/Source/Core/VideoBackends/Vulkan/VKPerfQuery.h b/Source/Core/VideoBackends/Vulkan/VKPerfQuery.h index a8d31f57e8..8d0022bd71 100644 --- a/Source/Core/VideoBackends/Vulkan/VKPerfQuery.h +++ b/Source/Core/VideoBackends/Vulkan/VKPerfQuery.h @@ -16,7 +16,7 @@ class PerfQuery : public PerfQueryBase { public: PerfQuery(); - ~PerfQuery(); + ~PerfQuery() override; static PerfQuery* GetInstance() { return static_cast(g_perf_query.get()); } diff --git a/Source/Core/VideoBackends/Vulkan/VKTexture.h b/Source/Core/VideoBackends/Vulkan/VKTexture.h index b675e593fe..c868087dae 100644 --- a/Source/Core/VideoBackends/Vulkan/VKTexture.h +++ b/Source/Core/VideoBackends/Vulkan/VKTexture.h @@ -33,7 +33,7 @@ public: VKTexture(const TextureConfig& tex_config, VmaAllocation alloc, VkImage image, std::string_view name, VkImageLayout layout = VK_IMAGE_LAYOUT_UNDEFINED, ComputeImageLayout compute_layout = ComputeImageLayout::Undefined); - ~VKTexture(); + ~VKTexture() override; static VkFormat GetLinearFormat(VkFormat format); static VkFormat GetVkFormatForHostTextureFormat(AbstractTextureFormat format); @@ -93,7 +93,7 @@ public: std::unique_ptr buffer, VkImage linear_image, VmaAllocation linear_image_alloc); - ~VKStagingTexture(); + ~VKStagingTexture() override; void CopyFromTexture(const AbstractTexture* src, const MathUtil::Rectangle& src_rect, u32 src_layer, u32 src_level, diff --git a/Source/Core/VideoBackends/Vulkan/VKVertexManager.h b/Source/Core/VideoBackends/Vulkan/VKVertexManager.h index 3847529d86..75d35c0d32 100644 --- a/Source/Core/VideoBackends/Vulkan/VKVertexManager.h +++ b/Source/Core/VideoBackends/Vulkan/VKVertexManager.h @@ -18,7 +18,7 @@ class VertexManager : public VertexManagerBase { public: VertexManager(); - ~VertexManager(); + ~VertexManager() override; bool Initialize() override; diff --git a/Source/Core/VideoCommon/FreeLookCamera.h b/Source/Core/VideoCommon/FreeLookCamera.h index fa62742bd2..f1ae46ce4d 100644 --- a/Source/Core/VideoCommon/FreeLookCamera.h +++ b/Source/Core/VideoCommon/FreeLookCamera.h @@ -37,14 +37,14 @@ public: class CameraControllerInput : public CameraController { public: - Common::Vec2 GetFieldOfViewMultiplier() const final override; + Common::Vec2 GetFieldOfViewMultiplier() const final; void DoState(PointerWrap& p) override; - bool IsDirty() const final override { return m_dirty; } - void SetClean() final override { m_dirty = false; } + bool IsDirty() const final { return m_dirty; } + void SetClean() final { m_dirty = false; } - bool SupportsInput() const final override { return true; } + bool SupportsInput() const final { return true; } virtual void MoveVertical(float amt) = 0; virtual void MoveHorizontal(float amt) = 0;