From 18f0bd1d4b31204eb858f8c6e540f3f300a4e688 Mon Sep 17 00:00:00 2001 From: Tillmann Karras Date: Mon, 25 Aug 2025 20:21:25 +0100 Subject: [PATCH 1/3] VI: set default overclock factor to 1.0 GetTicksPerHalfLine() gets called via Preset() before RefreshConfig() has a chance to replace the dummy value 0.0. Thank you, UB-san. --- Source/Core/Core/HW/VideoInterface.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/Core/HW/VideoInterface.h b/Source/Core/Core/HW/VideoInterface.h index baffd7b58d..8a54243660 100644 --- a/Source/Core/Core/HW/VideoInterface.h +++ b/Source/Core/Core/HW/VideoInterface.h @@ -454,7 +454,7 @@ private: u32 m_even_field_last_hl = 0; // index last halfline of the even field u32 m_odd_field_last_hl = 0; // index last halfline of the odd field - float m_config_vi_oc_factor = 0.0f; + float m_config_vi_oc_factor = 1.0f; Config::ConfigChangedCallbackID m_config_changed_callback_id; Core::System& m_system; From 63257d1ee9773e55c058ad65700cbfb212fd70fe Mon Sep 17 00:00:00 2001 From: Tillmann Karras Date: Sat, 30 Aug 2025 03:04:43 +0100 Subject: [PATCH 2/3] CoreTiming: set default overclock factors to 1.0 I'm not aware of any issue here but let's set meaningful defaults anyway. --- Source/Core/Core/CoreTiming.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Core/Core/CoreTiming.h b/Source/Core/Core/CoreTiming.h index 84311291ec..25df6d6c90 100644 --- a/Source/Core/Core/CoreTiming.h +++ b/Source/Core/Core/CoreTiming.h @@ -203,8 +203,8 @@ private: EventType* m_ev_lost = nullptr; CPUThreadConfigCallback::ConfigChangedCallbackID m_registered_config_callback_id; - float m_config_oc_factor = 0.0f; - float m_config_oc_inv_factor = 0.0f; + float m_config_oc_factor = 1.0f; + float m_config_oc_inv_factor = 1.0f; bool m_config_sync_on_skip_idle = false; s64 m_throttle_reference_cycle = 0; From c248f1afa4187e5f7bebb8cbbcb66f83d5e3b6ad Mon Sep 17 00:00:00 2001 From: Tillmann Karras Date: Mon, 25 Aug 2025 20:17:31 +0100 Subject: [PATCH 3/3] IOS/WD: fix wrong BitSet ctor being called We don't want list initialization here. Thank you, UB-san. --- Source/Core/Core/IOS/Network/WD/Command.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/Core/IOS/Network/WD/Command.cpp b/Source/Core/Core/IOS/Network/WD/Command.cpp index ea788a7052..676650c660 100644 --- a/Source/Core/Core/IOS/Network/WD/Command.cpp +++ b/Source/Core/Core/IOS/Network/WD/Command.cpp @@ -28,7 +28,7 @@ constexpr u16 LegalNitroChannelMask = 0b0011'1111'1111'1110u; u16 SelectWifiChannel(u16 enabled_channels_mask, u16 current_channel) { - const Common::BitSet enabled_channels{enabled_channels_mask & LegalChannelMask}; + const Common::BitSet enabled_channels(enabled_channels_mask & LegalChannelMask); u16 next_channel = current_channel; for (int i = 0; i < 16; ++i) {