dolphin-emu/dolphin
1
0
Fork 1
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-06-25 03:21:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13765 from TryTwo/CodeWidget_clear_unused

Browse Source 
CodeWidget: Clear calls/callers if no symbol exists.
This commit is contained in:
JMC47
2025-06-22 01:05:59 -04:00
committed by GitHub
parent 19f3b7e61f 10c3b0b4e4
commit c2aaca2b16
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
Source/Core/DolphinQt/Debugger/CodeWidget.cpp
View File

@ -242,11 +242,10 @@ void CodeWidget::OnPPCSymbolsChanged()
UpdateSymbols(); UpdateSymbols();
UpdateNotes(); UpdateNotes();
UpdateCallstack(); UpdateCallstack();
if (const Common::Symbol* symbol = m_ppc_symbol_db.GetSymbolFromAddr(m_code_view->GetAddress()))
{ const Common::Symbol* symbol = m_ppc_symbol_db.GetSymbolFromAddr(m_code_view->GetAddress());
UpdateFunctionCalls(symbol); UpdateFunctionCalls(symbol);
UpdateFunctionCallers(symbol); UpdateFunctionCallers(symbol);
}
} }
void CodeWidget::ActivateSearchAddress() void CodeWidget::ActivateSearchAddress()
@ -373,9 +372,6 @@ void CodeWidget::Update()
m_code_view->Update(); m_code_view->Update();
m_code_view->setFocus(); m_code_view->setFocus();
if (!symbol)
return;
UpdateFunctionCalls(symbol); UpdateFunctionCalls(symbol);
UpdateFunctionCallers(symbol); UpdateFunctionCallers(symbol);
} }
@ -470,6 +466,9 @@ void CodeWidget::UpdateNotes()
void CodeWidget::UpdateFunctionCalls(const Common::Symbol* symbol) void CodeWidget::UpdateFunctionCalls(const Common::Symbol* symbol)
{ {
m_function_calls_list->clear(); m_function_calls_list->clear();
if (symbol == nullptr)
return;
const QString filter = m_search_calls->text(); const QString filter = m_search_calls->text();
for (const auto& call : symbol->calls) for (const auto& call : symbol->calls)
@ -504,6 +503,9 @@ void CodeWidget::UpdateFunctionCalls(const Common::Symbol* symbol)
void CodeWidget::UpdateFunctionCallers(const Common::Symbol* symbol) void CodeWidget::UpdateFunctionCallers(const Common::Symbol* symbol)
{ {
m_function_callers_list->clear(); m_function_callers_list->clear();
if (symbol == nullptr)
return;
const QString filter = m_search_callers->text(); const QString filter = m_search_callers->text();
for (const auto& caller : symbol->callers) for (const auto& caller : symbol->callers)