espressif/arduino-esp32
1
0
Fork 1
mirror of https://github.com/0xFEEDC0DE64/arduino-esp32.git synced 2025-07-30 18:57:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

[USB CDC] Fix data might not be transmitted until more is written (#5652)

Browse Source 
Depending on `tud_cdc_tx_complete_cb` can cause in some cases the last packet to not be transmitted until more data is written and flushed. It's a rare case, but if the other end is expecting those last bytes, transmission will hang.

This PR also fixes debug output on CDC
This commit is contained in:
Me No Dev
2021-09-15 15:23:11 +03:00
committed by GitHub
parent 6dfaf6cdd4
commit 541cef9149
2 changed files with 89 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cores/esp32/USBCDC.h
View File

@ -18,6 +18,9 @@
#include <inttypes.h>
#include "esp_event.h"
#include "freertos/FreeRTOS.h"
#include "freertos/queue.h"
#include "freertos/semphr.h"
#include "Stream.h"
ESP_EVENT_DECLARE_BASE(ARDUINO_USB_CDC_EVENTS);
@ -58,7 +61,8 @@ public:
void onEvent(esp_event_handler_t callback);
void onEvent(arduino_usb_cdc_event_t event, esp_event_handler_t callback);
size_t setRxBufferSize(size_t);
size_t setRxBufferSize(size_t size);
void setTxTimeoutMs(uint32_t timeout);
void begin(unsigned long baud=0);
void end();
@ -113,7 +117,6 @@ public:
void _onRX(void);
void _onTX(void);
void _onUnplugged(void);
xSemaphoreHandle tx_sem;
protected:
uint8_t itf;
@ -126,6 +129,8 @@ protected:
bool connected;
bool reboot_enable;
xQueueHandle rx_queue;
xSemaphoreHandle tx_lock;
uint32_t tx_timeout_ms;
};