From deaf339bde33e5ed3048d70d5b3f8bb1ff0676d4 Mon Sep 17 00:00:00 2001 From: bperrybap Date: Mon, 19 Nov 2018 09:40:14 -0600 Subject: [PATCH] Wire endTransmission() fix for issue #1725 (#1888) * removed uint8_t Wire.endTransmission(uint8_t sendStop) Having both endTransmission(bool) and endTransmission(uint8_t) creates problems. There is no need for endTransmission(uint8_t) endTransmission(1) and endTransmission(0) works with endTransmission(bool). Removing endTransmission(uint8_t) allows the ESP32 code to be compatible with all the other Arduino cores by allowing endTransmission(1) and endTranmission(0) to work as it does on all the other cores. * Wire library version bump for endTransmission() update --- libraries/Wire/library.properties | 2 +- libraries/Wire/src/Wire.cpp | 5 ----- libraries/Wire/src/Wire.h | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/libraries/Wire/library.properties b/libraries/Wire/library.properties index ef29154c..099cf6f0 100644 --- a/libraries/Wire/library.properties +++ b/libraries/Wire/library.properties @@ -1,5 +1,5 @@ name=Wire -version=1.0 +version=1.0.1 author=Hristo Gochkov maintainer=Hristo Gochkov sentence=Allows the communication between devices or sensors connected via Two Wire Interface Bus. For esp8266 boards. diff --git a/libraries/Wire/src/Wire.cpp b/libraries/Wire/src/Wire.cpp index cebdbde5..87ed627b 100644 --- a/libraries/Wire/src/Wire.cpp +++ b/libraries/Wire/src/Wire.cpp @@ -308,11 +308,6 @@ uint8_t TwoWire::endTransmission(void) return endTransmission(true); } -uint8_t TwoWire::endTransmission(uint8_t sendStop) -{ - return endTransmission(static_cast(sendStop)); -} - /* stickbreaker Nov2017 better error reporting */ uint8_t TwoWire::lastError() diff --git a/libraries/Wire/src/Wire.h b/libraries/Wire/src/Wire.h index e9172005..34bdd60a 100644 --- a/libraries/Wire/src/Wire.h +++ b/libraries/Wire/src/Wire.h @@ -87,7 +87,6 @@ public: void beginTransmission(int address); uint8_t endTransmission(bool sendStop); - uint8_t endTransmission(uint8_t sendStop); uint8_t endTransmission(void); uint8_t requestFrom(uint16_t address, uint8_t size, bool sendStop);