espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-07-31 19:24:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

esp_https_ota: Add check for HTTP error codes and corresponding error logs

Browse Source 
Closes: https://github.com/espressif/esp-idf/issues/7058
This commit is contained in:
Shubham Kulkarni
2021-05-24 11:41:50 +05:30
committed by Mahavir Jain
parent 82c6e0628a
commit 01f05da3ae
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
components/esp_http_client/include/esp_http_client.h
View File

@@ -151,6 +151,7 @@ typedef enum {
HttpStatus_TemporaryRedirect = 307, HttpStatus_TemporaryRedirect = 307,
/* 4xx - Client Error */ /* 4xx - Client Error */
HttpStatus_BadRequest = 400,
HttpStatus_Unauthorized = 401, HttpStatus_Unauthorized = 401,
HttpStatus_Forbidden = 403, HttpStatus_Forbidden = 403,
HttpStatus_NotFound = 404, HttpStatus_NotFound = 404,

7
components/esp_https_ota/src/esp_https_ota.c
View File

@@ -73,8 +73,11 @@ static esp_err_t _http_handle_response_code(esp_http_client_handle_t http_client
} else if(status_code == HttpStatus_NotFound || status_code == HttpStatus_Forbidden) { } else if(status_code == HttpStatus_NotFound || status_code == HttpStatus_Forbidden) {
ESP_LOGE(TAG, "File not found(%d)", status_code); ESP_LOGE(TAG, "File not found(%d)", status_code);
return ESP_FAIL; return ESP_FAIL;
} else if (status_code == HttpStatus_InternalError) { } else if (status_code >= HttpStatus_BadRequest && status_code < HttpStatus_InternalError) {
ESP_LOGE(TAG, "Server error occurred(%d)", status_code); ESP_LOGE(TAG, "Client error (%d)", status_code);
return ESP_FAIL;
} else if (status_code >= HttpStatus_InternalError) {
ESP_LOGE(TAG, "Server error (%d)", status_code);
return ESP_FAIL; return ESP_FAIL;
} }