espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-08-02 04:04:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

can: Fix semaphore take in critical section

Browse Source 
This commit fixes can_reconfigure_alerts() which
could lead to a call to xSemaphoreTake() whilst
inside a critical section.
This commit is contained in:
Darian Leung
2019-12-20 21:57:26 +08:00
parent 4741e6787d
commit 05adedcc72
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
components/driver/can.c
View File

@@ -957,15 +957,16 @@ esp_err_t can_read_alerts(uint32_t *alerts, TickType_t ticks_to_wait)
esp_err_t can_reconfigure_alerts(uint32_t alerts_enabled, uint32_t *current_alerts) esp_err_t can_reconfigure_alerts(uint32_t alerts_enabled, uint32_t *current_alerts)
{ {
CAN_CHECK(p_can_obj != NULL, ESP_ERR_INVALID_STATE); CAN_CHECK(p_can_obj != NULL, ESP_ERR_INVALID_STATE);
CAN_ENTER_CRITICAL(); CAN_ENTER_CRITICAL();
uint32_t cur_alerts; //Clear any unhandled alerts
can_read_alerts(&cur_alerts, 0); //Clear any unhandled alerts if (current_alerts != NULL) {
*current_alerts = p_can_obj->alerts_triggered;;
}
p_can_obj->alerts_triggered = 0;
p_can_obj->alerts_enabled = alerts_enabled; //Update enabled alerts p_can_obj->alerts_enabled = alerts_enabled; //Update enabled alerts
CAN_EXIT_CRITICAL(); CAN_EXIT_CRITICAL();
if (current_alerts != NULL) {
*current_alerts = cur_alerts;
}
return ESP_OK; return ESP_OK;
} }