From 5bdbfd1d05ea38f5858abaa04477391758c4a7f0 Mon Sep 17 00:00:00 2001 From: yuanjm Date: Fri, 27 Aug 2021 17:17:56 +0800 Subject: [PATCH 1/2] Revert "Merge branch 'bugfix/fix_ws_handle_big_messages_error' into 'master'" This reverts commit d838a11d78c2df2e1e163953dbe0cd880c68a3a5, reversing changes made to 70fd8529e9705df55ea3a391107cdf49d80f3f3d. --- components/esp_http_server/src/httpd_ws.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/components/esp_http_server/src/httpd_ws.c b/components/esp_http_server/src/httpd_ws.c index c4dd8c07e3..c2f0ad581d 100644 --- a/components/esp_http_server/src/httpd_ws.c +++ b/components/esp_http_server/src/httpd_ws.c @@ -328,15 +328,9 @@ esp_err_t httpd_ws_recv_frame(httpd_req_t *req, httpd_ws_frame_t *frame, size_t return ESP_FAIL; } - int read_len = 0, left_len = frame->len; - while (left_len > 0) { - if ((read_len = httpd_recv_with_opt(req, (char *)frame->payload + read_len, left_len, false)) <= 0) { - ESP_LOGW(TAG, LOG_FMT("Failed to receive payload")); - return ESP_FAIL; - } - if (left_len -= read_len) { - ESP_LOGD(TAG, "recv data length is less than the data length we want. Read again!"); - } + if (httpd_recv_with_opt(req, (char *)frame->payload, frame->len, false) <= 0) { + ESP_LOGW(TAG, LOG_FMT("Failed to receive payload")); + return ESP_FAIL; } /* Unmask payload */ From 5db3853c2cfb0c1ae2087367db02168c280bb423 Mon Sep 17 00:00:00 2001 From: yuanjm Date: Fri, 27 Aug 2021 17:20:14 +0800 Subject: [PATCH 2/2] esp_http_server: Fix ws server handle length over 1440(MTU) messages incorrectly. Closes https://github.com/espressif/esp-idf/issues/7457 --- components/esp_http_server/src/httpd_ws.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/components/esp_http_server/src/httpd_ws.c b/components/esp_http_server/src/httpd_ws.c index c2f0ad581d..d4597b464b 100644 --- a/components/esp_http_server/src/httpd_ws.c +++ b/components/esp_http_server/src/httpd_ws.c @@ -328,9 +328,19 @@ esp_err_t httpd_ws_recv_frame(httpd_req_t *req, httpd_ws_frame_t *frame, size_t return ESP_FAIL; } - if (httpd_recv_with_opt(req, (char *)frame->payload, frame->len, false) <= 0) { - ESP_LOGW(TAG, LOG_FMT("Failed to receive payload")); - return ESP_FAIL; + size_t left_len = frame->len; + size_t offset = 0; + + while (left_len > 0) { + int read_len = httpd_recv_with_opt(req, (char *)frame->payload + offset, left_len, false); + if (read_len <= 0) { + ESP_LOGW(TAG, LOG_FMT("Failed to receive payload")); + return ESP_FAIL; + } + offset += read_len; + left_len -= read_len; + + ESP_LOGD(TAG, "Frame length: %d, Bytes Read: %d", frame->len, offset); } /* Unmask payload */