espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-08-06 14:14:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'bugfix/fix_coverity_issue_in_esp_http_client' into 'master'

Browse Source 
esp_http_client: free `auth_str` before going out of scope

See merge request espressif/esp-idf!22014
This commit is contained in:
Mahavir Jain
2023-01-12 21:09:20 +08:00
parent d1b8da74d8 3152fba654
commit 1a8a06775d
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
components/esp_http_client/lib/http_auth.c
View File

@@ -126,12 +126,13 @@ char *http_auth_digest(const char *username, const char *password, esp_http_auth
} }
if (auth_data->opaque) { if (auth_data->opaque) {
rc = asprintf(&temp_auth_str, "%s, opaque=\"%s\"", auth_str, auth_data->opaque); rc = asprintf(&temp_auth_str, "%s, opaque=\"%s\"", auth_str, auth_data->opaque);
// Free the previous memory allocated for `auth_str`
free(auth_str);
if (rc < 0) { if (rc < 0) {
ESP_LOGE(TAG, "asprintf() returned: %d", rc); ESP_LOGE(TAG, "asprintf() returned: %d", rc);
ret = ESP_FAIL; ret = ESP_FAIL;
goto _digest_exit; goto _digest_exit;
} }
free(auth_str);
auth_str = temp_auth_str; auth_str = temp_auth_str;
} }
_digest_exit: _digest_exit: