From 9d1c62becbcbaadd1c91a01c9187e9c3bea814b5 Mon Sep 17 00:00:00 2001 From: Frantisek Hrbata Date: Thu, 19 Jan 2023 17:46:28 +0100 Subject: [PATCH] tools: fix idf.py gdb memory access before remote target is connected Currently loading of esp32s3 ROM ELF symbols fails with "Cannot access memory at address 0x3ff194ad". Let's perform add-symbol-file after connection to the target. Signed-off-by: Frantisek Hrbata --- tools/idf_py_actions/debug_ext.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tools/idf_py_actions/debug_ext.py b/tools/idf_py_actions/debug_ext.py index 91cdd4c34b..5e00d02fd5 100644 --- a/tools/idf_py_actions/debug_ext.py +++ b/tools/idf_py_actions/debug_ext.py @@ -247,9 +247,7 @@ def action_extensions(base_actions: Dict, project_path: str) -> Dict: print(f'Warning: {msg_body}') return f'# {msg_body}' r = ['', f'# Load {target} ROM ELF symbols'] - is_one_revision = len(roms[target]) == 1 - if not is_one_revision: - r.append('define target hookpost-remote') + r.append('define target hookpost-remote') r.append('set confirm off') # Since GDB does not have 'else if' statement than we use nested 'if..else' instead. for i, k in enumerate(roms[target], 1): @@ -273,8 +271,7 @@ def action_extensions(base_actions: Dict, project_path: str) -> Dict: for i in range(len(roms[target]), 0, -1): r.append(indent('end', base_ident * i)) r.append('set confirm on') - if not is_one_revision: - r.append('end') + r.append('end') r.append('') return os.linesep.join(r) raise FatalError(f'{ESP_ROM_INFO_FILE} file not found. Please check IDF integrity.')