From 3955a85a475ba494d72e994b8afca8caadeda754 Mon Sep 17 00:00:00 2001 From: Mahavir Jain Date: Thu, 1 Sep 2022 15:24:19 +0530 Subject: [PATCH] wifi_provisioning: decouple `wifi_prov_mgr_is_provisioned` from manager state `wifi_prov_mgr_is_provisioned()` API uses the `esp_wifi_get_config()` API to check if Wi-Fi credentials are configured. It does not really require any other information from the wifi_prov component. Hence, this commit removed dependency of this API on provisioning manager initialization state. Closes IDF-5878 --- .../wifi_provisioning/include/wifi_provisioning/manager.h | 1 - components/wifi_provisioning/src/manager.c | 5 ----- 2 files changed, 6 deletions(-) diff --git a/components/wifi_provisioning/include/wifi_provisioning/manager.h b/components/wifi_provisioning/include/wifi_provisioning/manager.h index e65ef3ea70..378454f721 100644 --- a/components/wifi_provisioning/include/wifi_provisioning/manager.h +++ b/components/wifi_provisioning/include/wifi_provisioning/manager.h @@ -266,7 +266,6 @@ void wifi_prov_mgr_deinit(void); * - ESP_OK : Retrieved provision state successfully * - ESP_FAIL : Wi-Fi not initialized * - ESP_ERR_INVALID_ARG : Null argument supplied - * - ESP_ERR_INVALID_STATE : Manager not initialized */ esp_err_t wifi_prov_mgr_is_provisioned(bool *provisioned); diff --git a/components/wifi_provisioning/src/manager.c b/components/wifi_provisioning/src/manager.c index d75aa60325..8d54250c98 100644 --- a/components/wifi_provisioning/src/manager.c +++ b/components/wifi_provisioning/src/manager.c @@ -1112,11 +1112,6 @@ esp_err_t wifi_prov_mgr_is_provisioned(bool *provisioned) *provisioned = false; - if (!prov_ctx_lock) { - ESP_LOGE(TAG, "Provisioning manager not initialized"); - return ESP_ERR_INVALID_STATE; - } - /* Get Wi-Fi Station configuration */ wifi_config_t wifi_cfg; if (esp_wifi_get_config(WIFI_IF_STA, &wifi_cfg) != ESP_OK) {