espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-07-30 02:37:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

[bt] fix if allocation fails

Browse Source 
If osi_malloc fails for work_queues or osi_work_queue_create fails, osi_work_queue_delete in _err may release unallocated memory.
This commit is contained in:
tgotic
2022-10-13 18:02:11 +02:00
committed by Jin Cheng
parent dd62e3bb9b
commit 416f9b0cea
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
components/bt/common/osi/thread.c
View File

@ -214,17 +214,17 @@ osi_thread_t *osi_thread_create(const char *name, size_t stack_size, int priorit
return NULL; return NULL;
} }
osi_thread_t *thread = (osi_thread_t *)osi_malloc(sizeof(osi_thread_t)); osi_thread_t *thread = (osi_thread_t *)osi_calloc(sizeof(osi_thread_t));
if (thread == NULL) { if (thread == NULL) {
goto _err; goto _err;
} }
thread->stop = false; thread->stop = false;
thread->work_queue_num = work_queue_num; thread->work_queues = (struct work_queue **)osi_calloc(sizeof(struct work_queue *) * work_queue_num);
thread->work_queues = (struct work_queue **)osi_malloc(sizeof(struct work_queue *) * work_queue_num);
if (thread->work_queues == NULL) { if (thread->work_queues == NULL) {
goto _err; goto _err;
} }
thread->work_queue_num = work_queue_num;
for (int i = 0; i < thread->work_queue_num; i++) { for (int i = 0; i < thread->work_queue_num; i++) {
size_t queue_len = work_queue_len[i] ? work_queue_len[i] : DEFAULT_WORK_QUEUE_CAPACITY; size_t queue_len = work_queue_len[i] ? work_queue_len[i] : DEFAULT_WORK_QUEUE_CAPACITY;