From 460df92e8549e0bd57a1bb2a0300ec8f73b226bf Mon Sep 17 00:00:00 2001 From: Axel Lin Date: Fri, 16 Apr 2021 08:33:59 +0800 Subject: [PATCH] esp_https_ota: Fix build warning when CONFIG_OTA_ALLOW_HTTP is set Fix below build warning when CONFIG_OTA_ALLOW_HTTP is set: esp_https_ota.c:165:13: warning: 'is_server_verification_enabled' defined but not used [-Wunused-function] While at it, also simplify the is_server_verification_enabled logic. Fixes: 48987ad9df35 ("esp_https_ota: Enable option of using global_ca_store and x509_crt_bundle") Signed-off-by: Axel Lin Closes https://github.com/espressif/esp-idf/pull/6882 Signed-off-by: Aditya Patwardhan --- components/esp_https_ota/src/esp_https_ota.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/components/esp_https_ota/src/esp_https_ota.c b/components/esp_https_ota/src/esp_https_ota.c index 91fdfaaa88..82f44508e7 100644 --- a/components/esp_https_ota/src/esp_https_ota.c +++ b/components/esp_https_ota/src/esp_https_ota.c @@ -160,11 +160,13 @@ static esp_err_t _ota_write(esp_https_ota_t *https_ota_handle, const void *buffe return err; } +#if !CONFIG_OTA_ALLOW_HTTP static bool is_server_verification_enabled(esp_https_ota_config_t *ota_config) { return (ota_config->http_config->cert_pem || ota_config->http_config->use_global_ca_store - || !(ota_config->http_config->crt_bundle_attach == NULL)); + || ota_config->http_config->crt_bundle_attach != NULL); } +#endif esp_err_t esp_https_ota_begin(esp_https_ota_config_t *ota_config, esp_https_ota_handle_t *handle) {