From 46df25cc8b24c56aff7dc2b73e8a6b01e6761db7 Mon Sep 17 00:00:00 2001 From: Roland Dobai Date: Thu, 25 Aug 2022 14:53:41 +0200 Subject: [PATCH] Tools: Disable idf.py hints for IDF Monitor The feature will be re-enabled later after a proper fix for the following Github issue. Closes https://github.com/espressif/esp-idf/issues/9610 --- docs/en/api-guides/tools/idf-py.rst | 2 +- tools/idf_py_actions/serial_ext.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/en/api-guides/tools/idf-py.rst b/docs/en/api-guides/tools/idf-py.rst index 8f4cfc9102..9bdf505fdb 100644 --- a/docs/en/api-guides/tools/idf-py.rst +++ b/docs/en/api-guides/tools/idf-py.rst @@ -146,7 +146,7 @@ or partition table as applicable. Hints on how to resolve errors ============================== -``idf.py`` will try to suggest hints on how to resolve errors. It works with a database of hints stored in :idf_file:`tools/idf_py_actions/hints.yml` and the hints will be printed if a match is found for the given error. The menuconfig, gdb and openocd targets are not supported at the moment by automatic hints on resolving errors. +``idf.py`` will try to suggest hints on how to resolve errors. It works with a database of hints stored in :idf_file:`tools/idf_py_actions/hints.yml` and the hints will be printed if a match is found for the given error. The monitor, menuconfig, gdb and openocd targets are not supported at the moment by automatic hints on resolving errors. The ``--no-hints`` argument of ``idf.py`` can be used to turn the hints off in case they are not desired. diff --git a/tools/idf_py_actions/serial_ext.py b/tools/idf_py_actions/serial_ext.py index 70a51ec54f..51dd9f6ca6 100644 --- a/tools/idf_py_actions/serial_ext.py +++ b/tools/idf_py_actions/serial_ext.py @@ -154,7 +154,7 @@ def action_extensions(base_actions: Dict, project_path: str) -> Dict: idf_py = [PYTHON] + _get_commandline_options(ctx) # commands to re-run idf.py monitor_args += ['-m', ' '.join("'%s'" % a for a in idf_py)] - hints = not args.no_hints + hints = False # Temporarily disabled because of https://github.com/espressif/esp-idf/issues/9610 RunTool('idf_monitor', monitor_args, args.project_dir, build_dir=args.build_dir, hints=hints, interactive=True)()