From ce4a9014604c37d05f17b4b0959d8e1b7baf1459 Mon Sep 17 00:00:00 2001 From: "nilesh.kale" Date: Wed, 6 Aug 2025 15:38:25 +0530 Subject: [PATCH] fix(esp_http_client): fixed regression issue during enabling digest auth in client This commit solved the issue introduced in commit a0bcffcce945260570ae5503e140cb2f124e8389 for enabling digest auth for esp_http_client. Closes https://github.com/espressif/esp-idf/issues/17238 --- components/esp_http_client/esp_http_client.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/components/esp_http_client/esp_http_client.c b/components/esp_http_client/esp_http_client.c index ad07ade5ab..6a2ee300b1 100644 --- a/components/esp_http_client/esp_http_client.c +++ b/components/esp_http_client/esp_http_client.c @@ -656,10 +656,10 @@ static esp_err_t esp_http_client_prepare_basic_auth(esp_http_client_handle_t cli esp_err_t ret = ESP_FAIL; auth_response = http_auth_basic(client->connection_info.username, client->connection_info.password); - ESP_GOTO_ON_FALSE(auth_response, ESP_FAIL, error, TAG, "Failed to generate basic auth response"); - - ESP_LOGD(TAG, "auth_response=%s", auth_response); - ESP_GOTO_ON_FALSE(ESP_OK == esp_http_client_set_header(client, "Authorization", auth_response), ESP_FAIL, error, TAG, "Failed to set Authorization header"); + if (auth_response) { + ESP_LOGD(TAG, "auth_response=%s", auth_response); + ESP_GOTO_ON_FALSE(ESP_OK == esp_http_client_set_header(client, "Authorization", auth_response), ESP_FAIL, error, TAG, "Failed to set Authorization header"); + } ret = ESP_OK; @@ -688,10 +688,10 @@ static esp_err_t esp_http_client_prepare_digest_auth(esp_http_client_handle_t cl client->auth_data->cnonce = ((uint64_t)esp_random() << 32) + esp_random(); auth_response = http_auth_digest(client->connection_info.username, client->connection_info.password, client->auth_data); - ESP_GOTO_ON_FALSE(auth_response, ESP_FAIL, error, TAG, "Failed to generate digest auth response"); - - ESP_LOGD(TAG, "auth_response=%s", auth_response); - ESP_GOTO_ON_FALSE(ESP_OK == esp_http_client_set_header(client, "Authorization", auth_response), ESP_FAIL, error, TAG, "Failed to set Authorization header"); + if (auth_response) { + ESP_LOGD(TAG, "auth_response=%s", auth_response); + ESP_GOTO_ON_FALSE(ESP_OK == esp_http_client_set_header(client, "Authorization", auth_response), ESP_FAIL, error, TAG, "Failed to set Authorization header"); + } ret = ESP_OK;