From 4f8bd12479e009850e21c09b3fb4a79b60034ffd Mon Sep 17 00:00:00 2001 From: Armando Date: Tue, 13 Sep 2022 11:39:12 +0800 Subject: [PATCH] esp_adc: added comments to c3 test thresh, also sync to legacy tests --- .../legacy_adc_driver/main/test_legacy_adc.c | 12 +++--------- .../esp_adc/test_apps/adc/main/test_common_adc.h | 4 ++-- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/components/driver/test_apps/legacy_adc_driver/main/test_legacy_adc.c b/components/driver/test_apps/legacy_adc_driver/main/test_legacy_adc.c index c635e9d518..d877a1d661 100644 --- a/components/driver/test_apps/legacy_adc_driver/main/test_legacy_adc.c +++ b/components/driver/test_apps/legacy_adc_driver/main/test_legacy_adc.c @@ -27,14 +27,14 @@ #elif CONFIG_IDF_TARGET_ESP32S2 #define ADC_TEST_LOW_VAL 0 -#define ADC_TEST_LOW_THRESH 25 +#define ADC_TEST_LOW_THRESH 35 #define ADC_TEST_HIGH_VAL 8191 #define ADC_TEST_HIGH_THRESH 10 #elif CONFIG_IDF_TARGET_ESP32C3 #define ADC_TEST_LOW_VAL 0 -#define ADC_TEST_LOW_THRESH 50 +#define ADC_TEST_LOW_THRESH 60 //This is due to ADC2 accuracy is not as good as ADC1, and also we use weak pulldown #define ADC_TEST_HIGH_VAL 4095 #define ADC_TEST_HIGH_THRESH 10 @@ -48,17 +48,11 @@ #elif CONFIG_IDF_TARGET_ESP32C2 #define ADC_TEST_LOW_VAL 2147 -#define ADC_TEST_LOW_THRESH 50 +#define ADC_TEST_LOW_THRESH 100 #define ADC_TEST_HIGH_VAL 4095 #define ADC_TEST_HIGH_THRESH 0 -#elif CONFIG_IDF_TARGET_ESP32H2 -#define ADC_TEST_LOW_VAL 2147 -#define ADC_TEST_LOW_THRESH 50 - -#define ADC_TEST_HIGH_VAL 4095 -#define ADC_TEST_HIGH_THRESH 0 #endif //ADC Channels diff --git a/components/esp_adc/test_apps/adc/main/test_common_adc.h b/components/esp_adc/test_apps/adc/main/test_common_adc.h index 740c1093cc..99b80a0eb1 100644 --- a/components/esp_adc/test_apps/adc/main/test_common_adc.h +++ b/components/esp_adc/test_apps/adc/main/test_common_adc.h @@ -72,7 +72,7 @@ void test_adc_calibration_deinit(adc_cali_handle_t handle); #elif CONFIG_IDF_TARGET_ESP32C3 #define ADC_TEST_LOW_VAL 0 -#define ADC_TEST_LOW_THRESH 60 +#define ADC_TEST_LOW_THRESH 60 //This is due to ADC2 accuracy is not as good as ADC1, and also we use weak pulldown #define ADC_TEST_HIGH_VAL 4095 #define ADC_TEST_HIGH_VAL_DMA 4095 @@ -88,7 +88,7 @@ void test_adc_calibration_deinit(adc_cali_handle_t handle); #elif CONFIG_IDF_TARGET_ESP32C2 #define ADC_TEST_LOW_VAL 2147 -#define ADC_TEST_LOW_THRESH 50 +#define ADC_TEST_LOW_THRESH 100 #define ADC_TEST_HIGH_VAL 4095 #define ADC_TEST_HIGH_THRESH 0